Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp771809rdb; Thu, 22 Feb 2024 21:51:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWvwcD/4c0QZnZeTb2Yn55IIRe3obk/73lqF1nTTyNdSu2nmjLRfiCTHKBxAmPJKiha9+4XuW/2QWErUP5iI1LVunK8nUJkV9USuYTc6g== X-Google-Smtp-Source: AGHT+IF24icTH9Fu0YlW8Y/c1t/HnQEZe0bYgUZrd5qzPiTQj65WL9+6DGdj+TrXdbHbxZMP3tKj X-Received: by 2002:a62:ed08:0:b0:6e4:8ec9:efa7 with SMTP id u8-20020a62ed08000000b006e48ec9efa7mr894211pfh.33.1708667507611; Thu, 22 Feb 2024 21:51:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708667507; cv=pass; d=google.com; s=arc-20160816; b=rQonECgcm/xWL9l1rvxE9h6XFS+dzuF94RkGhtvJbX9sNYmEJgOPFfxvFeswpcp+8G Zhyti1+YRFGzlwXTB79QbPJIUcdBRZ2DGbF/58VlrlOK3iLGoQZ2kcwBYzQ8lKtZXs8D YJhLFvhKQAu5T9L4FTD1fZ7ujTMQkyVJlWVO51qFqhiyrV1qPAgcft4zscA+fiSq4x5X K2NUkr39zqS7yfmtroBBwZh+rN9izq8n6aUDrMUof6R313rYenwbBJoxioVIcqq0zYzy u+Ug9GumOS9QWb8rZkpuY5y/xQeu9lYu3xjKKotcyC/gGlpRI+UuNhnR3TUygj8XBDWz KZoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZrD4aVisPoatToYkXMHA67YFZEJaZr2i7UcckDCOmFA=; fh=Ufeon4dyX/GaEJEWfDMBaDB2XZUjuAt4UOwKs8Xz99s=; b=anWpYI0gY2MRALCoXhBP8nvyW3FrNqIg8keq9jr6dIuyPFKnORMy3gaTq8U2ataGTm vbXOtnecwNypn5RkTCoJdprT79/fXxjw8rvZ6vBkJ2FbqkUGQLUZEszIQlzjAecBJVDU qWcoZbGBsY9M7MAh+893d68bXX1GsShDabDaOyqVWVNkS+26hGXjJQDD2iOlXSAuX0D2 QtvYj/q6jnkCaMP6oc4r3x8FBuUu9Ws1MqBDpvSGlPH2q3zXfM+ss3NYA2Dlx45kBGrg 7gXIfaR80R4LaES/SUNKzC7ALd33nbdScgZbbrHSFP64GxhDhIug8K7xbMuutBPU7Vpq Hk9g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VRdtD3FF; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77810-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id by41-20020a056a0205a900b005dc893fcd81si12245401pgb.29.2024.02.22.21.51.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:51:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VRdtD3FF; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77810-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 99642B26507 for ; Fri, 23 Feb 2024 05:51:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 167EC12B66; Fri, 23 Feb 2024 05:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VRdtD3FF" Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EECBB125B8 for ; Fri, 23 Feb 2024 05:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708667452; cv=none; b=cT2HXcSyiszo2NYPN57KAlSE3TPGqYQUNgJ7J5Ly3D0Li52nL7uKAbAv8aMNgOVJJN2ONVI2FbM+qry6tvScGm1rVOCewLwZyO40uDkZ8+UOqGmgGlmw6QfyYvL+tVRQDVrYXEVGzLS4R5l7YBpW2XRo6sLd+e0N7GACsQb8KKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708667452; c=relaxed/simple; bh=6CcSPVx9G4kFBCSEc197AtRmLI7s5cZLnX7peLANnHs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nLKQf2jGIwGdqaB8Nn42bxuDnUxPx8m08y3O3aZyJaBw/liCEnybizDWfR0/wqBGWSBcWXzsvKGQVbb7hl8fooD0TGu5XOCj6Bjxop9jBu1yR7PIi5F8JVJTP6XfxJ2/RZEVKDL2nU95AjrGiIdqqAatqjLZnHF2iOglk2lpZ1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VRdtD3FF; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5d81b08d6f2so444532a12.0 for ; Thu, 22 Feb 2024 21:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708667450; x=1709272250; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZrD4aVisPoatToYkXMHA67YFZEJaZr2i7UcckDCOmFA=; b=VRdtD3FF+DvtMDIKxWW87q7tzOW3sNFbQ+8J3t8lCtZFiD1xrBVAOcZf0TEE853Lj9 hJGD4WoZpUi4+lD5i1TlTeN/Nh7iX3UPiY+15A+qwdLkD0gr/jxLsHn44RQWfGu9NCU1 ENOyLJIDdeHpovIonUvzLEfrtZXrOCKrBjjDY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708667450; x=1709272250; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZrD4aVisPoatToYkXMHA67YFZEJaZr2i7UcckDCOmFA=; b=CX9bVIeyqxdZYS3OyHxTu7AB8Nbk435bl4Jbt0PUqUOHAmfphN7z15tGUW4y0LPpcp kmnEy/114/F0Ym2zDMh2OUo3cGWpsi4mCX3Ov+DjIForRwZEA6IBraaL9sCzcKyqo925 9RerJ1Itf6OalOOQ5jvpiw5UPUMHmRwG2otV6rBFtjA37bRUcaw8ELIUpiqYCPXEPlxu w0sg5KKZ2+Iw1iBra0fs799s5jHekBCA+aST3PPJCxG7xXoNxVndWpFPpFN4DCqN3ex/ B7TXYaUoSYi5Uu7OpetFjfUV++rt+r0uX5f9Plu3aPJAyqBZZF/gYMtTARlWDpl/+JzT /DWA== X-Forwarded-Encrypted: i=1; AJvYcCWTS20YpZr8bFLTfppTNujepCcZlLYoK8PMXYvIzOe6vqNo8qrptGPq/0S2xXmbuqMIYCliw23TEnPtTpsf6cZsVRvqRF0r88YZGUUQ X-Gm-Message-State: AOJu0YzESyZxbsiq2i6du5kkKMjiWSoPCab2Pg/sIii0ZggMLAT1xFdd f6GSAmRrOMdJzZiC4QGEM/xij4oZJ2xn4Qrbi854NPrcmCAybBDKCcmzVzlXVA== X-Received: by 2002:a05:6a20:d905:b0:1a0:e248:dbb5 with SMTP id jd5-20020a056a20d90500b001a0e248dbb5mr255442pzb.50.1708667450261; Thu, 22 Feb 2024 21:50:50 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b194:4f71:568a:eeb0]) by smtp.gmail.com with ESMTPSA id c4-20020a170902aa4400b001d911dd145esm3329047plr.219.2024.02.22.21.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:50:50 -0800 (PST) Date: Fri, 23 Feb 2024 14:50:45 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: hannes@cmpxchg.org, Sergey Senozhatsky , Minchan Kim , Andrew Morton , nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 3/3] mm/zsmalloc: remove unused zspage->isolated Message-ID: <20240223055045.GU11472@google.com> References: <20240219-b4-szmalloc-migrate-v1-0-fc21039bed7b@linux.dev> <20240219-b4-szmalloc-migrate-v1-3-fc21039bed7b@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219-b4-szmalloc-migrate-v1-3-fc21039bed7b@linux.dev> On (24/02/20 11:37), Chengming Zhou wrote: > From: Chengming Zhou > > The zspage->isolated is not used anywhere, we don't need to maintain it, > which needs to hold the heavy pool lock to update it, so just remove it. > > Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky