Received-SPF: pass (google.com: domain of linux-kernel+bounces-77812-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 23 Feb 2024 14:56:26 +0900
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Chengming Zhou <chengming.zhou@linux.dev>
Cc: hannes@cmpxchg.org, Sergey Senozhatsky <senozhatsky@chromium.org>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>, nphamcs@gmail.com,
	yosryahmed@google.com, linux-mm@kvack.org,
	Chengming Zhou <zhouchengming@bytedance.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 2/3] mm/zsmalloc: remove
 migrate_write_lock_nested()
Message-ID: <20240223055626.GV11472@google.com>
References: <20240219-b4-szmalloc-migrate-v1-0-fc21039bed7b@linux.dev>
 <20240219-b4-szmalloc-migrate-v1-2-fc21039bed7b@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240219-b4-szmalloc-migrate-v1-2-fc21039bed7b@linux.dev>

On (24/02/20 11:36), Chengming Zhou wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The migrate write lock is to protect the race between zspage migration
> and zspage objects' map users.
> 
> We only need to lock out the map users of src zspage, not dst zspage,
> which is safe to map by users concurrently, since we only need to do
> obj_malloc() from dst zspage.
> 
> So we can remove the migrate_write_lock_nested() use case.
> 
> As we are here, cleanup the __zs_compact() by moving putback_zspage()
> outside of migrate_write_unlock since we hold pool lock, no malloc or
> free users can come in.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>