Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp777293rdb; Thu, 22 Feb 2024 22:09:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUIBHAfhlrff8vczEp1CNQuGD740iRlF+K5e5uyN+OP13hNFygdpFas4ZBLNwedVBSwL4ahUneZSDHagu5NxA895qdky6I4iB4hckUwpg== X-Google-Smtp-Source: AGHT+IGGC8uALXWONvK/OtQRPxVy+t+pudoB4hZxW7ggf9vjduFKKeDaveRHIwox8+0lhvAQqeZg X-Received: by 2002:a17:906:2296:b0:a3f:7c3f:7681 with SMTP id p22-20020a170906229600b00a3f7c3f7681mr547161eja.36.1708668553140; Thu, 22 Feb 2024 22:09:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708668553; cv=pass; d=google.com; s=arc-20160816; b=lHfy2my7ycWibvo66tLbwxFHvFGBLA7IBetVLgq/BRiaiW9XUta+7KNCeBChtuGZFm Q7fvm3hj7MNcrgXbIk8cVDUT0dH/Y0xJfQZSWPLqy48aiR1LBv933kjoBpNa4hCe1bdf CFMMhAurc4a3sN92OsLEsVNQlJ8+tLtpmQiA5jfuxiFK6JFIv3/wHPYF5ZEeh1opuDw+ HbbO5LgBoUvRGe6VqckY19MxtBMcgXFmxw0WyLzptw6fm3QwlcvGH3CBUR2Gl94T6j7m NXk/kIju4D+dqvx4UF/wtvnA/GqUargqx66BQPWaRKA4OHwp9Myczz0dthDicsTM1+18 IP4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=9rB/xBYOoLz2xFv+ZmS6qsvslM8+03lHX0mUb5mst/8=; fh=TF1zkOm2F21H2g+MeeNd7lqobE6NuiIFlEpz5QLGYnI=; b=EwINY+1tpvpalC2ztinuNWV4H75grF8iQxwT5Tgf2t2cVz0Ngl1eVZ+fg8GYpz6gw6 usGBVTMtdM6g2zS51IAs246CP1bo3/rS/gwY/xV72TCQvcogEcmxxufI1/r6Iy0tsVPM JJPxBU/qUUUozyZ8234OXWxyuUPfRTF+UxM8/RS2srsTlSQzeCinVUusHRQUCodBDVX3 KtH+5iK5GWksPyAwdSXf8eWg+R4XBdEg5QKDpMu28lmB3BenEb8+T7wNta9Ygbr7ZDmW Mx82nC3qym0erf7/n4byJjs5e1K0Nsca6a6ajQEBOUzbhXBuCSiCd2xqDD0naWm4G/u7 rB+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-77822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77822-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e16-20020a170906081000b00a3f65131487si1527021ejd.632.2024.02.22.22.09.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 22:09:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-77822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77822-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DF07A1F248AE for ; Fri, 23 Feb 2024 06:09:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD30F1428B; Fri, 23 Feb 2024 06:09:05 +0000 (UTC) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA7012B6C; Fri, 23 Feb 2024 06:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708668541; cv=none; b=QqYG5kBav9lxngwkKgST+qah1jpX+iB8k0E9/LUiIiMuSjC1psxNamQ9RwqP48dDhFe15wMfVZ28jZY63W8yfOxlG4qfvYVRqE/um7oH5OrciTNkXQ6YfzXUXTFiHqQ5Cp7acCSnrqrBRVNv/Rd0B2rEwlkYeUcdkqBtOxVCsS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708668541; c=relaxed/simple; bh=LE9cCs5zo8ObahidSfS5icMmo+bY1MKluVpvXGuxyb4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=YfF59NH5eSTB/LmMtqOsQXtFVp9g5238n6aVb08Sez6kc+EdznFZNPmK7JLxAshM0bwpgFn3MnQKBb3wcqhmL559vZp/O7/TnFZjQRuMPxJF7uheRVj+xdB4oWO5G6fP7regbc8U9J/Uh5o3azLtlAId0G+XF8DwZEMDkjaMxn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4128f5ec9b7so3479115e9.3; Thu, 22 Feb 2024 22:08:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708668526; x=1709273326; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9rB/xBYOoLz2xFv+ZmS6qsvslM8+03lHX0mUb5mst/8=; b=Kmx0KsO+vPgjmswFrDQTShSVGAEgHnNOgCN/00fN48kU5yMSCOS8+X89qx6TRy9/pX J60bXTq1LjevVH+czAmWObvKg50RiYU/jhFnkPVPEQE4ahqJ/q7L4Fh+snF1jX7M7bQ+ DdO4xvS5CttAw/M+zSVpPL2oTksxPalKZip9PxXK/9LeZs2iiUkj47ImhNM5vRpCcs31 NGCpLqn96oeUV9EjJBiMM5M4HRS2BEBEDa3cwr4VonKWtOcQ/Xu5Zt0i7dh95Qdt0muF eE2AumIOBEamFtvKSzuBaRfDkFCp2jlsiZiAVTOHembMQ2uX5h+bl5xcWxQ46uhMWZk9 3Lmg== X-Forwarded-Encrypted: i=1; AJvYcCWpzI2uZ0rsJ+hc86FaACv34wFG76XegmoEJYtVTBnbktaKJAUdgldhoh8VQ7/6J/Z911U5zthJ9JpAYigkwiGT9cl28W9S9hHfMiyilX57xPNxBPcr8obpX29+6QCY7bJkD1q4bpp3pjlZ X-Gm-Message-State: AOJu0YxLuoSQ/54rG3ftP6UR2et05wOLbTUw3VKGaiT8Ur+z16bzJLm5 4kJPJtzcoT+2MC87clw2LjLviuLKeY4r15G6ZGc6Zlw6ylDZaB2A X-Received: by 2002:a05:600c:470f:b0:412:415a:43ac with SMTP id v15-20020a05600c470f00b00412415a43acmr528947wmo.15.1708668525900; Thu, 22 Feb 2024 22:08:45 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id p2-20020a5d4582000000b0033da1c4c29csm1452241wrq.91.2024.02.22.22.08.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 22:08:45 -0800 (PST) Message-ID: <5bf4ba6d-d8e3-4ba6-a889-cfae8c3ddabe@kernel.org> Date: Fri, 23 Feb 2024 07:08:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs Content-Language: en-US To: Rengarajan S , kumaravel.thiagarajan@microchip.com, tharunkumar.pasumarthi@microchip.com, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, unglinuxdriver@microchip.com References: <20240222134944.1131952-1-rengarajan.s@microchip.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20240222134944.1131952-1-rengarajan.s@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22. 02. 24, 14:49, Rengarajan S wrote: > Updated the TX Burst implementation by changing the circular buffer > processing with the pre-existing APIs in kernel. Also updated conditional > statements and alignment issues for better readability. Hi, so why are you keeping the nested double loop? -- js suse labs