Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp781264rdb; Thu, 22 Feb 2024 22:22:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVxAOG0qeKW2ztqvqxQrt/Ps3IgKtoY0SSWhJBtC+lVlstpvaWJ1saSisFSogaKr6beIJZDTkr/j2k9pZ0gXwVd5WBHaaSM024QNhIWLw== X-Google-Smtp-Source: AGHT+IFUYv5niuwnwPcWgHwBfd76oR92mFxZqm8dn/YHt4pIbVabKxOJ8RxXP0hojWjkByw1aDLs X-Received: by 2002:a05:6a20:47e2:b0:1a0:dda5:259 with SMTP id ey34-20020a056a2047e200b001a0dda50259mr2242060pzb.0.1708669350394; Thu, 22 Feb 2024 22:22:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708669350; cv=pass; d=google.com; s=arc-20160816; b=K49odaTuBrIaBgqm13NZN+7OFQd6veqZjHfFEBN1VTi6irJXhMX60IbHd9FwsvqAEU AydnwIkQuuPV+kld1IU+QuIEppJv1h19QyctSFQ7q6uXsX8gO/3l5jNYQWOQtY1nEGj5 swzfX+HKxbV7Gkw419LKGHNCqXWghVOjQUell6K5/zC8BmZbfCNxpmVv9OXapQnFRrt1 9J+ADApZdAIRnxZpAjj2ukd8Umq4cGXEQcZ71XWpHzJH4UzuMe3RfdgZS03MEazkAhqM Dyjb9u4VFz73/tLiJuibcxYr7V24wp0Gh3JFPpQKvOI1pAlfywblIK2Op0oqH6WLLhAT UHqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UPxIa+kD9NCI/MKxvz8H6VLioO2Ntf4OMScMcbxN7Ms=; fh=CBP2jSxzJ68DWbAbzda8M9hoUOFZg4DDJMCal6gpESQ=; b=aU6qn0thnjo9Fs4K41byjnK3CRZa4U7j4iKBBXZ3N5cWE0g1+3zhZPwod40XE2K2Jn JCbdBlSiEUfvV0Oi3xSk3Cp4psjdHqykj8IwAqS9csWFmrDs9UW85lNvZgnctpeAJbja cg84ZVZSJfksGT0rh0IMZXnA+g0A5NRPCxUcN+5EPcb9AV03wxSMsPY6k+hQmyiEEtz3 V6r/M0Tf1+kXpJ5v0MVaei8ln0u9O+wqGJGQe+D4EGhG5UJNBsUeI36C0W+mazGlbCfm GQOPz6ixrVvQ6KygeZAqf+JLEcHd9m9nia12NlOArinYfqNue9BwTL79ujwjyd+8n/Ns pm+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Wfmo3Tq/"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-77829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id s196-20020a6377cd000000b005dc7e779b7dsi11383679pgc.73.2024.02.22.22.22.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 22:22:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Wfmo3Tq/"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-77829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E407BB23646 for ; Fri, 23 Feb 2024 06:22:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4A8112B66; Fri, 23 Feb 2024 06:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Wfmo3Tq/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE85E125B3 for ; Fri, 23 Feb 2024 06:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708669341; cv=none; b=k9nKOVbqxwnjpXe590FthsWqSkcG47u3QeT/khU1rUqsHfHasaDG9/eqrJrhsy70tfw032V6uFluOrIZBmbuYV5r/gfNhG2+L6ptUuVdFKZoS4TvlYD9d09omeYReTiffdeeDTzxa3FIhEn5TcX11CpDgyuPMBnMu/yym99tKA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708669341; c=relaxed/simple; bh=UPxIa+kD9NCI/MKxvz8H6VLioO2Ntf4OMScMcbxN7Ms=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iwAr8sx9g7IeCEdSGmutElH2n/DGrnFlwrDLKTNmdkwl4hjDzFbcoW0BSdGNQQfw3LoTn8OXJO9HzbST3S3DrY1lwyDO8RzyQ8rhrjf6Yjh/Jsn7wXj3ry9co/9YsWgKtI5BbvkGQiAn6vkGM4fOTXkiwxmbDuVHtPXNV0oio54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Wfmo3Tq/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51751C433F1; Fri, 23 Feb 2024 06:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708669340; bh=UPxIa+kD9NCI/MKxvz8H6VLioO2Ntf4OMScMcbxN7Ms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wfmo3Tq/hiJ/iOgkdl/US6LiFhztoIAEltZMG16oHyydOWWlYpyRGGJeHkmb1/tXd Y9aDz2mPnOtyFUPogrOOMz725lDqY1BcBtPvQYcUnP123SzHnFeNL6fKB7ZCd95jC2 QNgDGtkUCrRStFLnEOiLx+pqDzdEYzQNlMMOpVXk= Date: Fri, 23 Feb 2024 07:22:18 +0100 From: Greg KH To: Mukesh Ojha Cc: mcgrof@kernel.org, russ.weight@linux.dev, rafael@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH vRFC 5/8] firmware: Convert minor inline function to macro Message-ID: <2024022341-protrude-viewer-04a7@gregkh> References: <20240222180033.23775-1-quic_mojha@quicinc.com> <20240222180033.23775-6-quic_mojha@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222180033.23775-6-quic_mojha@quicinc.com> On Thu, Feb 22, 2024 at 11:30:30PM +0530, Mukesh Ojha wrote: > Convert to_fw_priv() inline function to macro. Why? > No functional change. You lost good error messages if you pass in the wrong pointer :( There is a good reason to convert this type of function to a macro, but you aren't using that here, so I'm not going to tell you why it would be ok :) thanks, greg k-h