Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp786928rdb; Thu, 22 Feb 2024 22:41:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUOwE3DtKRWbDmGtSbEtKRkDyWcMt+Hcm6OM/OmFrYA2C2oYWUJax3+AT6J631hE1xjy/chS+qSOE0ioPLR8kzdh6pXkhHS3wlNUIbicA== X-Google-Smtp-Source: AGHT+IEEB2KPGRkpr61WcGrNK9V8m986ANg+hGXBZbpvtQDJqadpfspERbNc2aLUyT4Xqv4AMelr X-Received: by 2002:ac8:5bd3:0:b0:42c:7c1c:b112 with SMTP id b19-20020ac85bd3000000b0042c7c1cb112mr1635597qtb.67.1708670488987; Thu, 22 Feb 2024 22:41:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708670488; cv=pass; d=google.com; s=arc-20160816; b=aR3q9qPAGfVqSje+xqGCm8E6nKg5WfcLfW1/1nvL4ZNOKScO4c38EwmuuXJai6FnBm p0ejiHzA467Jp9Q3rd9VbIrAZds4KDhDxj4V1fnfFPLQGGFTYPO2aQQXOr2VwgzShjtp CWL5Be5Tzr4RQphDCU8RyQQOKvxci6pgidgk630CKFpJoJRRuH3DSaNjn2y4gtTs4TAd M2ukYVB57Xc9bE/3laTzEiBsghhPAnuC6Ni6F1cctTtlMrYG59g78PYGXSwa4sbcqzY1 trpFSRg8W23dM2UFDqN2Le6JtFVX4zg42YsrOPlLfNXuVKp+w8BkaKHAesljwgAmq0uj Ji2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l1Z2QgoLNvQn9EbmGVVkeygMx21FKuk+s/9jRpAWTkg=; fh=n9NFUBY3ypgFgWvbXy6+57e02e6lD27rlAhruEcDI2w=; b=0C69jyLJWFSuvd6WxybK6DHOoAlyhKo0RX8DD/ijBlvX3T67k+Q9GDQ3FiibUjJ9jd 5li8pLWuF+H6mEyylY+HrL58Aofuk/K2cbhOp7/U1GiZfUKOoqP0Euyv6vYLj3gcltmD qnIbJcKyzhhcMsrKk7NPOsV1BRMgPqvNnWSsQWT549H6pIB5/gSklrxPz6E62Pr/f6Rk CpNwsv/tK2v1/GXivDADgJbgwVxjEurxLi+X87Iyzws6yBSkdqm2w9vdqyXVFRg/bgRO kz9SZjuTvl5PspsexlZHHdbU35ZyNOWRs+lzeYJjeFiltDrI2bJhY5FBTPp6gC8XzmlV rzEQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=EUL4UEIP; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-77844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77844-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id a18-20020a05622a065200b0042de593662fsi15725603qtb.191.2024.02.22.22.41.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 22:41:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=EUL4UEIP; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-77844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77844-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AE14F1C210E2 for ; Fri, 23 Feb 2024 06:41:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F170212E45; Fri, 23 Feb 2024 06:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="EUL4UEIP" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 150FD12B6A; Fri, 23 Feb 2024 06:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708670479; cv=none; b=nEvGwpkGZScwWRubPqT+hmcDFWqgWSUl3x2cQLZGZXbqDYwnAWaaFEYMpL869vTjoEN7nwPKM9Vz683UNCJfXeZNuQP0Rozq6CUfslm14DZLRkyr/nlGcAIOeFDTBJK6+s2QbGMFpWMLJb7NJ4wKm8cuEkJR9rLvJKXRCmVF5rM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708670479; c=relaxed/simple; bh=dypHDYf4wlvZtREbD73PlIUET+KS+kYSAis3lxZth+w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HzUQZA1+uJGC9SxEj4ra3L2HynGUM+Phs4nhkxWHi2W+avtICaSO2uBTQ5IRZy1cbq4ntETjec4dRI42mJ/unsWw0vEJx64PVN4Vc8BYFvy8ggq5RmmOFBU4qOcjLKykvXRpyq1YdwFE8AEe0Q0q4AY6DGGDEoCgyd9pnyzRkXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=EUL4UEIP; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l1Z2QgoLNvQn9EbmGVVkeygMx21FKuk+s/9jRpAWTkg=; b=EUL4UEIPpJeOy4pPl2ZhPSaAta osmyuBSVNzjjGtxnSLseTF1O2YCxpTfPDmPMiW+tiGo3T7IwxpoHFfHFqvXL1KMLGu5HxrjoqRn1V DLeXHhlZI37DxS60a9X3N4DaUP+hVVEFQ5b0u/f9kmBQPq6dR5cwTUkWABW0FR69rZQ72WM/H5veG UKYEpfxIBGPFDH526NpxRtqArwhfKME6kkQCEyx0em7UUFK3DQBgQ7aBpVYfLRNboZEEzHvUJ44wi PYS71Pgi29EcvTrpbc5Sf2qc6fecQNvFSv2IaPBkuj1xAkznRBfj+zrxfLg9HuxOzrcPKKazja+UV hV3El6aA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdPF4-00000008Cua-1ADq; Fri, 23 Feb 2024 06:41:06 +0000 Date: Thu, 22 Feb 2024 22:41:06 -0800 From: Christoph Hellwig To: "zhaoyang.huang" Cc: Vincent Guittot , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCHv2 1/2] sched: introduce helper function to calculate distribution over sched class Message-ID: References: <20240222092220.642294-1-zhaoyang.huang@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222092220.642294-1-zhaoyang.huang@unisoc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Feb 22, 2024 at 05:22:19PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > As RT, DL, IRQ time could be deemed as lost time of CFS's task, some > timing value want to know the distribution of how these spread > approximately by using utilization account value (nivcsw is not enough > sometimes). This commit would like to introduce a helper function to > achieve this goal. Maybe I'm just thick but this still looks like alphabet soup to me. Can you try to exlain why this matters, or maybe get help from the scheduler folks to help with explaining the concepts?