Received-SPF: pass (google.com: domain of linux-kernel+bounces-77851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <7ee26662-caab-462b-a5f1-3267e55a6313@wolfvision.net>
Date: Fri, 23 Feb 2024 07:53:58 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 02/14] media: dt-bindings: media: rockchip-cif: add port
 definitions
Content-Language: en-US
To: Rob Herring <robh@kernel.org>
Cc: Mehdi Djait <mehdi.djait.k@gmail.com>,
 =?UTF-8?Q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mauro Carvalho Chehab <mchehab@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
 Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org
References: <20240220-v6-8-topic-rk3568-vicap-v1-0-2680a1fa640b@wolfvision.net>
 <20240220-v6-8-topic-rk3568-vicap-v1-2-2680a1fa640b@wolfvision.net>
 <20240223002834.GA3933946-robh@kernel.org>
From: Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <20240223002834.GA3933946-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WWRMY0VGZmtDNytDbWJuM09xdXRYYUZKWG05N3NNSGRsaVBBTWhIMml5ejdF?=
 =?utf-8?B?WTVnWnZmRFNSTk9XV0VMeFZUNVFNclVBek9ZaEJFbU8zdGF5cEpNa29NdFpO?=
 =?utf-8?B?bmxPd3MzV29scWIwYlc0ZjhURURHNHdyWDhMZ3EzcDJTVG56VnJKUHJGaExn?=
 =?utf-8?B?L3BYOGxxbGo5NUFWbUIxcEtpL013QjEwZmQ4SVVXUEYraGEyaG5BZnBlY09Q?=
 =?utf-8?B?TFRRM3dPeHdmeHpwakRHZWlYdnJqaTZhNjNmNTVlQWFVa0krN2pUaHI5RXJS?=
 =?utf-8?B?REQ3ZFVqWjFaUTI4M0x6QTFtSTVadFFwbUhGNWhPUkRmaG1HZ21hbmRoYmxF?=
 =?utf-8?B?dU9SM3pYM2xXYUpMMGtJdmpyYlh0cmFXNzd2SytvK2hBVzFJK0QzSHpISWdM?=
 =?utf-8?B?aUNuOGVQZDh1VlpQblpwUVFTSEtOdElEUFlNNERyckhJLzZsTVZaK2VMTjVQ?=
 =?utf-8?B?S2I3ZndSb3hRRWNVNlNMREJiWURraGU2VDVJQ3dPQ3BVVmc3QUxJOVBDdEUr?=
 =?utf-8?B?SUFLQjJaRlBBeGl1QUFmMTkrZlZNQnlMT1FnaHNpY3NWSkZ6NCtYUDVyeDl0?=
 =?utf-8?B?bDZkZ1lGdjVyV2lnTWNnVEMyMlRVaTFVWjBaSnlrZEc1a0FYTjk1aEZHM1Nh?=
 =?utf-8?B?UEhLQ0JYSGVkcVJnWjBqb0NjamdERDhSeFdFMDVMY2ZVMmV2Vno1aVdLcnpU?=
 =?utf-8?B?aHVwZC8xcGQ2aUR1SFZNczNIQU13UzlBWUFNUHhOWk9jVEFOOHZQaUFSb2RS?=
 =?utf-8?B?WVdNaEtIOWVBYWVTb3FSOWk3Y3BDQmdRT3B0bUIxVHVtQ005RXJSWGVkRndP?=
 =?utf-8?B?SWM4TExacEJTMjFvMHZrUlJoV3BYYXdzR2xzRnBUMXBnVzM0ZENOZk5kSkZS?=
 =?utf-8?B?V1RNcHA2ZmpDUFhxc2hBZlBoYWxiT1p1S29iVUFsWHQwZkMvY2F2cklBREtj?=
 =?utf-8?B?Q204L2ZGOVlWc3dDN1JqNTlNZldyejJSOFl1Zk5aMFlRNDdYOHowNEZSekhF?=
 =?utf-8?B?NW9MZW5zTE84M2hscEJmZVhoWnp4aWhucS9mL0dSWE4vc0ZvaHRCYUhzVmJZ?=
 =?utf-8?B?OEs0bVNxekpMSTZFT0NUNk43OGU1aU9GNTRQdndzZXVQbm4xSWp5aXQ1Q05m?=
 =?utf-8?B?bFNISzIyMEs5ODZXL2NJS1Y1aDg0cW53QTdSUkd4aTVJSWRUT1BtMjdFTGVP?=
 =?utf-8?B?bWp6TVMyVlZCdkNKbkVQTmZDNXRkaFczQzg1L3hpZWl2a0p5N3U2d2k5d29N?=
 =?utf-8?B?aFhjcTFjVlVXU2dXSFV6MDQ5YnNxODRURHhJdTM2NEYzcWlKb2syQTBZajhR?=
 =?utf-8?B?M0lsdlB3UFpoZFprYWhUbHRYd3h1bVZsSW40UHZQUEkzUXlaUFZ3dktXMFJl?=
 =?utf-8?B?K0JVd1Nta3p2MmNPWEJOQTNYeEY5WGo0NTNHYjlXblFUa0RZd0dyNFRRdEJ5?=
 =?utf-8?B?cFFPRFlTdVYxcnh3eGJ6Ni9rZEhSR0tjckROcGJNdnNwU1h4UEJJbWV4Z3lL?=
 =?utf-8?B?MzJTcm5mcnJVTHZCVE1STXJqREx4Tkd6Q2djR3Z3MGswaWp3WEVDa1pJZTRz?=
 =?utf-8?B?MnFJeFU4Mml3eWxrV21CSFFIQ29HbDNHWGRYTWg2YXVTS2lMbTU2ZzNjYTNK?=
 =?utf-8?B?TU1rY3JFR1JmbDZuZWlRWi9UN0J4YmZpOWU3WWJmSHVDRjNEd0plUk5UYWdH?=
 =?utf-8?B?NklZRFlkUkdWdnROQ3Y2aWp0MUZQek1RMTFDb1VTTHFVRkQyaUpKSWJXQ1hS?=
 =?utf-8?B?V1daeW1JQUFiOFZWNTlLUWFpMmRCclRBSGZBL2RyaHVSRnRKQUZIN1JhV1BN?=
 =?utf-8?B?OFMzQ0ZTU0c4SlFYVENhNVJOdlBHZVN1cDMrS3VZcmpjVzI1b3B0RGJRcloy?=
 =?utf-8?B?Z3BNU1REaW41WjE4MFJieHN5M2VYMXZtZFNBNi8ybXdvQVozYUkrcmlXQlJD?=
 =?utf-8?B?OEhTcENvekI0ckx1RmNQUGR1a0VvVWF1MGFyMyswcUdqTUN6Mkd2cy9kdzAx?=
 =?utf-8?B?WXdGRXorUkpGVHUrdjZXOHoxbGRjUDF2OFVDSFVKaklERC9ZWHRXQmFSN2dj?=
 =?utf-8?B?Z2dYMkNSMkN1VUd4MkgvNTBJdnl3Z1FvdEdCb0h2YnltcnVyVzV6UzZKMDBh?=
 =?utf-8?B?QTIxK2lxUm1QdndaUGVFeDJ3UEVRMDFVY1pEVWdETUdwR1dmQWRaTXZSY3h0?=
 =?utf-8?B?REE9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 61182336-a1f9-45aa-71e9-08dc343c37d2
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 06:54:02.0136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i0bqwZPscipJmu+UMjcPJap+LYwBU70l6/DkuWZhD1hfHkrHTqXmkYhUdT/xzRZe0tdw3nirfCsKA4CuZ/8BvGv5MZ3jvAFkH4dzF9P3A10=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5462

Hi Rob,

On 2/23/24 01:28, Rob Herring wrote:
> On Tue, Feb 20, 2024 at 10:39:12AM +0100, Michael Riesch wrote:
>> The different variants of the Rockchip Camera Interface may feature
>> various ports. Add a new header file with port definitions to avoid
>> hardcoded constants in device tree sources.
> 
> We generally don't do defines for 'port' numbering. I don't see a reason 
> to start.

OK. I'll drop patches 2 and 8, then.

Best regards,
Michael

>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>  include/dt-bindings/media/rockchip-cif.h | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/include/dt-bindings/media/rockchip-cif.h b/include/dt-bindings/media/rockchip-cif.h
>> new file mode 100644
>> index 000000000000..37364ee1f7bc
>> --- /dev/null
>> +++ b/include/dt-bindings/media/rockchip-cif.h
>> @@ -0,0 +1,12 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (C) 2023 Michael Riesch <michael.riesch@wolfvision.net>
>> + */
>> +
>> +#ifndef __DT_BINDINGS_MEDIA_ROCKCHIP_CIF_H__
>> +#define __DT_BINDINGS_MEDIA_ROCKCHIP_CIF_H__
>> +
>> +#define MEDIA_ROCKCHIP_CIF_DVP		0
>> +#define MEDIA_ROCKCHIP_CIF_MIPI		1
>> +
>> +#endif /* __DT_BINDINGS_MEDIA_ROCKCHIP_CIF_H__ */
>>
>> -- 
>> 2.30.2
>>