Received-SPF: pass (google.com: domain of linux-kernel+bounces-77875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <93497e03-1acf-483e-8695-e103fd1bc044@oracle.com>
Date: Thu, 22 Feb 2024 23:36:01 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] slub: avoid scanning all partial slabs in get_slabinfo()
To: "Christoph Lameter (Ampere)" <cl@linux.com>,
        Chengming Zhou <chengming.zhou@linux.dev>
Cc: Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>,
        penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
        roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Chengming Zhou <zhouchengming@bytedance.com>
References: <20240215211457.32172-1-jianfeng.w.wang@oracle.com>
 <6b58d81f-8e8f-3732-a5d4-40eece75013b@google.com>
 <fee76a21-fbc5-4ad8-b4bf-ba8a8e7cee8f@suse.cz>
 <55ccc92a-79fa-42d2-97d8-b514cf00823b@linux.dev>
 <6daf88a2-84c2-5ba4-853c-c38cca4a03cb@linux.com>
Content-Language: en-US
From: Jianfeng Wang <jianfeng.w.wang@oracle.com>
In-Reply-To: <6daf88a2-84c2-5ba4-853c-c38cca4a03cb@linux.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?N29UQnBVdUU3RmNadDN6L3gvdnk2enZ4RHl1RklFTHRva0c1d2ZQVzlleUdp?=
 =?utf-8?B?WGkzREJ0VWpkd2tlQWl5M2hPWTNGSmNQV01ESG1ET2NEK2Q0QVFhZVdjaCtN?=
 =?utf-8?B?d09mSFhEVzdOMld5aXRFSG5MRjlhMUZVc1lPTGdCT1g5REkvY0tOdURUNGVk?=
 =?utf-8?B?aXNIekpPRFNsUWhETHBxb251Z1Z5WHRYbnRsdkdaSnJKeTdLUC9FWjFJK3Ro?=
 =?utf-8?B?MzJlOHB2RTk5cnNoak1hUnlRYW5LRkdaNitkV1lmenJoakZSUTNVUXB4a3RW?=
 =?utf-8?B?UDNnYUlrR1J3NjlncDVYbGRwcENLMGl6M2lCVzljMkZoUkx4bXFqYkkzRUZS?=
 =?utf-8?B?U2pkd2VqcDJkVVpXOHlrUTBoTUF3VkhCMXBVc0ZBZDNtaCtqNHlLRUFSZFlv?=
 =?utf-8?B?YU5kNTEyTTd4MXBqaTljZTVvMHVZSmF5dGRhWGlReGFpNXZiREV6aFlKR21Z?=
 =?utf-8?B?WnNrKzhqejhvQXB4TllEQVVONEw5WmdTcVZTbHJqbk1jMUZ0YnVBV2dMaVhQ?=
 =?utf-8?B?OStEOU1iRFc1UUdNRU5Xc0dYeWJpbDBEaVBueFcvb2RHN0t3aSt5ejliU3Bl?=
 =?utf-8?B?TjAra0paMEZYUmpWOUNLcGNyNVYxUHJJQkZMc2RtVDZ6RGlLR09jZUlEZU1L?=
 =?utf-8?B?OVBqVmc2T0RxL0ZlTXNneE1CYUtYcmg0eGNhUVZtSGdzbzNUcXhPbkp5TDFE?=
 =?utf-8?B?QlhQU21BVkxlOVZXME41ZkQzVm9RZU9aK1VZMFlZMjl5RFFuU2FkN1FIN01R?=
 =?utf-8?B?L0Rzc2wvaHpJRzE3MlJaZWFYWU0ybkVGYUtMbFRKLzJDMVRvZ0lpQkZFeE42?=
 =?utf-8?B?M2VSdVFna1VXOVZBTWFZNlg1c1NtK0J2OUpDRllRMUZITUlSWTNCdGltcWRL?=
 =?utf-8?B?MHRUakRIWnFTYnZ2NEVZL2FsdEpLQkxpbENXUTJ3WGxsNjJaUjVtaE5QelBS?=
 =?utf-8?B?MkcwQXZrdGxqZ2Rpc0RGWVluaGxjZkVseTNuM0lMcDNnSFdNRXBjRHVPVlA0?=
 =?utf-8?B?UDExcFdKOENaMmxHdkM4UkZpTEw5TnhKdS9EckdEb293M25WRmhvb2I0dDJ6?=
 =?utf-8?B?Mit3UFhHL002Ky9pMkJ6M2o3ZEo0RUkxNzRHdVc0UmVhZENSQmNKNVRIRWN2?=
 =?utf-8?B?M3ltamNjWXdDNFdHUzBDb0RnNWROSGxkWjk4RjNoQWE4ZVU2ZlkydDAxTVQr?=
 =?utf-8?B?clJNd2wxbUdRbnBsK2tPMWNsUTkxK0hPU1ptK3pQTTdWaWxFdGRML0hoTzZZ?=
 =?utf-8?B?RVhmL1FvT2Q3TjJ6UDdVQVVFT0VlUkYzU1l4d1BqMk1EY0dJTVdnSUxLMFNv?=
 =?utf-8?B?a3paV24wdVczd2wwRDAwN2IyZHd4cmFkWURmb3J2bDh3cENjbnE1ODlEaWV3?=
 =?utf-8?B?N21hd1dIeUtsZmtEeW9wZ3VVU1l4LzNPd1BiMkN4c2RXSzdLT2tiZEk4RzNr?=
 =?utf-8?B?VmE0cWNSSVFXSW5GMUtwZ2FmTU5FNkUxY3dUSHFlck5RdzJiK0VlK2kvRFZ3?=
 =?utf-8?B?d1RLTkRlTGpNSDhGaUlNWkRzSlBzV3VyZDJaMS9KZGdZSzRxVkcwSy9PQVFB?=
 =?utf-8?B?aEhwKzgzMlhUWTh3RDBDSGo2eFZIYnJBRWNHNUhTcHB6eGZYR1poWklSMlFO?=
 =?utf-8?B?Y0xhemRTMzl3UWRsVmlaNkJRRkFGN3d6dFVERnl5Nm9ya1VZVjJtZS95dlFu?=
 =?utf-8?B?OVExWkd3SDhEYTZXQjYzN3B0bUo0WG9oam5BVnYyL0l6U3lQbHdrbTZjbzVK?=
 =?utf-8?B?QUw1bklZb25LTnpkWkdqZEJJcXVCNFVNTFFvMndEU3JhRlRaZGFtc3I3NHZO?=
 =?utf-8?B?OHJadWUzeVN5OVAza3ZQVUZnRVFySVkzWnk0UkhwVzE0V21yVjY5cmdyTGtn?=
 =?utf-8?B?emVrNTg5eFAyTmFiMjJ4VUpxVlVzN3ZLUVpmVFp5WnVyOFFjelF4OFQxS3A5?=
 =?utf-8?B?L0Rxa1FZQWoyRTNlMFpnckx3ajlMTUw5WnBqS1hlNHlKRWltd25nRFNjVTls?=
 =?utf-8?B?SmVhRTVZbVFtTHFkTUtZSUJZSDR5L2x4dTAzYkhKZ096am85eG9XaExnd01j?=
 =?utf-8?B?VnRHVTd2UEw2QnVVU01yL1o0Sk1IbWw1OEx5YnJpdTIwTE5BYVdoZVErdUlX?=
 =?utf-8?B?MEl0M1VtNklWS24zZjIyeFEwaXJhN24rbzFhWjRxamJSQlMzVFhHbStoTENk?=
 =?utf-8?B?ZkNDZnZ5NjRicFZGZERvVkFsem01QVZVTU1PRElRcXpleWF5ek1EYTQyWFNB?=
 =?utf-8?B?UG90Y1BVaE1obldETURZUncycUd3PT0=?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	bt+V07CgMPSCxcb0caCQYvgTCtZKZLPVlc+eKGVxryUwGTMl2L3INqBy4Ircyg9LOlLreH3KgcKy1kRj52MpA5kqiq3pMV4NMq/4M0FsvBIokWZ7KGw9MrwKdH98scLqxAmUCAgsakIfCOH9BmMj5VcUvkqF1OgiXJPHp9UpABUVhsQsH+iCCtIedk60ffizPzQy0koppX4AegJIypw0HrR1YnqYsC3WH5PD7EJPlsD0ft1zoNEI41UnkaQYcN/Eve2fTtUIKJY43/6I4lGVxCb3semIyxyY1xIBdAo21M0f4YmcPNImXau+6urezhP66JyYfMhgb32c4VrRDrUS+oDVOJbEYZPwZi4j47tO/3bQHoNRmHq7NJ2afkFkzXdCuoYQGYY5LhGf+AVNYqopmOyEiresbKMIAVjaju8yfd/uZEZ3KNCYsZyG5Sof0eP+r9O/evdzznuAYN705tc3iKtz8DWzm4m7ovauBqbsGJ7jQCOYRQ/XSViDNsYsYasopsmkcuADWFPgm5IAy4McvVwBzOmGOqrmlBT+m4+bW1NYvf9Kx/8v2BBOOFTvonNTk9QvoYU27Bl0r3rrNGZ0nIrJcTfTdYDpCsCg5xm76/A=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 452c081b-b5e8-44ca-23a6-08dc3442169b
X-MS-Exchange-CrossTenant-AuthSource: PH7PR10MB6379.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 07:36:03.2969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3IZv8A21FbAVMHMOesk/8zmOWYrRl0RgcBF7mmCHDun9pY2zZMwuES/lXgZNX+Xw1A34wtQG2Xyg7qLgOehIpObnOevLCJ+FMdgpWnI+qqA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4765
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-22_15,2024-02-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402230051
X-Proofpoint-GUID: S_uo9poq4ENa_vc1CDUEbZLqesVZtJWi
X-Proofpoint-ORIG-GUID: S_uo9poq4ENa_vc1CDUEbZLqesVZtJWi


On 2/22/24 7:02 PM, Christoph Lameter (Ampere) wrote:
> On Thu, 22 Feb 2024, Chengming Zhou wrote:
> 
>> Anyway, I put the code below for discussion...
> 
> Can we guestimate the free objects based on the number of partial slabs. That number is available.
> 

Yes.
I've thought about calculating the average number of free objects in a
partial slab (through sampling) and then estimating the total number of
free objects as (avg * n->nr_partial).

See the following.

---
 mm/slub.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 63d281dfacdb..13385761049c 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2963,6 +2963,8 @@ static inline bool free_debug_processing(struct kmem_cache *s,
 #endif /* CONFIG_SLUB_DEBUG */
 
 #if defined(CONFIG_SLUB_DEBUG) || defined(SLAB_SUPPORTS_SYSFS)
+#define MAX_PARTIAL_TO_SCAN 10000
+
 static unsigned long count_partial(struct kmem_cache_node *n,
 					int (*get_count)(struct slab *))
 {
@@ -2971,8 +2973,22 @@ static unsigned long count_partial(struct kmem_cache_node *n,
 	struct slab *slab;
 
 	spin_lock_irqsave(&n->list_lock, flags);
-	list_for_each_entry(slab, &n->partial, slab_list)
-		x += get_count(slab);
+	if (n->nr_partial > MAX_PARTIAL_TO_SCAN) {
+		/* Estimate total count of objects via sampling */
+		unsigned long sample_rate = n->nr_partial / MAX_PARTIAL_TO_SCAN;
+		unsigned long scanned = 0;
+		unsigned long counted = 0;
+		list_for_each_entry(slab, &n->partial, slab_list) {
+			if (++scanned % sample_rate == 0) {
+				x += get_count(slab);
+				counted++;
+			}
+		}
+		x = mult_frac(x, n->nr_partial, counted);
+	} else {
+		list_for_each_entry(slab, &n->partial, slab_list)
+			x += get_count(slab);
+	}
 	spin_unlock_irqrestore(&n->list_lock, flags);
 	return x;
 }
-- 

> How accurate need the accounting be? We also have fuzzy accounting in the VM counters.
Based on my experience, for a |kmem_cache|, the total number of objects can tell
whether the |kmem_cache| has been heavily used by a workload. When the total
number is large: if the number of free objects is small, then either these objects
are really in-use or there is *memory leak* going on (which then must be further
diagnosed). However, if the number of free objects is large, we can only know
the slab memory fragmentation happens.

So, I think the object accounting needn't be accurate. We only have to tell
whether a large percentage of slab objects is free or not. The above code is a
sampling, which should do the job if we take enough samples.