Received-SPF: pass (google.com: domain of linux-kernel+bounces-77881-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 23 Feb 2024 13:14:44 +0530
From: Jai Luthra <j-luthra@ti.com>
To: Rob Herring <robh@kernel.org>
CC: Vaishnav Achath <vaishnav.a@ti.com>,
        Sakari Ailus
	<sakari.ailus@linux.intel.com>,
        Jayshri Pawar <jpawar@cadence.com>,
        Jack Zhu
	<jack.zhu@starfivetech.com>,
        Julien Massot <julien.massot@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Changhuang Liang
	<changhuang.liang@starfivetech.com>,
        Maxime Ripard <mripard@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Aradhya
 Bhatia <a-bhatia1@ti.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        <linux-kernel@vger.kernel.org>, Devarsh Thakkar <devarsht@ti.com>,
        Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Tomi Valkeinen
	<tomi.valkeinen@ideasonboard.com>
Subject: Re: Re: [PATCH RFC 04/21] dt-bindings: media: ti,j721e-csi2rx-shim:
 Support 32 dma chans
Message-ID: <jk7jsiws7ivxwdl4teoviu6qxp43fcj2raxj424m5jtep5dm2u@j3vpbetaimhy>
References: <20240222-multistream-v1-0-1837ed916eeb@ti.com>
 <20240222-multistream-v1-4-1837ed916eeb@ti.com>
 <170860471258.2476270.8232202066004725650.robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="dkpavki64dphg6yq"
Content-Disposition: inline
In-Reply-To: <170860471258.2476270.8232202066004725650.robh@kernel.org>

--dkpavki64dphg6yq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Rob,

On Feb 22, 2024 at 05:25:13 -0700, Rob Herring wrote:
>=20
> On Thu, 22 Feb 2024 17:01:20 +0530, Jai Luthra wrote:
> > The CSI2RX SHIM IP can support a maximum of 32x DMA channels.
> >=20
> > These can be used to split incoming "streams" of data on the CSI-RX
> > port, distinguished by MIPI Virtual Channel (or Data Type), into
> > different locations in memory (/dev/videoX nodes).
> >=20
> > Actual number of DMA channels reserved is different for each SoC
> > integrating this IP, but a maximum of 32x channels are always available
> > in this IP's register space, so set minimum as 1 and maximum as 32.
> >=20
> > Link: https://www.ti.com/lit/pdf/spruiv7
> > Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > ---
> >  .../bindings/media/ti,j721e-csi2rx-shim.yaml       | 40 ++++++++++++++=
++++++--
> >  1 file changed, 37 insertions(+), 3 deletions(-)
> >=20
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/m=
edia/ti,j721e-csi2rx-shim.yaml: properties:dma-names: {'minItems': 1, 'maxI=
tems': 32, 'items': [{'const': 'rx0'}, {'const': 'rx1'}, {'const': 'rx2'}, =
{'const': 'rx3'}, {'const': 'rx4'}, {'const': 'rx5'}, {'const': 'rx6'}, {'c=
onst': 'rx7'}, {'const': 'rx8'}, {'const': 'rx9'}, {'const': 'rx10'}, {'con=
st': 'rx11'}, {'const': 'rx12'}, {'const': 'rx13'}, {'const': 'rx14'}, {'co=
nst': 'rx15'}, {'const': 'rx16'}, {'const': 'rx17'}, {'const': 'rx18'}, {'c=
onst': 'rx19'}, {'const': 'rx20'}, {'const': 'rx21'}, {'const': 'rx22'}, {'=
const': 'rx23'}, {'const': 'rx24'}, {'const': 'rx25'}, {'const': 'rx26'}, {=
'const': 'rx27'}, {'const': 'rx28'}, {'const': 'rx29'}, {'const': 'rx30'}, =
{'const': 'rx31'}]} should not be valid under {'required': ['maxItems']}
> 	hint: "maxItems" is not needed with an "items" list

Thanks will fix in next revision.

> 	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
>=20
> doc reference errors (make refcheckdocs):
>=20
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202402=
22-multistream-v1-4-1837ed916eeb@ti.com
>=20
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your sch=
ema.
>=20

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--dkpavki64dphg6yq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmXYTOsACgkQQ96R+SSa
cUXppxAAiKve/pejPnfyEE6LI718RJadaeKyqDT2+qv/N6KmqzlLizyKRnfta4yG
04AOumjKIUJjXXZ6AuVHs1qXSCnan0ux6h1hTcBVeCnz4iWQchaJ7mwmO8puJRIH
rwABkD8TGxeAhBhMnBjfF7pyyCZsTLIJTzJw5Vtee5FlqY2Yz7xhCqdsqoBMpBTz
5gJoUOLv/HYfUZWI+nnxTOTw95UJEhTGq8Id40neo9AygAZi4h/3NdH9y44Ivy4E
sAbKaeVaGbjtfRu1HpfoEZGIyUPlp7j3g9z435+kS1G3agOVTE9qf71EgoJfGXu1
WvW7/gzZcG9ncU/38ekNxApqQm953BNNa9OOpGL08rCdZWMsA3l7sHHkf4H5vpga
ehyJLHga+6oGiViMojmUBBAS0AB24qOldB944cClRLdXcek32t1SmpP4SLL8wupv
ttISmAcxnD6ab2Cxz2FY1roA2UTADXyb6JbT+OJSxBhNNlLVyDxyUQ76HLTs1o6W
ZZ7n13bLOjs9gus0U0KTJhNXnwaAp8nYc//TGSiEqrAjJ+M4wystJdrbrrdbG+BF
/1rHPZU3iM1tEKhYxk6HBPhLIFih+bHmnRj5sKrYMig7W3LW4sHasLUr2mFE8Wlb
vTGMHEFlTXu+mQVBPx6PNI0RWS3o4xW+ThEH1IK5y9ap5+fkLWA=
=9a+5
-----END PGP SIGNATURE-----

--dkpavki64dphg6yq--