Received-SPF: pass (google.com: domain of linux-kernel+bounces-77890-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240129054551.57728-1-ioworker0@gmail.com> <CAK1f24keWtJNVv37r2vNsqnmMLRMvF-F76WR5RD_Y-BbAgEaYQ@mail.gmail.com>
 <CAK1f24nk19eciysFqvTd=rqpiKePhstDWEEQ_mvT89WCDNrWNQ@mail.gmail.com>
 <CAHbLzkoNFn6UE4Hn0gXTm2pLHD7pK4gYUe1zVh3247m30A5u2g@mail.gmail.com> <20240222131151.4d24563d58240e76a3b535db@linux-foundation.org>
In-Reply-To: <20240222131151.4d24563d58240e76a3b535db@linux-foundation.org>
From: Lance Yang <ioworker0@gmail.com>
Date: Fri, 23 Feb 2024 15:59:07 +0800
Message-ID: <CAK1f24nzfh9n5qZ=uMSC_WP8g0HCmOpRrZZAM0FYOfpp1CD-Yw@mail.gmail.com>
Subject: Re: [PATCH 1/1] mm/khugepaged: bypassing unnecessary scans with
 MMF_DISABLE_THP check
To: Andrew Morton <akpm@linux-foundation.org>, Yang Shi <shy828301@gmail.com>
Cc: mhocko@suse.com, zokeefe@google.com, david@redhat.com, 
	songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for taking the time to look into this!

Thanks, Yang and Andrew!

Best,
Lance

On Fri, Feb 23, 2024 at 5:11=E2=80=AFAM Andrew Morton <akpm@linux-foundatio=
n.org> wrote:
>
> On Thu, 22 Feb 2024 12:23:21 -0800 Yang Shi <shy828301@gmail.com> wrote:
>
> > > VMA Count |   Old   |   New   |  Change
> > > ---------------------------------------
> > >     50     |   23us  |    9us  |  -60.9%
> > >    100     |   32us  |    9us  |  -71.9%
> > >    200     |   44us  |    9us  |  -79.5%
> > >    400     |   75us  |    9us  |  -88.0%
> > >    800     |   98us  |    9us  |  -90.8%
> > >
> > > IIUC, once the count of VMAs for the process
> > > exceeds page_to_scan, khugepaged needs to
> > > wait for scan_sleep_millisecs ms before scanning
> > > the next process. IMO, unnecessary scans could
> > > actually be skipped with a very inexpensive
> > > mm->flags check in this case.
> >
> > Thanks for following up on this, can you please capture all the
> > information in the commit log?
>
> I added it.
>
> --- a/txt/mm-khugepaged-bypassing-unnecessary-scans-with-mmf_disable_thp-=
check.txt
> +++ b/txt/mm-khugepaged-bypassing-unnecessary-scans-with-mmf_disable_thp-=
check.txt
> @@ -9,6 +9,24 @@ and the MMF_DISABLE_THP flag is set later, this scanning=
 process
>  becomes unnecessary for that mm and can be skipped to avoid redundant
>  operations, especially in scenarios with a large address space.
>
> +On an Intel Core i5 CPU, the time taken by khugepaged to scan the
> +address space of the process, which has been set with the
> +MMF_DISABLE_THP flag after being added to the mm_slots list, is as
> +follows (shorter is better):
> +
> +VMA Count |   Old   |   New   |  Change
> +---------------------------------------
> +    50    |   23us  |    9us  |  -60.9%
> +   100    |   32us  |    9us  |  -71.9%
> +   200    |   44us  |    9us  |  -79.5%
> +   400    |   75us  |    9us  |  -88.0%
> +   800    |   98us  |    9us  |  -90.8%
> +
> +Once the count of VMAs for the process exceeds page_to_scan, khugepaged
> +needs to wait for scan_sleep_millisecs ms before scanning the next
> +process.  IMO, unnecessary scans could actually be skipped with a very
> +inexpensive mm->flags check in this case.
> +
>  This commit introduces a check before each scanning process to test the
>  MMF_DISABLE_THP flag for the given mm; if the flag is set, the scanning
>  process is bypassed, thereby improving the efficiency of khugepaged.
>