Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp814740rdb; Fri, 23 Feb 2024 00:08:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVG3OpSMAnM6+1Y5xwN8yqwEoTnwhrt7dLD0zjTncRraqmqhSzpCjOJzbpOYNP6oKf5Vl5cOIg6ApeY/O6qVEsx5krtuQAvwLvyXiR+sA== X-Google-Smtp-Source: AGHT+IEgyHxYGyWWYN35NrnsJMQypG1/piFftccutt7kysk0CmRs24o94JSk/Lg9NAHzfAC7OEu7 X-Received: by 2002:a17:906:48d9:b0:a3f:84c8:37e7 with SMTP id d25-20020a17090648d900b00a3f84c837e7mr730156ejt.58.1708675710895; Fri, 23 Feb 2024 00:08:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708675710; cv=pass; d=google.com; s=arc-20160816; b=BBQxwW1S81dqrgN/miHDCLhhR3kOVmdNFeyiZKD90L+tkASmYCo0hQN55YbgaOSZbY ahxlm2c44rnQforLYtauIWIz3WymS5Ygh8lIvWpCyLFD6ZPqsSHMEgAN03RtKinX9y8B +AJk5wx4h6xXCVOQCgZsWUs7ygdtW8iGYpBjQA9Dtr0nId2L1a4ZwO9zVgUZ05pt27eP OqZcaCvLLOpK3cSTAJQ8DJBNFnlqiXlGbvdvrj5KOnRHkTifXTNy3/eR0Mog72nz+kGh 5N8qsbGCZI3TjYoEDXVjYE/upQ87EBTS48aGa6+8bWbNKlZlI0+lDh1Kn4tlWbuib0xz qKlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xsiN/ljP64pgHp7MckY5MiOkdkHElillrvV7z8+lh7w=; fh=8DYu7hEZnfOKz8raIQkeMuIl5TIwtVW8vrBSs0XLekQ=; b=HQNxPdUXkfVcfaEg6csV5gNIlSAdjD5b3sAIM7H3r+o7GEiYy4Bi04Oa2r3Lv2Axkx ZZEWjPCnf9io1orTEJi2F+wTYb4qXbjVaZNNuaAIU7DTHeNvsPvGRN8pFV9jV2MkBzBn dZpUtRQ2DBKhCWaIVkXRDGyfNmRjCJ9jWBpn/v4ci6bLLZD0isF4t7Li2o49PDF4og+f MbvMRyIRFCse3UL0Nuel59pCdiEfxB6YKZ50KJJBeajYF2zYoRb+sQ82Ped8EbpSJs5U diCmoIsnnY6eUrM/CvAacruaPppa+TnwF4sl+A9leAeTsS0vP4NKREinaqO/yLN+tUPx 2q5g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jg3XufS0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-77895-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77895-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gs38-20020a1709072d2600b00a3d59c61574si2634658ejc.991.2024.02.23.00.08.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 00:08:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77895-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jg3XufS0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-77895-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77895-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A32001F2513A for ; Fri, 23 Feb 2024 08:08:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4A2C175A1; Fri, 23 Feb 2024 08:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jg3XufS0" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA79171A3; Fri, 23 Feb 2024 08:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708675694; cv=none; b=gYQJYZKALYYDrvjYOmPb6PsZ4naS5uvKkWADeIEiS/Dsav4kbCWWak/e1mi4Nij9cuUNJ+/+6BspzbhHOyaJX+GPlLBJAsx1FDFDAUBeAMXc9PRs2cjPXlT96NGC+tsbPknmar/5wzVlymKMZCuN0nPRJ8ITBvEfhoHwmxjsmIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708675694; c=relaxed/simple; bh=sHWn05MJttavUBMB12+GNMdadLjZiLx3RXhhBDrmsJ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FLVFLbFuiY4m7qiPVRJVvHHFNzBwV8sfTr3nTdbAL0LNvfpLSxyrTJ7cQxlFinIES8g2kSoHS9Y40pxvG1iWcrVys0DZP6SdJfgo7f5WcbI+Zqjd9AAlguMT0KwYXuyRJXKrutKhQ1MOr04lXn2gJdjaeA2kWOgT5Xbzqfbr2gI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jg3XufS0; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B05A8C433C7; Fri, 23 Feb 2024 08:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708675694; bh=sHWn05MJttavUBMB12+GNMdadLjZiLx3RXhhBDrmsJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jg3XufS0q2T0sNHkSOrBEvEFenHkbXULgGhZWIT/XqOkumh1aj0AiFgeSUL7Z6Hyf 5Bty9R6AcZFx0YaW121AcFq+dSWQMWU8RrZy3vqXKB/NyVtOeIaOBmRcs1zzLDjiKY uJIS2kyqqlK5TlhAMzk/j/70dR0J5sICT2U4aWIroXzev3OEltfWpNjQ3uN/PhJZY/ Ss3LBviK+JcQf4ucWSVTPNaVDQevgquBsc8UzNJSLe/UTPBiqC6QxkmZE18KgHBwKQ tZz6Yz0TLQD1ogAfVNnqygGlx7NnzU9hEiD0oyA7ZFDlfo6bUNETAb7lVpxzM7ka0h 6/mVZwFzxICOg== Date: Fri, 23 Feb 2024 09:08:05 +0100 From: Christian Brauner To: "Seth Forshee (DigitalOcean)" Cc: Serge Hallyn , Paul Moore , Eric Paris , James Morris , Alexander Viro , Jan Kara , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , "Matthew Wilcox (Oracle)" , Jonathan Corbet , Miklos Szeredi , Amir Goldstein , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, audit@vger.kernel.org, selinux@vger.kernel.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [PATCH v2 06/25] capability: provide helpers for converting between xattrs and vfs_caps Message-ID: <20240223-beilhieb-nagetiere-83d9488f05f8@brauner> References: <20240221-idmap-fscap-refactor-v2-0-3039364623bd@kernel.org> <20240221-idmap-fscap-refactor-v2-6-3039364623bd@kernel.org> <20240222-wieweit-eiskunstlauf-0dbab2007754@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Feb 22, 2024 at 09:38:04AM -0600, Seth Forshee (DigitalOcean) wrote: > On Thu, Feb 22, 2024 at 04:20:08PM +0100, Christian Brauner wrote: > > > + if ((magic_etc & VFS_CAP_REVISION_MASK) != VFS_CAP_REVISION_1) { > > > + vfs_caps->permitted.val += (u64)le32_to_cpu(caps->data[1].permitted) << 32; > > > + vfs_caps->inheritable.val += (u64)le32_to_cpu(caps->data[1].inheritable) << 32; > > > > That + makes this even more difficult to read. This should be rewritten. > > Do you meant that you would prefer |= to +=, or do you have something Yes.