Received-SPF: pass (google.com: domain of linux-kernel+bounces-77896-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240223-b4-bus-v1-0-2803c3ac4673@outlook.com> <20240223-b4-bus-v1-2-2803c3ac4673@outlook.com>
In-Reply-To: <20240223-b4-bus-v1-2-2803c3ac4673@outlook.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 23 Feb 2024 09:08:21 +0100
Message-ID: <CAMuHMdVX6s9At21wGVO0Z6fY=gYkw9dooo0WsCorbrkoqBkehQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] drivers: bus: simple-pm-bus: Get and deassert resets exclusively
To: forbidden405@outlook.com
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Yang,

On Fri, Feb 23, 2024 at 4:49=E2=80=AFAM Yang Xiwen via B4 Relay
<devnull+forbidden405.outlook.com@kernel.org> wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> Simple Power-Managed bus controller may need functional reset(s)
> to be deasserted before child devices connected to the bus can be
> accessed.  Get the reset(s) as an array and assert/deassert the
> reset(s) when the bus is being power managed.
>
> One example is that HiSilicon USB2 INNO PHY test bus needs to deassert
> the reset to the bus before accessing its registers.
>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>

Thanks for your patch!

> --- a/drivers/bus/simple-pm-bus.c
> +++ b/drivers/bus/simple-pm-bus.c
> @@ -62,6 +64,10 @@ static int simple_pm_bus_probe(struct platform_device =
*pdev)
>         if (bus->num_clks < 0)
>                 return dev_err_probe(&pdev->dev, bus->num_clks, "failed t=
o get clocks\n");
>
> +       bus->rsts =3D devm_reset_control_array_get(dev, false, true);

Please use the devm_reset_control_array_get_optional_exclusive()
wrapper.

> +       if (IS_ERR(bus->rsts))
> +               return dev_err_probe(&pdev->dev, PTR_ERR(bus->rsts), "fai=
led to get resets\n");
> +
>         dev_set_drvdata(&pdev->dev, bus);
>
>         dev_dbg(&pdev->dev, "%s\n", __func__);

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds