Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp820388rdb; Fri, 23 Feb 2024 00:24:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWqbgXbPubNmUgdf+4sG1b9fbhCgHXsBTXLoPJlf0oqmSXkzo86YHpjlt8YfC6wJh6hNHQBmE9Vf0erCHR6q6yE32swXs8p0HQAhStmpA== X-Google-Smtp-Source: AGHT+IGL8r5GYL1lOkWGPx0/ERk0MoiXy8cG/eMepLrJ1o8tcgrOV06fY2QullcquxGR7rd6QBtO X-Received: by 2002:a05:6214:d0c:b0:68f:361a:4b18 with SMTP id 12-20020a0562140d0c00b0068f361a4b18mr1732774qvh.45.1708676673720; Fri, 23 Feb 2024 00:24:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708676673; cv=pass; d=google.com; s=arc-20160816; b=1G4JpZjcBQvOGM+tl54R2zCdvtNRLcqKbS1mDCuPSDtJA1eKV8v4G5DX9+4OP/TwST DNqvBCnomVtF7r1RFvTRoE0dHLd+QOSDBGIe0arWxryco9XY86in2empofE7PglkQco5 0qH5vhsIPk9XWFVu4eBe3+nJ29KE9LUDYGUSug2ZMPP+/vdpaN15xXSDvUUj9olcg1YB Eb0B34aPWGwUeiX6F8FBex0sCeS9b2W3AKJT/XdGGslH//UE8EpR3QSgUV5HOf10jFXQ 0D9EBblsMj7WAPCszmOJlxr+bYtigHEJTJlhonizSHxqWd4VtOYTvKWO0sjDGoi1LoLo 3UwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=PtiE5YsPAwLeVnO25Rw3lo88vzD1tgPN/pCeVYsbuVU=; fh=8DYu7hEZnfOKz8raIQkeMuIl5TIwtVW8vrBSs0XLekQ=; b=EL/u1FZPTPPewtUszhGa6gsuMh8BNzw6+1vHJaUg232Os1dd4h66UHxIE7EEnkhFtc CXguufes07KJv/K3CVQxVSkZ95QiZ5VzcPUf4h9RpOGudQ61nrak+xNfboce77shAY9A 7exPI/qJ0BD0ygFU46wlRzuFLlJ1qVd/oVxdOAHZ36SthJIhLO/sqw6C6XoVUS4KvAao scsD9QWsIUDsR1jf1DheRCE8CHvCFLPKU6BOqDDWdSoHRsW0eEf/IzA4iq3TsLo2QS96 wYDT9a5tUB5+FHpiu2S92XKpqPFeaUOoyJ/MTzue1sH2BXyghP4+Qv71SgjAeN2xSQhX ZTDw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="m8qlj/Q/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-77922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77922-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id r17-20020a056214125100b0068f2eed6059si14724528qvv.234.2024.02.23.00.24.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 00:24:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="m8qlj/Q/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-77922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77922-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6C7C21C218AA for ; Fri, 23 Feb 2024 08:24:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3780F1A702; Fri, 23 Feb 2024 08:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m8qlj/Q/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405811799D; Fri, 23 Feb 2024 08:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708676630; cv=none; b=X1Qz4RtlWvIUUbbO3q0MTHkF1EY4mxC3z75Ei2ZWVzrtqIeQTRsuSXKTK3keIPvu/Bp7Me90STChbNIAeU12N+9zJjoBPWKUgpnjWJ/hop55S5NkECh2JjUY+rpRRH+2Hiqk2jRhkWZffgYsjXhaqUbbiIkKAaLhp6QcL19esnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708676630; c=relaxed/simple; bh=2pRL/DHKpNavrBYCEdxRER3bzRbwjnSyn6+Le6BPexg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ac87q6aZBK/3JNK21bN1j9x/Rf/4nF4bp9bXtZUcO6iFOy2r3z4pn3a8AKwGkaF0uVhfRa11R0uFwtKAT/VxwuBtrDnpq08xb7GSbPDx4egY6VJe2vixl8Y7hKGbvuWbIIWfi7Q+iVGEdhW7v1h3F6hVFso+Y53lLIeSobCxY3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m8qlj/Q/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6724CC433C7; Fri, 23 Feb 2024 08:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708676629; bh=2pRL/DHKpNavrBYCEdxRER3bzRbwjnSyn6+Le6BPexg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m8qlj/Q/6twHNGmgMEhqf+gHAUuT1pceqZRy6RPWg+g5+1yAQGO2v7RW9qTnvz3gH GnL3Hppha6HjbhiG49JDkujP9bNdPRFlNagkOllw1++EXolSNuM8IKPZ6/2Nuhxpwk EOaQwj8bQZrl5NagUA2ropmzLvgV0rj6LGLvPNRRPCZokhBDJS8OnSu9qZZhdc/sFt bH1FhG4aD11dzFXA4WiIYCL/ac1hi6Ae/wl5z7mmW59Ub1+EoWslwPn3W1tAjqIhsj YlJim2O3buoF+rsuZy/6sZ8VIgAgKHSMU+GTEcIEm58qK6YW/YHZiTVrXKAN7bDWNp au/oLYyVUv1mg== Date: Fri, 23 Feb 2024 09:23:42 +0100 From: Christian Brauner To: "Seth Forshee (DigitalOcean)" Cc: Serge Hallyn , Paul Moore , Eric Paris , James Morris , Alexander Viro , Jan Kara , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , "Matthew Wilcox (Oracle)" , Jonathan Corbet , Miklos Szeredi , Amir Goldstein , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, audit@vger.kernel.org, selinux@vger.kernel.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [PATCH v2 11/25] security: add hooks for set/get/remove of fscaps Message-ID: <20240223-anfallen-kegeln-4550c939a31a@brauner> References: <20240221-idmap-fscap-refactor-v2-0-3039364623bd@kernel.org> <20240221-idmap-fscap-refactor-v2-11-3039364623bd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240221-idmap-fscap-refactor-v2-11-3039364623bd@kernel.org> On Wed, Feb 21, 2024 at 03:24:42PM -0600, Seth Forshee (DigitalOcean) wrote: > In preparation for moving fscaps out of the xattr code paths, add new > security hooks. These hooks are largely needed because common kernel > code will pass around struct vfs_caps pointers, which EVM will need to > convert to raw xattr data for verification and updates of its hashes. > > Signed-off-by: Seth Forshee (DigitalOcean) > --- Looks good, Reviewed-by: Christian Brauner