Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp823350rdb; Fri, 23 Feb 2024 00:32:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU+lVeH2s6jWldYMX6guSkU+UonJJloDasky0Bi0644DALStTPpjzOob+RwshWCsSFm9SAeO7goykB98ySLvLK3YZDAd0BpSwtfsjsaxQ== X-Google-Smtp-Source: AGHT+IFFJuakdIER9j3KsBr11FeCyFj95fRkOprcFiVmyg4FMaZdzStcM0gW0vgFHPZ98cb/hH3a X-Received: by 2002:a17:903:41ca:b0:1dc:1ff5:3dfe with SMTP id u10-20020a17090341ca00b001dc1ff53dfemr1451145ple.27.1708677154786; Fri, 23 Feb 2024 00:32:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708677154; cv=pass; d=google.com; s=arc-20160816; b=pfJa3/JgAP7As76LpNHkf/0UA9cxThomSOm6aUEqWwXRJKBoApPNXmft0fKXIznNpD Zotgsbwlu5bokajFc0THi+wUWTmJA0oFWcusoq1Pkeh0+f1mHpHGuYVDlphmcGPqOQ6H xNtN7P7nue9xaQ9jDVPsbvSQBELF3nwHxbA2I79WsuCE5wtiigpiV2Nn2lpDWQEl6AAU yvTm3SK42LlbqbMTYUXproDIolVBzBQh+Pgytfemm1F7Du06qeDCpc9uWkl+q/lrQs8P de3bncs3N1gxNUTFApYVpFM2YqOYE4dVPIwWT4l4kgnKp3HswujJIVrZO2/EgrV2XMZG M6DA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9EyU+TqYdEgIpNC5JKOWfugLJIi3wbElmckhemRIwQk=; fh=8DYu7hEZnfOKz8raIQkeMuIl5TIwtVW8vrBSs0XLekQ=; b=ap4WeT4UC5apfJQhKIGN2LV7pXm8ZwpQ4HnhioAE+b3z7Fax9/53m4bbkdxPaW32cW a2I+ajhRYYP4DrqIwfxUzyNfthaa3hQSx+PxSb/C2NDTKZJX3G2A7cDocZhpIAy45dSD O7yTlVPVuRUHSTjH33oyfGo2YghB8xniVwoMqGreeuOFvxIIkGjbX+lSTrGkA4/fnHQ5 wGSLjyFA6Gw7BcPc2gnbJSCnX29QQGIQEtBEKXJhnUK0H5TFHCB9fAPIOwkghJG7F09g ZyawpuxNGFon2gUjLhbBF3rAbrVHYk6038jchShDzNoNCvqZnlWSQUVH4dvahD2J5ljh qkgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i5O9J95v; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-77925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77925-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y16-20020a17090322d000b001d91df66e39si12122931plg.210.2024.02.23.00.32.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 00:32:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i5O9J95v; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-77925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77925-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C57C9B255BE for ; Fri, 23 Feb 2024 08:26:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 187FE18E20; Fri, 23 Feb 2024 08:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i5O9J95v" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210E11862A; Fri, 23 Feb 2024 08:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708676766; cv=none; b=hOLLtORdyR+mxG4mwGqM1pMPYeHbvAqEDXguTiOsskCq29VW1r3w500vS/MkurB0wiUfRUo55IWTXUAP47dWDr+VtoAQV+gvbNLcSrP/EJiC/zclvVvWQNIhzAmaJeubXtJWxiYgGQuq2lYs/D/G2wb0frsLZGmJ0b9qUS5Wgc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708676766; c=relaxed/simple; bh=d4+85PokRLij+Pmcnj8Pzm2cYiTlHEWq84xygWKmed4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JGRvh27WeoDs8iWwfXYlhmKdcHoTmxweCvRu/rnSVzZeUXJdWiH2QaF5jaN4DPMvnfhDbLF5+ZPolo87nFU+r6MGNz8QgbTzw4EoMCc3rSkHCqCf+ma0x/Rvl7fIvqs1TPJwdxVTRrMh9hsg22IgRR721bxCqLEK5u8LdTI04gI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i5O9J95v; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F2DCC433C7; Fri, 23 Feb 2024 08:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708676765; bh=d4+85PokRLij+Pmcnj8Pzm2cYiTlHEWq84xygWKmed4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i5O9J95vaF2F1dkRoBkfaW7+FCxJ20NW/E9KygKO7GFkmI66PWmV1g1X8hqQ52Y/F L2zxy0cpQxjWkAMB455E0lrlAW8+YQok/uXW/w0aUIlDlydD5Dq3s/n0pZr6aVxGHj hQe12ogvC9AcqWjPbb/maDCxlmDN6jaAtPia8b5yZgLBMJevCH+I1xNq8N1Krbu+yo A8WBGiQBZAmZcS+r+tGLZv9bS/xIGw5rR8K9WbbLqIdvs9I0qJ2d5YH8xcX6iMa0RY tZd/K5dMIS+QZadpDrhbudfAz8gxUcodysUo8Jk4lm5q78tqx5UkJ8/FdeiR+4J9wW DCRCXRV8EXMRA== Date: Fri, 23 Feb 2024 09:25:58 +0100 From: Christian Brauner To: "Seth Forshee (DigitalOcean)" Cc: Serge Hallyn , Paul Moore , Eric Paris , James Morris , Alexander Viro , Jan Kara , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , "Matthew Wilcox (Oracle)" , Jonathan Corbet , Miklos Szeredi , Amir Goldstein , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, audit@vger.kernel.org, selinux@vger.kernel.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [PATCH v2 16/25] fs: add inode operations to get/set/remove fscaps Message-ID: <20240223-landen-frisst-06ff8597cdf5@brauner> References: <20240221-idmap-fscap-refactor-v2-0-3039364623bd@kernel.org> <20240221-idmap-fscap-refactor-v2-16-3039364623bd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240221-idmap-fscap-refactor-v2-16-3039364623bd@kernel.org> On Wed, Feb 21, 2024 at 03:24:47PM -0600, Seth Forshee (DigitalOcean) wrote: > Add inode operations for getting, setting and removing filesystem > capabilities rather than passing around raw xattr data. This provides > better type safety for ids contained within xattrs. > > Signed-off-by: Seth Forshee (DigitalOcean) > --- Looks good, Reviewed-by: Christian Brauner