Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp826904rdb; Fri, 23 Feb 2024 00:43:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVgAg7QypePVFrUvCH5CW0zNgPBzkW3+FBJc32d8Iqr8IFRegy38QRTQ29388A2ptU5s3+HlFGbZcbJ/DeqXXEBCk/yJ3sZ719cPwQqKw== X-Google-Smtp-Source: AGHT+IF2Qj5xFTF8n71xcz7rK44b952mnPq+RcfcS7FaWhCabT3au7SIyYtSOlwlnv3VlUfczzIP X-Received: by 2002:a05:620a:1275:b0:787:a338:7a1c with SMTP id b21-20020a05620a127500b00787a3387a1cmr1320963qkl.75.1708677808334; Fri, 23 Feb 2024 00:43:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708677808; cv=pass; d=google.com; s=arc-20160816; b=g9HqbxtK2M8ulD0dYzDG3wfmWutC5ZaPghW+bZAZ+qeCg/AxaBJxIWV+24UiR/JQJJ szVY65wPBT75dITdsD2MD1Alv8hgjMOi/ttNT6AnSRK1QNKHcW1uRJbKUEZNYdWxoo37 mtBWSAOeJV14+MdXDc4sNxbKiaFUjLRujl4ZEkeuyRVIsBZ59DWYeZlTeCXbiO6aoPIT JfP9FzwYlXbVDadHTJ6HOUJbb/56/2GaDcJTGfOX7HM3ZLow9yhV7mV9j8uCV/OEVyt5 XCNIwxg7aOdpH2sATQkz9ihHGv0pu6c/Ftq1HqtBPHzC6/yJphRsaRT0d1Al6LSpBWih iZmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OiJDQB4qO/BiZTaoBusROTB4kKwGWFW9QgAlSQFuM4c=; fh=6UpAXv9E5EPSji7flndtkHl8gICsRnFY/O6oEyAz2z8=; b=r3r6ab6QInAt2jnydIFSFvECQaXsKUZHMg9rfkmlo61nNl7VHoW3w8E5pwuev6Lq80 BwQqfKwrgt3HC56omvEa/+EE8AVrA3HxApKxGYhCYuL12869vFf4ejEKgWhWeccY9SEe CLPU6A3EL4r2BMihXWHaWxya2P3sqUeBGX2j5PfJpuIwAx3r9eD+wqhLqNPCOV67i88S CiHtWyRZ/U5EamwgSCZZmYqwNb3kt0J42IXeHMOqEVCZsmU+UBqzReUL9EUzFCWgyTzm CCIJzAs99uKVcrKvPLb71UkEybL/dXKMk2tu+pH01ojSC2W+eupk0coCfrClFSHoTZMc rT2Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="a/GE7Ycn"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e17-20020a05620a209100b00787a7ba5611si2141028qka.92.2024.02.23.00.43.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 00:43:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="a/GE7Ycn"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E7C881C217C0 for ; Fri, 23 Feb 2024 08:43:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D810218EB9; Fri, 23 Feb 2024 08:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="a/GE7Ycn" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4700618E0E; Fri, 23 Feb 2024 08:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708677799; cv=none; b=GRRI1LTyQpwHPcGy3sEWluA+qoSUrInHGLA/CkRoZfMz6fobzKX9GO0ktqvqDOgqjC8lbh4UzxkRFDItBd8G5EXVFuHjPqPV/yQq1AS4cUXcMfvkdPwLYYp0Jsl6pBfb6FGKl8ucXS9kCXxu0cCe/o4WkCfqfDRDjCemnacDUWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708677799; c=relaxed/simple; bh=IEeTlpxURy3/yxx9Pu6JpPyffFdM2y6Tfz9e7EtiqbE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DFuY9gaQk0tSluj6T/aAWGeVkxogCVMV7jV04vBj1PVeXN5hHayfHXydxGfv2PVrmDBApbMjDf3KnwlAJ9EH6kWzODEIUI987ZWfkpZE5p5KoTm4fERXr1YPgXAGtvaBZLED9HzDOGk5N8MgMEOFq8fJXNpK/eUSMPsLhEpFYI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=a/GE7Ycn; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708677797; x=1740213797; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IEeTlpxURy3/yxx9Pu6JpPyffFdM2y6Tfz9e7EtiqbE=; b=a/GE7YcnnKw4ZAhiIvHWQXP9syXTouQtCTed7mT4SA8qkPG7yDOidaKz XfxNI2xDto6SX1qNJIzpRgte7P5HrZ7odfLQYOKBWNLUT/IVG+1o7w18A y10d+ZvQCK2H13kLU1shn5wzZbtIZzHU+xy5A0LyUuvBPpKqZMhoJbH6V Gc25UodTO/vV4yMbkBBc0YCN0jr0MIhbJztapa1Im8CryF+jQRivAOfM/ QA1HARDnTWsHG5EPBfpTAJ7dKGqxU6YsR9Gdm/rFY3sKeDqFHZPRf8Usy TaojJ4y38xggtLB0Fe47skFeRLVpv5VL5wTxfuvP5YLusx3Vz1Sqo+05C A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="6767826" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="6767826" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 00:43:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="43297602" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 00:43:14 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 13BF511F81D; Fri, 23 Feb 2024 10:43:11 +0200 (EET) Date: Fri, 23 Feb 2024 08:43:11 +0000 From: Sakari Ailus To: Mikhail Rudenko Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Jacopo Mondi , Tommaso Merciai , Christophe JAILLET , Dave Stevenson , Mauro Carvalho Chehab Subject: Re: [PATCH v2 00/20] Omnivision OV4689 refactoring and improvements Message-ID: References: <20231218174042.794012-1-mike.rudenko@gmail.com> <87o7c9q27c.fsf@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 23, 2024 at 08:15:41AM +0000, Sakari Ailus wrote: > Hi Mikhail, > > On Wed, Feb 21, 2024 at 06:02:15PM +0300, Mikhail Rudenko wrote: > > > > Hi, > > > > On 2023-12-18 at 20:40 +03, Mikhail Rudenko wrote: > > > > > Hi, > > > > > > This series contains refactoring and new features implementation for > > > the Omnivision OV4689 sensor driver. Specifically, patches 1, 2, 3, 5, > > > 6, 10, 15, 16, 18, and 19 are refactorings, and are not supposed to > > > introduce any functional change. Patches 4 and 7 perform migration to > > > CCI helpers and subdevice active state respectively, and should not > > > introduce any hardware- and/or user-visible change either. Patch 8 > > > fixes a possible race condition due to v4l2_async_register_subdev_sensor > > > being called too early in ov4689_probe, and patch 9 migrates power > > > management to PM autosuspend. > > > > > > Patches 11-14 expose more sensor controls to the userspace, such as > > > (read-write) HBLANK, VFLIP/HFLIP, digital gain, and color > > > balance. Patch 17 implements configurable analogue crop rectangle via > > > .set_selection callback. And finally, patch 20 enables 2x2 binning > > > option. It should be noted that publicly available sensor > > > documentation is lacking description of many registers and their value > > > ranges, so a lot of values had to be found by experimentation. > > > > Gentle ping on this series. Anything I can do to help getting it > > reviewed and merged? Maybe split patches 15-20 which implement cropping > > and binning and change the driver away from register list based model > > into a separate series? Anyone? > > Oops, my bad. I'll review these shortly. I can already tell there's not > much to do though. Done. -- Sakari Ailus