Received-SPF: pass (google.com: domain of linux-kernel+bounces-77959-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240220135431.22910-1-brgl@bgdev.pl>
In-Reply-To: <20240220135431.22910-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Fri, 23 Feb 2024 09:57:46 +0100
Message-ID: <CAMRc=Me7h9fzTqu7hkfOOGdFz4dwcgcVOdLu+3KovX9nZk5U4A@mail.gmail.com>
Subject: Re: [PATCH] gpio: sim: delimit the fwnode name with a ":" when
 generating labels
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 20, 2024 at 2:54=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev.pl>=
 wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Typically, whenever a human-readable name is created for objects using
> a software node, its name is delimited with ":" as dashes are often used
> in other parts of the name. Make gpio-sim use the same pattern. This
> results in better looking default names:
>
>   gpio-sim.0:node0
>   gpio-sim.0:node1
>   gpio-sim.1:node0
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/gpio/gpio-sim.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index c4106e37e6db..1f3dd95dd6da 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -420,7 +420,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *sw=
node, struct device *dev)
>
>         ret =3D fwnode_property_read_string(swnode, "gpio-sim,label", &la=
bel);
>         if (ret) {
> -               label =3D devm_kasprintf(dev, GFP_KERNEL, "%s-%pfwP",
> +               label =3D devm_kasprintf(dev, GFP_KERNEL, "%s:%pfwP",
>                                        dev_name(dev), swnode);
>                 if (!label)
>                         return -ENOMEM;
> @@ -833,7 +833,7 @@ static int gpio_sim_add_hogs(struct gpio_sim_device *=
dev)
>                                                           GFP_KERNEL);
>                         else
>                                 hog->chip_label =3D kasprintf(GFP_KERNEL,
> -                                                       "gpio-sim.%u-%pfw=
P",
> +                                                       "gpio-sim.%u:%pfw=
P",
>                                                         dev->id,
>                                                         bank->swnode);
>                         if (!hog->chip_label) {
> --
> 2.40.1
>

Patch applied.

Bart