Received-SPF: pass (google.com: domain of linux-kernel+bounces-77970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: imx8mp-evk: Add HDMI audio sound card support
Date: Fri, 23 Feb 2024 10:06:33 +0100
Message-ID: <1786327.VLH7GnMWUR@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <1708675339-8180-1-git-send-email-shengjiu.wang@nxp.com>
References: <1708675339-8180-1-git-send-email-shengjiu.wang@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi,

thanks for the patch.

Am Freitag, 23. Februar 2024, 09:02:18 CET schrieb Shengjiu Wang:
> The AUD2HTX is a digital module that provides a bridge between
> the Audio Subsystem and the HDMI RTX Subsystem. This
> module includes intermediate storage to queue SDMA transactions
> prior to being synchronized and passed to the HDMI
> RTX Subsystem over the Audio Link.
>=20
> AUD2HTX works as the cpu dai in HDMI audio sound card.
>=20
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 12 ++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi    | 10 ++++++++++
>  2 files changed, 22 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/bo=
ot/dts/freescale/imx8mp-evk.dts
> index f87fa5a948cc..63f6e72fa18a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -138,6 +138,14 @@ simple-audio-card,codec {
> =20
>  	};
> =20
> +	sound-hdmi {
> +		compatible =3D "fsl,imx-audio-hdmi";
> +		model =3D "audio-hdmi";
> +		audio-cpu =3D <&aud2htx>;
> +		hdmi-out;
> +		status =3D "okay";

No need for 'status' here.

Don't you need to configure the PAI as well? See [1]
for downstream implementation. I'm wondering because I had to hack something
similar. Without I got no HDMI audio.

Best regards,
Alexander

[1] https://github.com/Freescale/linux-fslc/blob/6.1-2.0.x-imx/drivers/gpu/=
drm/imx/imx8mp-hdmi-pavi.c#L51-L59

> +	};
> +
>  	reserved-memory {
>  		#address-cells =3D <2>;
>  		#size-cells =3D <2>;
> @@ -191,6 +199,10 @@ &A53_3 {
>  	cpu-supply =3D <&reg_arm>;
>  };
> =20
> +&aud2htx {
> +	status =3D "okay";
> +};
> +
>  &eqos {
>  	pinctrl-names =3D "default";
>  	pinctrl-0 =3D <&pinctrl_eqos>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/=
dts/freescale/imx8mp.dtsi
> index 9ab9c057f41e..721ab630d895 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 {
>  					status =3D "disabled";
>  				};
> =20
> +				aud2htx: aud2htx@30cb0000 {
> +					compatible =3D "fsl,imx8mp-aud2htx";
> +					reg =3D <0x30cb0000 0x10000>;
> +					interrupts =3D <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks =3D <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>;
> +					clock-names =3D "bus";
> +					dmas =3D <&sdma2 26 2 0>;
> +					dma-names =3D "tx";
> +					status =3D "disabled";
> +				};
>  			};
> =20
>  			sdma3: dma-controller@30e00000 {
>=20


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/