Received-SPF: pass (google.com: domain of linux-kernel+bounces-78023-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 23 Feb 2024 10:34:16 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: sparclinux <sparclinux@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andreas Larsson <andreas@gaisler.com>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: sparc: patch to fix parport_pc build on 32-bit
Message-ID: <20240223093416.GA2800152@ravnborg.org>
References: <4c4e2845-c7a8-4d0b-aa4a-7c5e3399b3dc@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4c4e2845-c7a8-4d0b-aa4a-7c5e3399b3dc@infradead.org>

Hi Randy/Andreas.

On Thu, Feb 22, 2024 at 09:15:28PM -0800, Randy Dunlap wrote:
> Hi Andreas,
> 
> Please pick up this patch from June/2023. I have already replied to
> the patch with:
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> 
> and I just rechecked it on linux-next-20240223 to make sure that it
> builds cleanly. It does; however, there is one trivial merge warning:
> 
> patching file arch/sparc/include/asm/parport.h
> Hunk #1 succeeded at 20 (offset 1 line).
> Hunk #2 succeeded at 252 (offset 1 line).
> 
> The patch:
> https://lore.kernel.org/lkml/alpine.DEB.2.21.2306190121540.14084@angie.orcam.me.uk/

I took a quick look at the patch. It does the minimal to fix the build
but the ebus_dma thing is only used by sparc64 an should not be visible
at all for sparc32.

I think the right fix is to make the current
arch/sparc/include/asm/parport.h sparc64 specific and use
asm-generic/parport.h for sparc32.

	Sam