Received-SPF: pass (google.com: domain of linux-kernel+bounces-78076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org, joe.jin@oracle.com
Subject: [PATCH 1/1] x86/split_lock: add the source of exception to warning logs
Date: Fri, 23 Feb 2024 01:47:46 -0800
Message-Id: <20240223094746.11305-1-dongli.zhang@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?1VGKK0hM/N0BMmsm3bG+a/L/YGuEDMzxUqoCS/e+2BMEBYOrh3kCEzV1eCLo?=
 =?us-ascii?Q?BPlcHcSBGWx/hFMBvkEqfjXuU5+zfxIPvaxKk5YNJXVOZhuH1A5DtTjaJScy?=
 =?us-ascii?Q?TgknxVn9cC+8cXTSy6YhZXcehIlDtWW3jhJVwKKABS6eYH0uFyujmEmEiGgQ?=
 =?us-ascii?Q?BYQDuxnUgC1184GbqGg0U1jH4sgsaxlyQWxp52IJIR/agd/KxQOtcHoLhWp9?=
 =?us-ascii?Q?r/u9UPIzL9Hiv2CJ17akdoYMNW8a175Du+H8fKStwdyLNQhm/anAl6ewW5CB?=
 =?us-ascii?Q?h7yAr7US3dDF93Akv6ne7OqoHZKmyB/ssJQWNlV1xhAXLxUjaYMGZ5cmFwnx?=
 =?us-ascii?Q?Yag/Bg1kxvFOnquLeNyrEMzpqjvgQoxPR3EUDMxUrcciCkty44HcUsiPVvm1?=
 =?us-ascii?Q?Bxkpd1+6LKcar9KUueLBQ786LsJpqyQS+L7xxgDIVn70YAveCCRXXW143nlE?=
 =?us-ascii?Q?wshZs5RbeJuC8YnspNNT8wrvt5pPbBhhliC4nf9xcmCTqMPc+wj6SMaiyFSg?=
 =?us-ascii?Q?tCuCdxnoS6ySqYfdNcj6r5Pm0S2CDe718SyatIN2Kl0I9EcWLBKjDDxYOl/R?=
 =?us-ascii?Q?+rn4OPTmXdMlX1LAlpZofFWeGKn1FvD/3jfyWdpalfVbfPhiblbcI8kbAF25?=
 =?us-ascii?Q?nZXSBjDiUMQ+dfmhZze2JKSBPtrtR4mpzUbCmjVU6uVvWxP9ILf/qPihEqfv?=
 =?us-ascii?Q?mIHVJGe6ZTSEK3k9AdhtW/9j/bOjANzydnUb1IVGqYWviWldK7bUu9II9SI0?=
 =?us-ascii?Q?RWrhKLrt4KuH+gzNwKppaUoB1Kkra5KYEDZ8g+Hrp8NCudd0jtEskzIx3wQy?=
 =?us-ascii?Q?jMEmqbfoe1DvjHx9P1mGRVT/i1WBfepOEFQfgyXx+Iw+uGEoHrqDXS0hDj4A?=
 =?us-ascii?Q?VDaXfsK5LYfw6S/B/waT1CfYQtVOyQxwsLt7KS38J0XwKezylj9cN66312hE?=
 =?us-ascii?Q?Ncqhxm3ImVBim5Ej5VWVeveYwhCsY5QD5Qe64EPxdwUrMloKVDuIUHnA9aPD?=
 =?us-ascii?Q?9O32XTWN99GTvJXjUrmEZpClCBTIEBNxs2Me+MLvgBCwaiwzWed9LddhpWSp?=
 =?us-ascii?Q?4AoUpLgcowGBNpqYa1oqjNK0lU+0Hj6Zss4bx1hSSmhSikfJh/TNQAF5fEaM?=
 =?us-ascii?Q?cUR0R9mfavKHwK8hwwtBpoToiYBy1qDzkqmNe/Y7NTV++LAdszuyxlDEsL/f?=
 =?us-ascii?Q?tH6An6Q+4WDiBb5qfPCWNXfdpHMGHBJQnOTAlA4Vqz8zA2Su/VquWBTpKeIJ?=
 =?us-ascii?Q?kB9/Ss9yT73xBvze+EM4oJANpPpGCCoLz05kDVi9tZsDgAP60IckeB+zQeXN?=
 =?us-ascii?Q?0bBfskX54Ody7KieiGUarcSw8evbfRwCWGe0iEo4xNmVoPqcXslTZd2VB9QB?=
 =?us-ascii?Q?BQzT1No1qQB2nQkLwJNbM01LYaYoUTNOgj2MHcHXQGH8AMHqKZQ++uy1oFzk?=
 =?us-ascii?Q?wIy6M5UHCL6PaWCpFvNagya+wrEVsC3R6uh97N52U9JYkE4giAzPAwiuE7ep?=
 =?us-ascii?Q?SubqwNgl8nUQLYEWrPGUH69S6p7qG0znptsioMmV8BLykIfIkS9tGOXztE08?=
 =?us-ascii?Q?IiGLqOWhebT8KVAeeuh1hmxhYi2NPOoBLTfV0wBK?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	BjMQFCjoeLxj3WLy1gYQWELz1Qo6hCSNUrUKCZxm37X6zMHxN7Dt9t5YXdBySc6gsQrMsFiJwhX9P42hzYJNiMa361WtJj8lDdMtV5Y9rQHU8pSIaksrijQSXK+nOS+82bkU8r/DJZIDnkK28y8pRe5ja9BUbXYCAWTukvDpz8ToY0/G2TiMeuyGvUwBs0jZtD3XNfRmidBL+RBBwmHUDUnlQvsAYcpHWdNXuKxc7CJ8NY5ZMz3vZlS9IeC0TJNu1TT0wtfq7MujtAI1Uaatc22mXiGEv5Xxn+9Zyte3gnENb/Ng7FdUvjHR5f0lBEqtqQcYCgC5U1f0h30zRlRIXjgWsdq5NPPgnzsKiQ42YQPHyz2pN0njQqgxTMuzlYTYFfpRQGqanNanOuo5iy4UZi1gpGF2VvE6A6scLOrZspF76qt2h2ZZxixhMHPGgP0r3SS3lOu/NJvu7u2qK6xXonVoayj71Xp/B80nAAn/urjg86GGkBatMfYO0MuzJLbUVfxyT2ejqWGVpHZe+YpMUkomjiAIbrTrSZltVYa1o6t42Lup68ZKCTlOE5it5iBO5heuG0vfAwDLGVOdVvvCCO4+z/d6RdkJX0Itgk4ucvQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6517ce9-410f-4671-5c7f-08dc34549372
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 09:48:23.7408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MPGUDxsflTlqwKTUZk+JQTCzV34pb4CgUOS8TkSIDSxGPvD9NdcN0B4YRqsId37KY1MS84heWK5VvXVkcZiiOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4881
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-22_15,2024-02-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402230069
X-Proofpoint-ORIG-GUID: mSUZRtkx1f-hLSfZplTwSWomq0WIA040
X-Proofpoint-GUID: mSUZRtkx1f-hLSfZplTwSWomq0WIA040

Currently to trigger split lock exception at the guest side will print the
below to host logs.

"x86/split lock detection: #AC: CPU 1/KVM/65886 took a split_lock trap at
address: 0x401173"

Although it is more likely the split lock exception is from the guest side,
differentiate if it is from the guest side, or the host userspace
VMM (e.g., QEMU).

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
 arch/x86/kernel/cpu/intel.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index a927a8fc9624..22285e7cc138 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -1155,14 +1155,15 @@ static int splitlock_cpu_offline(unsigned int cpu)
 	return 0;
 }
 
-static void split_lock_warn(unsigned long ip)
+static void split_lock_warn(unsigned long ip, bool is_guest)
 {
 	struct delayed_work *work;
 	int cpu;
 
 	if (!current->reported_split_lock)
-		pr_warn_ratelimited("#AC: %s/%d took a split_lock trap at address: 0x%lx\n",
-				    current->comm, current->pid, ip);
+		pr_warn_ratelimited("#AC: %s/%d (%s) took a split_lock trap at address: 0x%lx\n",
+				    current->comm, current->pid,
+				    is_guest ? "guest" : "user", ip);
 	current->reported_split_lock = 1;
 
 	if (sysctl_sld_mitigate) {
@@ -1194,11 +1195,11 @@ static void split_lock_warn(unsigned long ip)
 bool handle_guest_split_lock(unsigned long ip)
 {
 	if (sld_state == sld_warn) {
-		split_lock_warn(ip);
+		split_lock_warn(ip, true);
 		return true;
 	}
 
-	pr_warn_once("#AC: %s/%d %s split_lock trap at address: 0x%lx\n",
+	pr_warn_once("#AC: %s/%d %s (guest) split_lock trap at address: 0x%lx\n",
 		     current->comm, current->pid,
 		     sld_state == sld_fatal ? "fatal" : "bogus", ip);
 
@@ -1237,7 +1238,7 @@ bool handle_user_split_lock(struct pt_regs *regs, long error_code)
 {
 	if ((regs->flags & X86_EFLAGS_AC) || sld_state == sld_fatal)
 		return false;
-	split_lock_warn(regs->ip);
+	split_lock_warn(regs->ip, false);
 	return true;
 }
 
-- 
2.34.1