Received-SPF: pass (google.com: domain of linux-kernel+bounces-78100-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 23 Feb 2024 11:07:52 +0100
From: Herve Codina <herve.codina@bootlin.com>
To: Yury Norov <yury.norov@gmail.com>, Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rasmus Villemoes
 <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn
 <andrew@lunn.ch>, Mark Brown <broonie@kernel.org>, Christophe Leroy
 <christophe.leroy@csgroup.eu>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 3/5] lib/bitmap: Introduce bitmap_scatter() and
 bitmap_gather() helpers
Message-ID: <20240223110752.2329d3f0@bootlin.com>
In-Reply-To: <ZdfBuFZ7tf4b+3n8@yury-ThinkPad>
References: <20240222142219.441767-1-herve.codina@bootlin.com>
	<20240222142219.441767-4-herve.codina@bootlin.com>
	<Zddqr3aN4rU-upai@smile.fi.intel.com>
	<20240222174959.7097c29b@bootlin.com>
	<ZdfBuFZ7tf4b+3n8@yury-ThinkPad>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Andy, Yury,

On Thu, 22 Feb 2024 13:50:48 -0800
Yury Norov <yury.norov@gmail.com> wrote:

> On Thu, Feb 22, 2024 at 05:49:59PM +0100, Herve Codina wrote:
> > Hi Andy, Yury,
> > 
> > On Thu, 22 Feb 2024 17:39:27 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > 
> > ...  
> > > > + * bitmap_scatter() for the bitmap scatter detailed operations).    
> > >   
> > > > + * Suppose scattered computed using bitmap_scatter(scattered, src, mask, n).
> > > > + * The operation bitmap_gather(result, scattered, mask, n) leads to a result
> > > > + * equal or equivalent to src.    
> > > 
> > > This paragraph...
> > >   
> > > > + * The result can be 'equivalent' because bitmap_scatter() and bitmap_gather()
> > > > + * are not bijective.    
> > > 
> > >   
> > > > + * The result and src values are equivalent in that sense that a call to
> > > > + * bitmap_scatter(res, src, mask, n) and a call to bitmap_scatter(res, result,
> > > > + * mask, n) will lead to the same res value.    
> > > 
> > > ...seems duplicating this one.
> > > 
> > > I would drop the latter one.  
> > 
> > I would like to give details about the 'equivalent' in this scatter/gather case.  
> 
> If you would like - please do! :)
>  
> > If Yury is ok, I can drop this last paragraph.  
> 
> The original bitmap_onto() description is 3 times longer, and barely
> that descriptive. I'm OK with your working and especially pictures.
> 

Right, I will keep my last paragraph in the next iteration.

Regards,
Hervé