Received-SPF: pass (google.com: domain of linux-kernel+bounces-78094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 23 Feb 2024 10:59:18 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Luis Chamberlain <mcgrof@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] ipc: remove linebreaks from arguments of
 __register_sysctl_table
Message-ID: <20240223095918.karsamdx3a2w3v7w@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="bsfhvc4vn6y5qzwj"
Content-Disposition: inline
In-Reply-To: <20240219-sysctl-check-v3-2-6940d5ff747b@weissschuh.net>
CMS-TYPE: 201P
References: <20240219-sysctl-check-v3-0-6940d5ff747b@weissschuh.net>
	<CGME20240219201941eucas1p292f4407f82ea9f76bd91fd0c50611010@eucas1p2.samsung.com>
	<20240219-sysctl-check-v3-2-6940d5ff747b@weissschuh.net>

--bsfhvc4vn6y5qzwj
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 19, 2024 at 09:19:23PM +0100, Thomas Wei=DFschuh wrote:
> Calls to __register_sysctl_table will be validated by
> scripts/check-sysctl-docs. As this script is line-based remove the
> linebreak which would confuse the script.
>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
>  ipc/ipc_sysctl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c
> index 8c62e443f78b..e4008288a3ba 100644
> --- a/ipc/ipc_sysctl.c
> +++ b/ipc/ipc_sysctl.c
> @@ -259,8 +259,7 @@ bool setup_ipc_sysctls(struct ipc_namespace *ns)
>  				tbl[i].data =3D NULL;
>  		}
> =20
> -		ns->ipc_sysctls =3D __register_sysctl_table(&ns->ipc_set,
> -							  "kernel", tbl,
> +		ns->ipc_sysctls =3D __register_sysctl_table(&ns->ipc_set, "kernel", tb=
l,
>  							  ARRAY_SIZE(ipc_sysctls));
>  	}
>  	if (!ns->ipc_sysctls) {
This is very interesting and points to a bigger issue with the
check-sysctl-docs: which is that the AWK record separator is "\n" and it
require that the lines being analyzed follow a strict pattern; even if
that meant having a loooong line (not the case in this patch).

The final solution would be to change the separator to something less
line based to something more C based like RS=3D";{}". This is not a
blocker to this patchset as it actually fixes a broken script. But is an
interesting observation for whomever wants to continue this work.

Thx Thomas.

Best

--=20

Joel Granados

--bsfhvc4vn6y5qzwj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmXYbHUACgkQupfNUreW
QU9BngwAilWHaCGV02c63TsG6KffhHuQxvdozwA1Rr5Uq6I1Y0RM7O4gj8nqDbjP
AqPechNONJekobgOreItUGnUBzVuwqMzKArhkiazI928Z++hdiZq9vzqJACnmOM9
H0nJ8kEXfvcbm1/vmKYPJZAmMNeVzAo9vby8I+zQCEg1Cmp8PrlWEVit3WKasLRF
GPbg35wAXa9NZkMwt/nMyrqQ81veLZYx0HY3qknsixO5sdJ2+8G9y4ZnIX0WQMXb
6gyekKElut7gPjOf9xOQWSR5ekHFMkqbvF62edVPxNpNnatEA4TTdx4XpyaCA4Ey
uYJtvAcyXR8l2l5lfQaai/badSAcq7oJKoqXwO7UBWo0c6KOd0u4nNLpVmOM5995
7qrn5QJEkm9illA0OfOkQlYTpChCu2cp9vbFyveSaOg1l/029gu3/3jJu3tJEvY3
CeUFNyB1EmDSTZyEWeaXeQ2JfUq+1VGQoLnvTlFSYY938wprdOHPtmxvd6+audgM
/oAp2JtU
=kfHz
-----END PGP SIGNATURE-----

--bsfhvc4vn6y5qzwj--