Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp868092rdb; Fri, 23 Feb 2024 02:35:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV2Gerp00R/Dnel5lX2MyL+U2ai36wqdfYEHCmvKP49OBiggboGiROS6CTjF5SHdsqZCZxGXTKo37zqqY66Bd50p86BYA3Bqb05VQnhcw== X-Google-Smtp-Source: AGHT+IFarbT6FgZiNxxE6uWsaR+nJtMR5D9CbWLcMCVqMgYGfNaWaXyN8EWOV7/Spr6k5EqQiJx9 X-Received: by 2002:a05:6830:6581:b0:6e4:8307:4c92 with SMTP id cn1-20020a056830658100b006e483074c92mr666923otb.22.1708684550638; Fri, 23 Feb 2024 02:35:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708684550; cv=pass; d=google.com; s=arc-20160816; b=AEM9f6zRwsqttqWMgXY95XhM7x0z/SmyoK5FlYZ64MwirCgV0Skx3wxgZYr5/3EBUH +zOY6oDQFmc1UgOoD8dJJC4RJTUZK+XhFFyxQMXXbJkqoTS7PahB16v5I/3LWLQbscxm NuWnESmYJ6HG49IM6sMIxGKwL+39vbftTpN1SMvUh/3fI4YJ/Gbqfl7CcR4OnNvQwb3Y B3iIox1eaClD9z30McM4lv7wF/mWDDmA2U78wH+hZ1nEme4jXGZuXwSoOrzlKE4hKB9o Qgu5j/HOKBgCuey8VYZuhMtHrqazfBnF3YFOCJR6NnyTkYbh/K88rNqLAhOb6o63eSm1 IoZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=m+Owkp1rvs3wqHimfEH8BwiCegvG2RGz55AKhwheUbg=; fh=nKMNbSPB95+5NYPMDsxqy69UQvXyahN2jKDuYB0zV8Q=; b=anU8V/3hZ2qt+rkuFluuJKnpSO1ZGBCX4RMzVs++R0h+Sapeq/mVhUyOIJEZQpDROH KiPJ9LAyMHzMn10kLI7RTmldGFNOYeMmJDOp7iYx0c/Ci5E6uvzfp1LDsdLb9Ffs/h2E MGSCu/7znERB5inEdKWmonCoraCGq8pFH+SJxsNam9FSu5j6V+gwO69CaDA84gpfAcPM 58ZX0GQYGeNPl/4s4FLH1JUDsRFjt1TOc4v4qpqhueOmgDhvS2TXjpjWOmnkmwJQuTSm D6vH1Z4Edi5fIjHIB/uTSe8HjY/gBOZZXeHcYG1tfxJxR5Y01n2vh1zCxJMOHgtjrmM3 sm3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=iwwqeyI9; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-77862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77862-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x3-20020a636303000000b005d8e379746fsi12027775pgb.469.2024.02.23.02.35.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 02:35:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=iwwqeyI9; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-77862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77862-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8DBBAB22182 for ; Fri, 23 Feb 2024 07:09:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6789B13FFC; Fri, 23 Feb 2024 07:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iwwqeyI9" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B1A64414; Fri, 23 Feb 2024 07:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708672185; cv=none; b=sBctHtSs6UFbM2dZtCa4NZcUfXrMoXlRpmO/Euwc1m/NyA+gXTBmEMjyRQ6j2YdNnHk+iqAtYir58fhj5aPFJvbiArwV9c0JZJB4DMwG8cKRLFHktMELTraqDAee6CGhPkoAS2aVs7OYwCOyb6Gy4SUOL3NSOYt7b6vcTeppWEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708672185; c=relaxed/simple; bh=Zz70VcC6ec8uW9MYAOTjf18dTlcTTAeDita2hNGYrmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RZBDAt3NpKM9xe0xlGSL2XVIv24W/JwcUAZCVCog82JR1vSPCe6gmgrDaNe1xEZ6ZA4gppJihCkHISLixtTtK3BW87cF0MlMsncu8zeCbmZjLrxzuqM5sBZsPVRPi+eDqufCTRC8ge8fvnxvBX8SNxQRUpxESBK9hCC0M8r3WAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=iwwqeyI9; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=m+Owkp1rvs3wqHimfEH8BwiCegvG2RGz55AKhwheUbg=; b=iwwqeyI9c3+8e3/yCE9TC/w5CH +apLO/tqnHj5OoEfskS2+ieWWgT6wYzNDVHvLRUwZCrkIRWwHo0xJ1V7anDQ2Z2tcXnO5OkeyDwlB OYvrcCpFFGqai+oPl73PV76BDln7Vcb8zlKN3VhzOYCOZ1ju0MawnKpEf/NFKZxR0Van91cOu2bbx 7yMT2BVLFcJE5nNV9q6xK60ppA8eZzGA5zDW2AkwKAregxIwBLSQT6mfq6dkikHwvD0kk8yGu3M0b evY+e5fafMmBj4yVCqPfcV9bHRRMBY26AF9b5bihcdFFw1bGbqxouM33wVdEeNI2goEITiCuBSog3 fApTjHIQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdPgi-00000008G7y-2lsb; Fri, 23 Feb 2024 07:09:40 +0000 Date: Thu, 22 Feb 2024 23:09:40 -0800 From: Christoph Hellwig To: Elliot Berman Cc: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , Fuad Tabba , Sean Christopherson , Andrew Morton , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v17 19/35] arch/mm: Export direct {un,}map functions Message-ID: References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Feb 22, 2024 at 03:16:42PM -0800, Elliot Berman wrote: > Firmware and hypervisor drivers can donate system heap memory to their > respective firmware/hypervisor entities. Those drivers should unmap the > pages from the kernel's logical map before doing so. > > Export can_set_direct_map, set_direct_map_invalid_noflush, and > set_direct_map_default_noflush. Err, not they should not. And not using such super low-level interfaces from modular code.