Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp868099rdb; Fri, 23 Feb 2024 02:35:52 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUj4yhMiLFJ9ms3JsQXSSC9k8XDuUwKUZQgLuTMfI2l8l2K7Cv7lEfEMmpZ6u3Y91Ock4Z2gUvFbx2Xd1A5A+9SYg+ew3dDJIeHdJDi3A== X-Google-Smtp-Source: AGHT+IGQcBeZXyeiSDRH4sEDJAB3TCgWBGr0tkTJ8L3LwtLnVkWlKMI3XLAJ07aOVh75Zw5BLjwF X-Received: by 2002:a05:6358:3a0e:b0:178:94bc:72ef with SMTP id g14-20020a0563583a0e00b0017894bc72efmr1580094rwe.25.1708684551852; Fri, 23 Feb 2024 02:35:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708684551; cv=pass; d=google.com; s=arc-20160816; b=Wp3bu8m+K17zLiEoKvJHAoXAjhnUEmr74zHNxf6E5TmpEfj+V40c7SQUS3aWlsECID FRV+nF/FZ7rYUz8k92RScgsmlQA5penDOPSneDjSL8CBJxV6B46gfTwJOARGTlriWgTN B0Q7Hu+8hN2yoDLnShuDDGuMj7lSGvb2zQC20idJKVGyZXX+C4YDNIRNR0iXtQnkZqPX wrxRpQ8+g6T5iZbAUUtWp7KZrfvzBTaA2AvyBRieIRJ7LKb46TFEI1NoP85AGn1YKIkZ ven+N8lqXq+3AfGBpwQYrmKnjbgJMmYWbp1aNRNPAaDIJtOPg1ULwcwg7ekeOYEz/WPl PDRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VWzQqsMgxCr2Fh1Q5PjmsYegKBAzKmgsP/unpi6SiX4=; fh=7TY+0reLRE3hxA2ObzBsyvicqGevqJ5tYgHr56gBjvM=; b=M03Q63g0Xx8BbMN8tOK2IEzXZC0RRy7HISBuMKT1mDIqr2iOtONtS0vSQjmd3Ltzzw 2jJ+Idsl2cwBFXIxugZRxebELBgOriGuoF7txCACiW4H3NKV/1GtHrqMxcTg96ZjVHpw jBn7KvzOGUFccwsoiXo446u4WzBdToaQBgfb5qDjuXmCNlSwzu7JfUHGcColizzryi1N yOah28qF73W01o9+2IMQim29q5UfnbdZWlOY9kvce7eXZXCT55D5pWsPY8GdCG0LDLs7 fC291KmIuCZXkGF8ITJai+fgY6e5cNPLkQA70hFuygo+qhkpn/uOPVj1BQQwIt7cMZYn +SCA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RWgHoCDs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78140-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id dw10-20020a056a00368a00b006e4e40f5e2dsi713076pfb.242.2024.02.23.02.35.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 02:35:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RWgHoCDs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78140-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 863E5285DC2 for ; Fri, 23 Feb 2024 10:35:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EDC46310A; Fri, 23 Feb 2024 10:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RWgHoCDs" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E3A5C91B; Fri, 23 Feb 2024 10:35:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708684544; cv=none; b=EfcXe/XUijZ9TqWCtfXE8OYyIQ/wPGtpX+X6cxqbCXobG2bklsPM5w48pAZbSuW/pf3knIhX8E7xNSXdJQqjplQjefiu3od30V11CAYoWes1ArQpRsW4yqhBB30ZzF0yanWQ/hq3kO/1Y3OW6d7g+BThSjIaCdQ5vJzHB5oHEYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708684544; c=relaxed/simple; bh=ruwnsn/gjGehFv1nBJWx1lSoMV/uko91BIOgAziMm3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rlce9eXP0g2dSXDvuwxckbzomZTKc4stdqjVLcvPgRdvQX9yz6Ia7DynPhorn4iKPm3dU385kAILYYhEmhym//8lQREplJ6EfQ3Sy4oUmAFct+NUxq8WYQpM0OZRDFseb/ZpbGKTONxaIQWKc/i+vmmliw5y2fIFw1WZCZw7DQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RWgHoCDs; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1C69C433F1; Fri, 23 Feb 2024 10:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708684543; bh=ruwnsn/gjGehFv1nBJWx1lSoMV/uko91BIOgAziMm3M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RWgHoCDsVInAwCNNN7dPCmlvFap+RO20ZKOlw5tytgf/6HhxKiXjXRWImhWH4zwH4 vzTPARKaSLya1nJMxTc3NfXVRQSgkd+uWgdiSeKp+i3IEsyAWavegkD2Nn0WFtefg0 KDoZGR/8YogeLYhEEJ98ZrF//2MX+GGKZ0y6LoazZzdZX2DXWHCoIXQD92qnARlSou Hom7au3sqBTdrrTwXo30O7GOKJkb5SuteMP8x+N1GTlKwaoKpDfxcRESRuBSUtF3Ph AuVlC3rc2dVnBYZp4TFtwnXgsSd1gY/lDdCp/yAg+zEVC/T1a+HfeRW8msjSLElkrz TrAjAOo9vBIYg== Date: Fri, 23 Feb 2024 10:35:37 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Aren Moynihan Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland Subject: Re: (subset) [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Message-ID: <20240223103537.GA1585387@google.com> References: <20240206185400.596979-1-aren@peacevolution.org> <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> On Fri, 23 Feb 2024, Lee Jones wrote: > On Tue, 06 Feb 2024 13:13:17 -0500, Aren Moynihan wrote: > > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we > > shouldn't need to set it here. This makes it possible to use multicolor > > groups with gpio leds that enable retain-state-suspended in the device > > tree. > > > > > > Applied, thanks! > > [1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend > commit: 68552911e71d59e62dd5e50e9ac56ebfc32f0c71 Note that I changed a bunch of grammatical issues. led => LED gpio => GPIO Capitalised the first word of the comment, etc. -- Lee Jones [李琼斯]