Received-SPF: pass (google.com: domain of linux-kernel+bounces-78173-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>, Anup Patel
	<apatel@ventanamicro.com>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley
	<paul.walmsley@sifive.com>, Thomas Gleixner <tglx@linutronix.de>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Frank Rowand <frowand.list@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>
CC: Marc Zyngier <maz@kernel.org>, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?=
	<bjorn@kernel.org>, Atish Patra <atishp@atishpatra.org>, Andrew Jones
	<ajones@ventanamicro.com>, Sunil V L <sunilvl@ventanamicro.com>, Saravana
 Kannan <saravanak@google.com>, Anup Patel <anup@brainfault.org>,
	"linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH v12 02/25] genirq/irqdomain: Remove the param count
 restriction from select()
Thread-Topic: [PATCH v12 02/25] genirq/irqdomain: Remove the param count
 restriction from select()
Thread-Index: AQHaZkJDw9NLoYRbNkuhzQYScggLGrEXvPCA
Date: Fri, 23 Feb 2024 10:45:07 +0000
Message-ID:
 <TYCPR01MB112692BF27640D12CEF5987BE86552@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <20240127161753.114685-1-apatel@ventanamicro.com>
	<20240127161753.114685-3-apatel@ventanamicro.com>
	<CGME20240223102258eucas1p119f38e40f769c883c0a502e9e26be888@eucas1p1.samsung.com>
 <481aa3b9-55c2-4ccb-bb4a-58b924d77ad7@samsung.com>
In-Reply-To: <481aa3b9-55c2-4ccb-bb4a-58b924d77ad7@samsung.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?rvWAK5+UAuBv/0F/fE4g2nsrEYoLXduI/WoldW5e+dJ4PQphHErlqOSOZR?=
 =?iso-8859-1?Q?A2bnSGTlqbtjQnspMaeutN2sQRnVTV/gsbU5EV6KYkBKAJhLbg45Xg1PtJ?=
 =?iso-8859-1?Q?9exZfzIlW+pMMP+x4yRVvOENN85O08L3O8qVEttSv/+ysfZMe4kj3/2ihV?=
 =?iso-8859-1?Q?XRI5TLTAxRz230yULym8D5dSg0OUp8zurpIF8SeXKG2c9nubS42Pr5o+36?=
 =?iso-8859-1?Q?IRWYJk6K4j9znZgc2dH0wiYkbH/fGgUNMggR9qqVPzELEfYvqYv6Qombch?=
 =?iso-8859-1?Q?L3qhkmGlLlO63kKW2ONYMiP3aLC7pQy7oLildWE1/AoOlfDshhkH9sQ+Cl?=
 =?iso-8859-1?Q?FoEluXTNv+bZ8RUg07nz3R8DUjH3iJZY58MduwSJpCc0f5KX+8VDtLsLt/?=
 =?iso-8859-1?Q?J/N0fAUwJY2ar2P41vueEmgqbTT6Ur8M6qdWmJs1wvTA8zlt50hCHb5RtO?=
 =?iso-8859-1?Q?OIFo+9XbrWqtsowC2vWP0uhAu0q0rckChg3mCB2lixPT5bsspX27Mn0Q9y?=
 =?iso-8859-1?Q?Rk0DeYXFsuxK9NkQ9jNmW37zeXYcayhH/4px4JuOMfThFNcHl9lDkALeiQ?=
 =?iso-8859-1?Q?RMFfB8y1Dmv/2RC1BHiYkC0puKqJLWFG162KIRg1CJnO1dhCv8NSVUHxsY?=
 =?iso-8859-1?Q?q5hzDxNVbbJ+vwFEJSANts3ZEPFP7tcx/vnwAMYaquQD7v2eKjuUbZXENT?=
 =?iso-8859-1?Q?z7uipgEdadhe0wVNWMuHGoagILQqxC46Gd9dc+1UtV1EqNn16+nLNlYBMZ?=
 =?iso-8859-1?Q?WZ2dPKKlP61bzimotbT7g0cJwW+EHVUrnVw4vjaxCHxZjAWzOsNiL/Tmu6?=
 =?iso-8859-1?Q?KXkyzIOdRfozTpEQL2zNS68Wlx7tCT5/y0Fsr7nV8uWnGdIphGkUeIqErI?=
 =?iso-8859-1?Q?odrZ3LAVAu2tMgZPSJneJd5YsQxreW8s84vCaiwoujwXXx9M4OpY8mNP/g?=
 =?iso-8859-1?Q?aBAk9zr4FlL5DjztsYpUjEHm9aTtOErgbuM/XDZ6sMQ8oBsBMkhbWz23uR?=
 =?iso-8859-1?Q?u+IeAClx/lcPYa4gSsdNCUMoeUeVc4jnPXLhYgEvYHukJDW5BSM0bOGTOA?=
 =?iso-8859-1?Q?dnupwWBN3/X/ApGu9OgTqIujTD4zT4Obe/gmCvQyqtndiM47MFLLxsSnb4?=
 =?iso-8859-1?Q?7o7y+ZvMBwYDP2q7p74I6/E60r5jG4LLEN/X2JCuGV8fr0n9utG0k68m2u?=
 =?iso-8859-1?Q?p7y5FtyeZA0LTW4IvVeQ+5qnLfyL5EM415xilHcZPWrjZDKFsnYlcjiQxA?=
 =?iso-8859-1?Q?kFZUnv8PC1IhkpNk4BFmZ2K4yaH/yBUure540Vx3cwncAl7PsqVmyRS+tu?=
 =?iso-8859-1?Q?evDLduyaQPzU9KBdK/iKO3KrKtD5N2CCWPYSp6T4aAXgBXS6IjcOT0DHyk?=
 =?iso-8859-1?Q?2ARqiyrMpjnPH+wIkE6AMpplEBY7XTj9HCtHAr+E/HAi/SJkaqz4KQ/XRq?=
 =?iso-8859-1?Q?FMtzVVOD0ALz9Tp0x2P4JfDeepYAo8K+JFAmBXPIZbv949XCGQx+V8kLAs?=
 =?iso-8859-1?Q?t40VRn+M1leSyoOlkH3ZgVpwwjLAtgUPo7tsRjrhMfYYnCaacBTSEknsay?=
 =?iso-8859-1?Q?eDVhp4txYJcgWjH+D/ORyjs6zth/+DCTymjlkUry6yTELtsqsDwF3Mtgbq?=
 =?iso-8859-1?Q?tPkA2EZQAUeq+lmzQaUQdq5TPQQAz+rtx6OGO8nfEgALKo0V2I0l2sXQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75d7dc56-a861-4f9d-7074-08dc345c8078
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 10:45:07.6633
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AOPycWWvCT/9kzzX6Bhg93HNO8vt/d2aVVBI0LYuGBfcsBCXu4clt+r7WgOwwJ117RoGFYltIdsSp5kEPWC3g0HDRR72fkM90PKEeTlDB+s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB9632

Hi Marek Szyprowski,

> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> Behalf Of Marek Szyprowski
> Sent: Friday, February 23, 2024 10:23 AM
> Subject: Re: [PATCH v12 02/25] genirq/irqdomain: Remove the param count
> restriction from select()
>=20
> Dear All,
>=20
> On 27.01.2024 17:17, Anup Patel wrote:
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > Now that the GIC-v3 callback can handle invocation with a fwspec
> > parameter count of 0 lift the restriction in the core code and invoke
> > select() unconditionally when the domain provides it.
> >
> > Preparatory change for per device MSI domains.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Anup Patel <apatel@ventanamicro.com>
>=20
>=20
> This patch landed recently in linux-next (next-20240221) as commit
> de1ff306dcf4 ("genirq/irqdomain: Remove the param count restriction from
> select()"). I've noticed that it breaks booting of Qualcomm's Robotics
> RB5 ARM64 board (arch/arm64/boot/dts/qcom/qrb5165-rb5.dts). Booting
> freezes after "clk: Disabling unused clocks", but this is probably a
> consequence of some earlier failure. Reverting $subject on top of
> next-20240221 fixes this problem. Let me know how can I help debugging
> this issue.
>=20
>=20
> > ---
> >   kernel/irq/irqdomain.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index
> > 0bdef4fe925b..8fee37918195 100644
> > --- a/kernel/irq/irqdomain.c
> > +++ b/kernel/irq/irqdomain.c
> > @@ -448,7 +448,7 @@ struct irq_domain *irq_find_matching_fwspec(struct
> irq_fwspec *fwspec,
> >   	 */
> >   	mutex_lock(&irq_domain_mutex);
> >   	list_for_each_entry(h, &irq_domain_list, link) {
> > -		if (h->ops->select && fwspec->param_count)
> > +		if (h->ops->select)
> >   			rc =3D h->ops->select(h, fwspec, bus_token);
> >   		else if (h->ops->match)
> >   			rc =3D h->ops->match(h, to_of_node(fwnode), bus_token);

This patch looks reverted on todays's next. But there was a fix for fixing =
the issue you mentioned [1]

[1] https://lore.kernel.org/all/170844679345.398.17551290253758129895.tip-b=
ot2@tip-bot2/

Cheers,
Biju