Received-SPF: pass (google.com: domain of linux-kernel+bounces-78191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>, Anup Patel
	<apatel@ventanamicro.com>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley
	<paul.walmsley@sifive.com>, Thomas Gleixner <tglx@linutronix.de>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Frank Rowand <frowand.list@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>
CC: Marc Zyngier <maz@kernel.org>, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?=
	<bjorn@kernel.org>, Atish Patra <atishp@atishpatra.org>, Andrew Jones
	<ajones@ventanamicro.com>, Sunil V L <sunilvl@ventanamicro.com>, Saravana
 Kannan <saravanak@google.com>, Anup Patel <anup@brainfault.org>,
	"linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH v12 02/25] genirq/irqdomain: Remove the param count
 restriction from select()
Thread-Topic: [PATCH v12 02/25] genirq/irqdomain: Remove the param count
 restriction from select()
Thread-Index: AQHaZkJDw9NLoYRbNkuhzQYScggLGrEXvPCAgAAEdwCAAABXsA==
Date: Fri, 23 Feb 2024 11:01:18 +0000
Message-ID:
 <TYCPR01MB11269D56CFF46F731F932245886552@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <20240127161753.114685-1-apatel@ventanamicro.com>
	<20240127161753.114685-3-apatel@ventanamicro.com>
	<CGME20240223102258eucas1p119f38e40f769c883c0a502e9e26be888@eucas1p1.samsung.com>
	<481aa3b9-55c2-4ccb-bb4a-58b924d77ad7@samsung.com>
	<TYCPR01MB112692BF27640D12CEF5987BE86552@TYCPR01MB11269.jpnprd01.prod.outlook.com>
 <870534fc-eaa6-4da6-9180-a051443fbaa6@samsung.com>
In-Reply-To: <870534fc-eaa6-4da6-9180-a051443fbaa6@samsung.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?Ry55aUs23CCfCLFHXwGIJyv3daKvuf5/apKqzRCldti9oI5EuoIUFbYzxU?=
 =?iso-8859-1?Q?aRQyb8cS893c3K65FfIx46Fgrs0NmyWjkZ3aYEsNwvetCt45aJ4zRtuKNM?=
 =?iso-8859-1?Q?xpn/5lmlfq0AvHnmSRiuuTqDjmFykM3Vxe7JM451Pxi6UheMYG2lAWJ6iX?=
 =?iso-8859-1?Q?vhOqJRyjdFmkBpaUym3jhqiLcoyN5MVwmBfmE8LGVaEuueMy8563stnKyO?=
 =?iso-8859-1?Q?nMZm/b87PVd8ugcRoTibo6quErNzBCVBxNIySM+Ec6vnN0i+6ZgAGDXH89?=
 =?iso-8859-1?Q?whIfiIUWwNth0OLV0bnx5Cqb5vu85X6xfr9paMIl15gxjO1Cm0YniI5xoV?=
 =?iso-8859-1?Q?FXwadRmjXBnEkZIoeef+2VcOBs0ebPaYGDfqL44XcEgoW6JTWNDdjBamUO?=
 =?iso-8859-1?Q?DUPiiWjhA+w9Ln+uVYlJSZpwtN8ckZDUEDNe9MNiO5Qn1YHMLPmj1o0RHR?=
 =?iso-8859-1?Q?20mRxJI06tjT+sr/13Uv2vLo/BWcOC+6SEuRA+zQLAq6lvuGo2Ad/R0S5e?=
 =?iso-8859-1?Q?1pxWFYTK5A7+d/rj4n2FOnfTiZXS19U+o5Uu9uWgIbNpiwZlVgjBWizT6T?=
 =?iso-8859-1?Q?O0FSBoSQ2vO4clyHxMxDVRe/8BH69Ig4ixz4HU5vr4myoGGop+rFrhojJL?=
 =?iso-8859-1?Q?GlttCf1VS5Cq+szp9pgOi9CE0XxeHOhTcS401FA3vCLr4sm5rmZmh7Rnck?=
 =?iso-8859-1?Q?yFSmVu3Yi87K4Sq5733tFrROLHP+wMNmH4SoVxl+NDNzFkDv+9R9woPthq?=
 =?iso-8859-1?Q?VMvW5dWzNFpXGSVmabcr/x8nym6YRXRxmVOanA4zUt/KZPQyGq4MftbZ+n?=
 =?iso-8859-1?Q?8DRKmkKaezMYhXQKTCQmley5+yyBj6zNsNTfKtomtiXUPa3WbQAgpQReFp?=
 =?iso-8859-1?Q?ebPjkRTjBjabRd86Lm2z1DnaW3iSDfrgfyZmd97rwSyq73+ct3vc7PWdOB?=
 =?iso-8859-1?Q?U4n3Rc/oV4DVFEg07gYzrdcwo4qFmIFgjQHzqPr64wt2+0g0Ly2TXF02uz?=
 =?iso-8859-1?Q?5bL1ak98TWjwmQUXZhS8e5SACuDbi9PJkqCu3XEtpuI32yJRt7KGmSgjIu?=
 =?iso-8859-1?Q?f6OudMaAM9Hh0rdvV4ly7/C0Q2SLe3kijFf3Sn7Ymi8vOlfC2GTSLCjeEG?=
 =?iso-8859-1?Q?Jn0wh1Qs1JEztokXeCq2hD5c9F0C9Dvxaeow9GGhZjQBHPcz386MF2OM7n?=
 =?iso-8859-1?Q?oj2jzpWM3yB4UQrfNoMbNXtsKL1VZ7IR4ZrKXauiHoXltocc0jXpB3MFo3?=
 =?iso-8859-1?Q?T5gdnjwKvd9WVDx6xgI4cvt2whUy7A+YMjkBKFMD3cmoTz7AdD3R/2xijN?=
 =?iso-8859-1?Q?yoVRJHRtWU8BoG+L4hZ4t8XZ2q27jjNKXHfxkl8eQNvXkAIguRJLAnlfkK?=
 =?iso-8859-1?Q?mlA6GaWJna46qDnPBeS/ktRPND2xZRtjRQuTcupTL5Mrgn/4sYHmzR5pVr?=
 =?iso-8859-1?Q?wzwE7VzGcgY1zcZ7m34kDrMTz7qO7IiC1xdWeNMkoKWVeAjYkHSjRrUPXf?=
 =?iso-8859-1?Q?8pzZBKkHykuzL6euPtm3w9nPbYv46vkAwV1uRkH5DC8zpNHNnKBYFY0Uuz?=
 =?iso-8859-1?Q?mXrvmfYCFKIyD2B/hpU7Na4OgBfrNfwXKwlv+sCrAf1/1h7JCpkChDGtv6?=
 =?iso-8859-1?Q?Ok8x14F4jrx0G6wmsxwGQqeZ5dgewuqGv03Z3coKLKyNsapMPID3Tplw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed49418-a8d1-4a61-8974-08dc345ec327
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 11:01:18.4890
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8yQMKd+Nc9rLcGm3SUYZzNLSDT2qqE3gjN8RhWJEtMCMGKQBkT5yiVH/vL5byqtufPz/a37GOkxJLWmdc9AoGwqNWhxLIv86dUE75OSB4uE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8283

Hi Marek Szyprowski,

> -----Original Message-----
> From: Marek Szyprowski <m.szyprowski@samsung.com>
> Sent: Friday, February 23, 2024 10:57 AM
> Subject: Re: [PATCH v12 02/25] genirq/irqdomain: Remove the param count
> restriction from select()
>=20
> On 23.02.2024 11:45, Biju Das wrote:
> >> On 27.01.2024 17:17, Anup Patel wrote:
> >>> From: Thomas Gleixner <tglx@linutronix.de>
> >>>
> >>> Now that the GIC-v3 callback can handle invocation with a fwspec
> >>> parameter count of 0 lift the restriction in the core code and
> >>> invoke
> >>> select() unconditionally when the domain provides it.
> >>>
> >>> Preparatory change for per device MSI domains.
> >>>
> >>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >>> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> >>
> >> This patch landed recently in linux-next (next-20240221) as commit
> >> de1ff306dcf4 ("genirq/irqdomain: Remove the param count restriction
> >> from select()"). I've noticed that it breaks booting of Qualcomm's
> >> Robotics
> >> RB5 ARM64 board (arch/arm64/boot/dts/qcom/qrb5165-rb5.dts). Booting
> >> freezes after "clk: Disabling unused clocks", but this is probably a
> >> consequence of some earlier failure. Reverting $subject on top of
> >> next-20240221 fixes this problem. Let me know how can I help
> >> debugging this issue.
> >>
> >>
> >>> ---
> >>>    kernel/irq/irqdomain.c | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index
> >>> 0bdef4fe925b..8fee37918195 100644
> >>> --- a/kernel/irq/irqdomain.c
> >>> +++ b/kernel/irq/irqdomain.c
> >>> @@ -448,7 +448,7 @@ struct irq_domain
> >>> *irq_find_matching_fwspec(struct
> >> irq_fwspec *fwspec,
> >>>    	 */
> >>>    	mutex_lock(&irq_domain_mutex);
> >>>    	list_for_each_entry(h, &irq_domain_list, link) {
> >>> -		if (h->ops->select && fwspec->param_count)
> >>> +		if (h->ops->select)
> >>>    			rc =3D h->ops->select(h, fwspec, bus_token);
> >>>    		else if (h->ops->match)
> >>>    			rc =3D h->ops->match(h, to_of_node(fwnode),
> bus_token);
> > This patch looks reverted on todays's next. But there was a fix for
> > fixing the issue you mentioned [1]
> >
> > [1]
> > https://jpn01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flor=
e
> > .kernel.org%2Fall%2F170844679345.398.17551290253758129895.tip-bot2%40t
> > ip-bot2%2F&data=3D05%7C02%7Cbiju.das.jz%40bp.renesas.com%7Cffce754120ba=
4
> > ff0f8d708dc345e1c1a%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C63844
> > 2825998732581%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> > MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=3DlYLVpa4tz2fEU1J=
c
> > DDGUF6eigi2YJuGDouMXrJSlibo%3D&reserved=3D0
>=20
> Thanks! Today's next seems to be broken on ARM64 (doesn't compile here),
> so I've missed it.

FYI, ARM64 defconfig works for me.
Linux smarc-rzg2l 6.8.0-rc5-next-20240223-gfebe82167ab7 #1430 SMP PREEMPT F=
ri Feb 23 07:41:52 GMT 2024 aarch64 GNU/Linux

Cheers,
Biju