Received: by 2002:ac8:4b50:0:b0:42d:ce8e:db0a with SMTP id e16csp745684qts; Fri, 23 Feb 2024 03:28:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7ndKYnc/czB6Fw9YVO+mWtKxocjb1Uln283swhGS3LoXdLnBqbUfIgVz0dqWnvHLoUe8apHcuLlZUEvUZtTrZXOgBoVOutGcxWzXWQw== X-Google-Smtp-Source: AGHT+IGHrzsqMFye0g0G6DZyx7OPW9UESuGeNE3vOHV81fww5reJmYKNEB77RCJSK1Uc0Z5JGexq X-Received: by 2002:aa7:c388:0:b0:565:7116:d533 with SMTP id k8-20020aa7c388000000b005657116d533mr859709edq.6.1708687276213; Fri, 23 Feb 2024 03:21:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708687276; cv=pass; d=google.com; s=arc-20160816; b=jj+wgFTWjyYDT48SBwXOInSoNWcK/LaqPTn+d8nVuDcVPaGAUGeuXOnXcdSqmw3ROs RV5CtASMeR5TVq3yLyZaIyN7vauTgWuk1a8WkvQxQ9ktFtCyEoJ9i5cxW6dUidgK18nc c8bMSLTa1F9mVpuT1zWEFoUtq0c2Wpc9kbTObrYzvsWednz/2W9y9nVawOsTc76Q3zJq SSvnx2mnXctJpxFyVNR+gYcl4aZiFw+9kZJ6tNsA8OgHqKiMgV016VZIRxM2IJLPEMJP wN41lSDYjQOMopu3GOXttDR7kZIqGRRxB265huJHvmNA88+Xg3Xgad2gdu88hE30EAb5 LJAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aBfCnAi5hvcmmpCtPlk0e5eJzK8TjskYJrMzZCN+lec=; fh=IpCfGkz7Bjkhn9h8U4CW7xJ9GYkJ7243hNS7QO8PlAs=; b=BpxnsvhaH4iTpuTT1UaM8ro6fpuh6g/ApjkKLzGl/8XKOsHZcsl7LYFnK6prgEJNcP HajJXG7GT+8NuqdJ3FDktmhV0829rtStrieafdZabKExikVrDJAy9xQJejcI/7WHV1eH 14gpdb2Z+H50fIAp+THk8xprUQUxWXLmPhzIwnBJ1NhCuBdRZm3emiEx17oQQX5ENUVr q+vno8MAqSnkKlGsloIIS4c08SGdCY+cSFdZiL4uoclysLpuZG+SVGeZeADtiRsf7luK LQz99zSG8LxZ9X62Om5mWLfo5noNu15M9CWhvf9lg0PkIX1TPi3/j0COHpFdGRLFz34+ KLHQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=02XPD7lT; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-78205-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q1-20020a056402032100b005653a367ab6si1313148edw.271.2024.02.23.03.21.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 03:21:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78205-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=02XPD7lT; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-78205-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A669E1F236CD for ; Fri, 23 Feb 2024 11:21:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6F50E651BD; Fri, 23 Feb 2024 11:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="02XPD7lT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED691758D for ; Fri, 23 Feb 2024 11:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708687268; cv=none; b=CNA/if11Fn1RV3yy0YPs/d0LGTDMRzMiVG4SPdjtwwRc0JSl+/LY0WPVpo9QPykCzIzNaSiJI/eetxvmxegbdGRLHLn7KZGmD34h7kqaSViUikcI+/oXNonxNCJQGaL77FrHP1gIdJGOGKitChLhwvhAqNRNQIkBXJpOzyF7whY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708687268; c=relaxed/simple; bh=SCw7DbOtRwkI5zg0APjb7jb8/0IT16RWzCP/jwP9gMY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XZUIu3a2tGPui8js6whmfsUF7ck3S8lnDVmWUPcAsskL7tuQIfQUAg57CN7ofyf8KtAH1lS+at7kVXdCbIClj48bofmbBbjwXXbetJVoILjl2WTRQ0bn1IfcDcL/fobiv0c8L8HzK5iRbFXusjEl2uiTAnnC4ktbpbfMiwfb8t0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=02XPD7lT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35D2DC433F1; Fri, 23 Feb 2024 11:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708687267; bh=SCw7DbOtRwkI5zg0APjb7jb8/0IT16RWzCP/jwP9gMY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=02XPD7lTz0v4zkUv1rUuRaHJIFKVkZXZp54disUn6r794KZZ9iXiPMxSEeiwBy4wW F2bKuE6gdKeDcF8Q32DTtXAKB1p7rdS08PUWa1fdMahYwMfctSxU+s3Sj1e5PQmZIM 572i37G1CEUfP1g6eN3Vq1BI4KFkcJAwDeE2VUAk= Date: Fri, 23 Feb 2024 12:21:04 +0100 From: Greg KH To: Nipun Gupta Cc: maz@kernel.org, tglx@linutronix.de, jgg@ziepe.ca, linux-kernel@vger.kernel.org, git@amd.com, harpreet.anand@amd.com, pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, abhijit.gangurde@amd.com, srivatsa@csail.mit.edu Subject: Re: [PATCH v8 2/2] add wrapper msi allocation API and export msi functions Message-ID: <2024022340-reversion-detonator-f229@gregkh> References: <20240223092447.65564-1-nipun.gupta@amd.com> <20240223092447.65564-2-nipun.gupta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223092447.65564-2-nipun.gupta@amd.com> On Fri, Feb 23, 2024 at 02:54:47PM +0530, Nipun Gupta wrote: > MSI functions can be for allocation and free can be directly > used by the device drivers without any wrapper provided by > bus drivers. So export these MSI functions. > > Also, add a wrapper API to allocate MSIs providing only the > number of IRQ's rather than range for simpler driver usage. Why is this patch 2/2? Don't add wrappers that no one uses, otherwise we will just delete them again :( thanks, greg k-h