Received-SPF: pass (google.com: domain of linux-kernel+bounces-78227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.160 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C
Date: Fri, 23 Feb 2024 03:34:56 -0800
From: Nicolin Chen <nicolinc@nvidia.com>
To: Will Deacon <will@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <kernel-team@android.com>,
	<iommu@lists.linux.dev>, Christoph Hellwig <hch@lst.de>, Marek Szyprowski
	<m.szyprowski@samsung.com>, Robin Murphy <robin.murphy@arm.com>, Petr Tesarik
	<petr.tesarik1@huawei-partners.com>, Dexuan Cui <decui@microsoft.com>,
	Michael Kelley <mhklinux@outlook.com>
Subject: Re: [PATCH v4 0/5] Fix double allocation in swiotlb_alloc()
Message-ID: <ZdiC4OpEMQHQjEtv@Asurada-Nvidia>
References: <20240221113504.7161-1-will@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240221113504.7161-1-will@kernel.org>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 11:35:15.5065
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: be7135ec-a052-461e-6a72-08dc3463816a
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1PEPF0002636A.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5634

On Wed, Feb 21, 2024 at 11:34:59AM +0000, Will Deacon wrote:
> Hi again, folks,
> 
> This is version four of the patches which I previously posted at:
> 
> v1: https://lore.kernel.org/r/20240126151956.10014-1-will@kernel.org
> v2: https://lore.kernel.org/r/20240131122543.14791-1-will@kernel.org
> v3: https://lore.kernel.org/r/20240205190127.20685-1-will@kernel.org
> 
> Thanks to Petr for his Reviewed-by tag on the first three.
> 
> Changes since v3 include:
> 
>   - Use umax() instead of max() to fix a build warning if the first
>     patch is applied to older kernels which warn on signedness
>     mismatches.
> 
>   - Add two new patches to the end of the series to resolve some
>     additional issues with NVME and 64KiB pages, reported by Nicolin.
>     I've added them to this series, as the first three patches make it
>     easier to fix this problem in the SWIOTLB code.
> 
>   - Add Reviewed-by tags from Petr
> 
> Cheers,
> 
> Will
> 
> Cc: iommu@lists.linux.dev
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Petr Tesarik <petr.tesarik1@huawei-partners.com>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: Nicolin Chen <nicolinc@nvidia.com>

This fixes the bug with NVME on arm64/SMMU when PAGE_SIZE=64KiB.

Tested-by: Nicolin Chen <nicolinc@nvidia.com>

Thanks!