Received-SPF: pass (google.com: domain of linux-kernel+bounces-78243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 23 Feb 2024 11:39:10 +0000
From: Conor Dooley <conor@kernel.org>
To: Yangyu Chen <cyy@cyyself.name>
Cc: linux-riscv@lists.infradead.org,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	Alexandre Ghiti <alex@ghiti.fr>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] riscv: dts: Allow BUILTIN_DTB for all socs
Message-ID: <20240223-amino-barbell-59214fa9aa95@spud>
References: <tencent_AB625442CC1BCFF86E04D7B5891C43719109@qq.com>
 <20240221-islamic-quartered-3863e44bc862@spud>
 <tencent_DF3D7C2E8248DA188E3FB8DF31FE21478D08@qq.com>
 <20240222-crawlers-prankish-ecf425d1f0b5@spud>
 <tencent_AF1B1DF96C041FB57D1C4770356254431E09@qq.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YWxBLTxQFvyXO2f2"
Content-Disposition: inline
In-Reply-To: <tencent_AF1B1DF96C041FB57D1C4770356254431E09@qq.com>


--YWxBLTxQFvyXO2f2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2024 at 03:42:01PM +0800, Yangyu Chen wrote:
> To sum up, I agree with the reasons to refuse it for debugging purposes. I
> am wondering what to do next. After reviewing the code carefully, I found
> this feature not only for K210 but also for other SoCs. But for other SoC=
s,
> it is broken as it will link multiple dtbs to the kernel, but the kernel
> will always pick up the first dtb to use as discussed on this thread [2].
> That is because SOC_BUILTIN_DTB_DECLARE is removed from this patch [3] th=
en
> no code to select for multiple dtbs now. And makefiles on other soc which=
 is
> on the mainline kernel currently will build every dtb object file from th=
is
> patch [4]. So this feature for other SoCs is broken now.
>=20
> Choices might be one of the following:
>=20
> 1. Remove BUILTIN_DTB feature if K210 support get removed
> 2. Continue to add this feature to get this work for other socs
>=20
> I prefer to continue to get this feature to work. Not only for my debuggi=
ng
> purposes but also for fixes.

My email might have been a bit unclear because I responded to things out
of order. My final thoughts were that we should apply a v2 (or 3 etc) of
this patch if for no other reason than fixing BUILTIN_DTB. I could not
really justify refusing your changes when a patch fixing BUILTIN_DTB for
the non-k210 platforms that support it would look almost identical to
this patch. Apologies if you misunderstood.

I left some comments on the patch itself with a v2 in mind.

Thanks,
Conor.

--YWxBLTxQFvyXO2f2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdiD3gAKCRB4tDGHoIJi
0ix7AP4yMMgNUyiA1o4UrMBOtHcThn4TBnzGlxw++LdHRXz5dQD/X0dO6ukK7Mq+
8u/+x6VnQEcRzl+/0IyWAT/pD/FS8ws=
=7EAC
-----END PGP SIGNATURE-----

--YWxBLTxQFvyXO2f2--