Received-SPF: pass (google.com: domain of linux-kernel+bounces-78249-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 23 Feb 2024 17:19:03 +0530
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Gabor Juhos <j4g8y7@gmail.com>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        "Kishon Vijay
 Abraham I" <kishon@kernel.org>,
        Sricharan Ramabadhran
	<quic_srichara@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: qcom: m31: match requested regulator name with dt
 schema
Message-ID: <ZdiGL/TryPVrbDWp@hu-varada-blr.qualcomm.com>
References: <20240220-phy-qcom-m31-regulator-fix-v1-1-7675b4a916b3@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240220-phy-qcom-m31-regulator-fix-v1-1-7675b4a916b3@gmail.com>

On Tue, Feb 20, 2024 at 08:13:47PM +0100, Gabor Juhos wrote:
> According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
> supply regulator must be defined via the 'vdd-supply' property.
> The driver however requests for the 'vdda-phy' regulator which
> results in the following message when the driver is probed on
> a IPQ5018 based board with a device tree matching to the schema:
>
>   qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator
>   qcom-m31usb-phy 5b000.phy: Registered M31 USB phy
>
> This means that the regulator specified in the device tree never
> gets enabled.
>
> Change the driver to use the 'vdd' name for the regulator as per
> defined in the schema in order to ensure that the corresponding
> regulator gets enabled.
>
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
> index c2590579190a..9d84858ba1db 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
> @@ -297,7 +297,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, PTR_ERR(qphy->phy),
>  				     "failed to create phy\n");
>
> -	qphy->vreg = devm_regulator_get(dev, "vdda-phy");
> +	qphy->vreg = devm_regulator_get(dev, "vdd");
>  	if (IS_ERR(qphy->vreg))
>  		return dev_err_probe(dev, PTR_ERR(qphy->phy),
>  				     "failed to get vreg\n");
>
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240220-phy-qcom-m31-regulator-fix-97555a4650b1

Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com>