Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp825067rbd; Fri, 23 Feb 2024 04:58:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW5685t5vntJ6lw0Gc/4ugGTPXiOViJwsCJj5vZwHfkIi7JzNH3EUbgLg5wRm3nj2uErDO3ddrqLWslHKexvzVpSHAewYjxPtIf5OReyw== X-Google-Smtp-Source: AGHT+IGCwfoaPETN+A73h8LclQE5JvdKZvPoBIcl97x3HQIaEBOC+Nr7FNdFZeQxhGp1couOgVYq X-Received: by 2002:a05:6a20:c916:b0:19e:ccb2:fd80 with SMTP id gx22-20020a056a20c91600b0019eccb2fd80mr1990573pzb.8.1708693097853; Fri, 23 Feb 2024 04:58:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708693097; cv=pass; d=google.com; s=arc-20160816; b=xLq3BI9zCg64nKTVkkG8YAeZgttw8FBRE4iXyx18IFFZQOJEIvFdS4OwSlKrRhiMRe IITg5UM4r7mX3uRm3U0C2SPNyPFXTg00qgdNfGeb1x4Hmb4CibVpYa7aFFmpgHocpf5x ESiMM/toipS1+v/vxxpQOc42LkP/wQmIGVpvCqUwvtH96JuCkhj2H/8V7/ObaAibtFVK tNU16rIJYtmLkzzfF5OV0mGptLcKgNvcp8w2GMyeitdL2CXf0N4KsLxOfyaLKOQQTwyA 5C9CPIlEumStigx7027cKvil+kaIdEuyiQPGIMX1y8cR9Cx71V0pDd1jfHukbuvL83YE eFkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eaDHqvGjFWc5NQ/Jni0Pv6a5/AupV7TlC3suM8Kh5rk=; fh=Rk7mvJFIHSlbLycPMR/Jom5l5xPwCND1IlLsBli7mZ0=; b=fQI1Xqs1oJcRAdfKxJVVjc4SoXmmxfR2bUE6a9nH45LEhy8/W7SE9/aW64oBbZOmSB cDkprSeNJ3u6eu1cv+M+qJaOsfs3xuGJLyzJww4ik38SylNs8LMTMhyfrFY/aAGIIXUb 6wb4EgpxYD9xSHzWExcDxEW7QSRbhywxy1tC3MHUIAr06qxedx333vWMkmJm3nPcBnI7 4uk8xTluwAEnUUYg6QJT+FbEDkbfDedwF+MZPqUxx/SnaU0ykeL27950fqYWtEtzQS0I fSEHBtHw90apNcvd0aLkv39u0ZH26uc56tgUvfzpJjQnDxvKfcFY3CbvAwwWR00Zj923 YXdA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=evV+Boqp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78328-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78328-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id z1-20020a17090a6d0100b00296a76aa707si1106988pjj.185.2024.02.23.04.58.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 04:58:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78328-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=evV+Boqp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78328-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78328-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 829D2B214A8 for ; Fri, 23 Feb 2024 12:51:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5288B7CF2E; Fri, 23 Feb 2024 12:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="evV+Boqp" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B717AE45; Fri, 23 Feb 2024 12:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708692696; cv=none; b=dMWC/8lZH5+gZsqMsKDLwuuNx38TDSuEMlkLb0iXSzhtgaVrPo84NFiyTXys4RMATGIanigySfqVRjFveZwh/fHbIefbADqTHbLJllItb2DH52YsmzHZJ3illaEPIAcduQvqY6K2UR9voeMtYHQaptRndtGwZLLVNAT2UVKFKGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708692696; c=relaxed/simple; bh=1lJXy4uKYL7pJq5F8Vo9jDbbuH8lfKzhYgyljzDs/n0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BFlNLaCyB3COIPLPuLGAXJ0hs65J29khpahW2Z5UIigLtgKJUVKgceZURquxlexVGGL18mg1PK1kwkMz25+IvUKjObEDzNS4kkwAxDix+8rItBpRtwQP7kfnuLM15dSnU2uwCdAkb0ioWkMuHDvL8XZF/fMz0rDyUC3iHPrTgjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=evV+Boqp; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDC6DC433F1; Fri, 23 Feb 2024 12:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708692696; bh=1lJXy4uKYL7pJq5F8Vo9jDbbuH8lfKzhYgyljzDs/n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=evV+Boqp9I4YqNzKSjDSoquLBTJkguhMnylBUp+eSde9n7BkMk3q9Lg60i9e8XMX6 KnVD7vHyg/cySaCtEXVuP/bnIKdedXSHu565Z9tnXNSUs8YPe1xFIzRKuV5Lg0ZXQV l5kazV2J2jYV5p1S+u6WGNhBVb5rBFr+fQm9xY0lkYDytbFklcGTP7cg/mrT3n3tmj s3PjVAYReKFME7zw5SaGqKfCDkAiLyIE41BxO+3TiTxQhRYcsaiqUTsS88rk0XN1+O AHCRTL2asQ7U5XUr+EIzkSF1syZ/XvtniJ/7iKjkLOcduxCRcGwgDdWDqckgm/Fjq3 7vD74+f1h5vkw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdV1f-000000002l8-1Rm4; Fri, 23 Feb 2024 13:51:40 +0100 Date: Fri, 23 Feb 2024 13:51:39 +0100 From: Johan Hovold To: Neil Armstrong Cc: Bjorn Andersson , Andrzej Hajda , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Vinod Koul , Johan Hovold , Jonas Karlman , Laurent Pinchart , Jernej Skrabec , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Kuogee Hsieh , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Message-ID: References: <20240217150228.5788-1-johan+linaro@kernel.org> <170868613914.4029284.5549880672870201262.b4-ty@linaro.org> <3c4246b6-431a-442e-8ace-3b0d0e67743f@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c4246b6-431a-442e-8ace-3b0d0e67743f@linaro.org> On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: > On 23/02/2024 12:02, Neil Armstrong wrote: > > Hi, > > > > On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: > >> Starting with 6.8-rc1 the internal display sometimes fails to come up on > >> machines like the Lenovo ThinkPad X13s and the logs indicate that this > >> is due to a regression in the DRM subsystem [1]. > >> > >> This series fixes a race in the pmic_glink_altmode driver which was > >> exposed / triggered by the transparent DRM bridges rework that went into > >> 6.8-rc1 and that manifested itself as a bridge failing to attach and > >> sometimes triggering a NULL-pointer dereference. > >> > >> [...] > > > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) > > > > [1/6] drm/bridge: aux-hpd: fix OF node leaks > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9ee485bdda68d6d3f5728cbe3150eb9013d7d22b > > [2/6] drm/bridge: aux-hpd: separate allocation and registration > > (no commit info) > > [3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free > > (no commit info) > > [4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m > > (no commit info) > > [5/6] phy: qcom-qmp-combo: fix drm bridge registration > > (no commit info) > > [6/6] phy: qcom-qmp-combo: fix type-c switch registration > > (no commit info) > > > > To clarify, I only applied patch 1 to drm-misc-fixes Ok, but can you please not do that? :) These patches should go in through the same tree to avoid conflicts. I discussed this with Bjorn and Dmitry the other day and the conclusion was that it was easiest to take all of these through DRM. With Vinod acking the PHY patches, I believe you have what you need to merge the whole series now? Johan