Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp833800rbd; Fri, 23 Feb 2024 05:10:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWrGblGHcuUzb6k7o6qCaSFt+13z6xA0DG4RcEfVGaotTIK57ep4QE9o11/ToXKGwUM9eZBFDdrV00gX5fRCY7zwkS2M09QKkaI6KjOzA== X-Google-Smtp-Source: AGHT+IH0K2QjbczCT5fwOwva5Mcb/GPCMBCoGeRihcl4ZK8OCBhsoEOyZ68ni1HGRBdqtnqjioIU X-Received: by 2002:a05:6a00:21d4:b0:6e4:8d1d:7770 with SMTP id t20-20020a056a0021d400b006e48d1d7770mr1869280pfj.3.1708693843509; Fri, 23 Feb 2024 05:10:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708693843; cv=pass; d=google.com; s=arc-20160816; b=AKSJ1z3AjN1BFr0yjEssGDT6Qw7Jb7TfOYWZ82LzAXBohmcRpzAbWpEb3KdtpLJgK5 Jl6ODJtICGI4sAkJRiLQEDAvFcG68SbCNe/VxEe9j3FoZPz23nQtlnJzDYxYL5lIEtR/ HHNZSDAzF7RMquUfe1fvT/9EA+uWoJAjxLRQmRtELlb5AHrClqIV2KQn8ExyZiok3Cdt Ior3f16yiTgHhsCKm7tLZEi4Do3vG1PhnQffbtOWI8RQOVEwluVyuveBHR+OS1BsJ64H jq+bUjeNeglzxWNGv6qWTH8KzUIVu4fzp/l8rT1UZ9FRTZULtz10tmmixwBD0RAI+4eY 2rZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=PKYuV4ot/7rptb4iOd4uJB4HimHWngq7P3JcIdxqn58=; fh=SLx4xmXa7yVA7/02nhW8deoniEtPm3TuCg01ZttiC9U=; b=rXGhl3Z3gQf761XfPYT6Y49ZmEXYLByktDo5w0UaWj9HJo1119HssPccQkbDZoKTLy mM3UhOU4/r4h2maYfvE6ISSnpwlKHki1NCc3Rqt+UJwOvvgAtRAHJINX9obWhFY1v3Tl iMCRKFNqUORHcxia9FI5sj/krOVctiLp+1ZvpAFeXfEOyXAVfD0ybDZa1LRtVgs4iBXi 0iWEyYGmP1CiVFfGob5H22NMOdhaXXb5f1YazS1dEPWsruD8oIKDcSrkAXHwvui633Ez cIbsywzgGWGRvuSpt8IbH1GwvyMOmKsv7NEEKS/9QSQXwoImktpoaMza6gd19ZKMLcka cSJQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=FftO93iA; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-78349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u12-20020a65670c000000b005dab535faabsi11838938pgf.231.2024.02.23.05.10.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 05:10:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=FftO93iA; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-78349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44F3B283760 for ; Fri, 23 Feb 2024 13:10:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B90677E78A; Fri, 23 Feb 2024 13:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FftO93iA" Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578C47CF02 for ; Fri, 23 Feb 2024 13:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708693797; cv=none; b=uETQJwwFmzddaW4ROnQ3l1tstf/4U+LllLkyTgqDMboAud9rUHKChdBqKWmB46i56zXWD9Sb5kF4MM20AdZYHByqWc6qBUN4NZJhW0MuBwswMGMVQ64tmjVpak7V7/I961iqoIYY7b2JmjlhqAICWMCFCfPLrSsjB2fXNDp0EtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708693797; c=relaxed/simple; bh=PKYuV4ot/7rptb4iOd4uJB4HimHWngq7P3JcIdxqn58=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EY9kiPFxObYCH4BO1PuIiQMHbBpnpU4C8YknqhExorlugdYxAfpb5UkaqyUHjdsVP4YtINXhaiblJZE4/280Nv477gYCscO8qe30uTu81ut/GB0wjEQ+24fiL+sVynhvK2pXL5NZCe30X69yis8uaQZWzOWqcqOxwgJE6jm7GBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FftO93iA; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5650c27e352so9035a12.0 for ; Fri, 23 Feb 2024 05:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708693794; x=1709298594; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PKYuV4ot/7rptb4iOd4uJB4HimHWngq7P3JcIdxqn58=; b=FftO93iAaQBh4c40Tp+zwcVrLESMdTaahh1mc2KhiwQ3A7RHGzVW81rPjxAKVNjGrj hB5dStbHbNDeyYtheOiUqPyF6KJkboKah5EfXy92Mlhr8RlhmHpguI1EucG+8qgxMpdg sQAxGYZdqSvHh+yb1selguV3zJvXNqVX7QSerI+GJiv45x1iDvZBR+rGBJbzqD8qKUhC yowPOknriSAIMZkOryKo/gVB6pnlW9Mh/aAOc3I1jTOqOVn6hAwxwmo95rJS7BO+xE2x AmK+Ik8XXanXYOGRhl+UcYStSj8A/EhOzaoo0lKqOBKC3mTa2Y7/Xf3J1PzOZL+AVDuM 9aQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708693794; x=1709298594; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PKYuV4ot/7rptb4iOd4uJB4HimHWngq7P3JcIdxqn58=; b=OLs4Ns3FYF4+YoDMSLxXnjkN9uV5DxYnMtSvSd/wG3zryoqF8a0y0Jq6Huz1j7N+LS JydIRha4w1TN3I9OGh0ziIluJYsn4j9h8tJpygCo2YuKlhJtU9J7G0MRGIELFqRtAjE+ Q+Y87BswimqpomO/VD7VcRVv6s8zgii/6CrtHlbZPS6kFe8gJ0z7ttZpWuafYiB5lYkC YN0ZbX2TyO+hWLWgJ0wvgNCpogUXiDVnKc9xhcOcfT9cI3p9BTLVqpvyqap5DkKOsdNE dpHyjpYPmMISD4LH86eZE/BUklUS3ylOH8ATh8dXdbiZsTKYY2LkKNMzGettDA4Xm/lk aORA== X-Forwarded-Encrypted: i=1; AJvYcCX2hM9+VuuI9nRlA7aSgqa+rbmOd45aGOFQBxkhzCHN0pZPl05/YPJQYLQf2CJIa0msCX7jKSFgcFx+o4KEUZ0BqgQYtw57oCOqyd7z X-Gm-Message-State: AOJu0YyB6aXU9Q9rMYXeD0VQjZPArz0jLuNR6gssT/a47Zfheth/zBRq V0LuBJqr08lSFXpaecP633lov2fRG5E5KN4TB6oPQbkTMawkcXjG7m7NuroDAAxS4utNK+SSFaA E3S/YSYqCo++s8bkhb4yGDcKnuu2QZ0bGr/wg X-Received: by 2002:a50:9f04:0:b0:562:9d2:8857 with SMTP id b4-20020a509f04000000b0056209d28857mr700849edf.6.1708693794353; Fri, 23 Feb 2024 05:09:54 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240223115839.3572852-1-leitao@debian.org> In-Reply-To: <20240223115839.3572852-1-leitao@debian.org> From: Eric Dumazet Date: Fri, 23 Feb 2024 14:09:40 +0100 Message-ID: Subject: Re: [PATCH net-next 1/2] net/vsockmon: Leverage core stats allocator To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, Stefano Garzarella , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, "open list:VM SOCKETS (AF_VSOCK)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 12:58=E2=80=AFPM Breno Leitao w= rote: > > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the vsockmon driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao Reviewed-by: Eric Dumazet