Received-SPF: pass (google.com: domain of linux-kernel+bounces-78365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 23 Feb 2024 15:16:59 +0200
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] media: dt-bindings: sony,imx290: Allow props from
 video-interface-devices
Message-ID: <20240223131659.GX31348@pendragon.ideasonboard.com>
References: <20240223124744.545955-1-alexander.stein@ew.tq-group.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240223124744.545955-1-alexander.stein@ew.tq-group.com>

Hi Alexander,

Thank you for the patch.

On Fri, Feb 23, 2024 at 01:47:43PM +0100, Alexander Stein wrote:
> Allow properties from video-interface-devices. This aligns the bindings
> to sony,imx415.yaml. Changes inspired by commit e2e73ed46c395 ("media:
> dt-bindings: sony,imx415: Allow props from video-interface-devices")
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> index a531badc16c98..e957b5dd4284d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> @@ -23,6 +23,9 @@ description: |-
>    is treated the same as this as it was the original compatible string.
>    imx290llr is the mono version of the sensor.
>  
> +allOf:
> +  - $ref: ../video-interface-devices.yaml#

I think this should be

  - $ref: /schemas/media/video-interface-devices.yaml#

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Bonus points if you would like to send patches to the DT bindings of the
gc0308, gc2145, imx214 and imx415 to fix that :-)

> +
>  properties:
>    compatible:
>      oneOf:
> @@ -101,7 +104,7 @@ required:
>    - vdddo-supply
>    - port
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |

-- 
Regards,

Laurent Pinchart