Received-SPF: pass (google.com: domain of linux-kernel+bounces-78383-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 23 Feb 2024 13:31:58 +0000
From: Mark Brown <broonie@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	will@kernel.org, catalin.marinas@arm.com,
	James Clark <james.clark@arm.com>, Rob Herring <robh@kernel.org>,
	Marc Zyngier <maz@kernel.org>,
	Suzuki Poulose <suzuki.poulose@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V16 1/8] arm64/sysreg: Add BRBE registers and fields
Message-ID: <ZdieTjUeTLXvp39E@finisterre.sirena.org.uk>
References: <20240125094119.2542332-1-anshuman.khandual@arm.com>
 <20240125094119.2542332-2-anshuman.khandual@arm.com>
 <ZdYAJvZf4Ut5f5Rf@FVFF77S0Q05N>
 <e89ecbde-0967-4b8e-af77-3a72f207f3d7@sirena.org.uk>
 <ZdYDJPe1n5-V-AnT@FVFF77S0Q05N>
 <7fe52cb9-12b9-4b03-8e55-08e59b4bef27@sirena.org.uk>
 <b2dfcaf1-f466-4e81-8ca4-02bf3fa837e5@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4llPrfxUQhdEFbq0"
Content-Disposition: inline
In-Reply-To: <b2dfcaf1-f466-4e81-8ca4-02bf3fa837e5@arm.com>


--4llPrfxUQhdEFbq0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 23, 2024 at 10:58:12AM +0530, Anshuman Khandual wrote:
> On 2/21/24 19:37, Mark Brown wrote:
> > On Wed, Feb 21, 2024 at 02:05:24PM +0000, Mark Rutland wrote:

> >> Sure, we're inconsistent. I'd just prefer that there's *some* local ordering
> >> here, as the patch is neither ordered as above nor by encoding:

> > I agree, I'm just saying that if we're going to fix the ordering it'd
> > probably be better to go along with what the rest of the file is doing.

> Sure, will change the registers order as has been suggested earlier i.e
> alphanumerically instead. Because ordering registers with encoding will
> push BRBCR_EL2/12 after all other BRBE registers, including BRBIDR0_EL1.

> After the change

> BRBCR_EL1
> BRBCR_EL12
> BRBCR_EL2

The _EL2/12 registers generally come at the end of the file due to the
way the encodings work?

--4llPrfxUQhdEFbq0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXYnkEACgkQJNaLcl1U
h9Bl7Qf/T6AgPiF3hy4ca5oIw9FbPpc/LuFaIqEzsSx0bRIxMIzzxJXU8vg8ybuN
OENNS3EwOwe1WWO0bLK0CRa7xrNbw+/UKGIDMpcDSB3BsCWRoaPOXDlzm8FO41Xv
5txtkQxK70NgX73qqOcN3HR4rEnM6MNbAYnIJKFrJ0Q5ziH8Th7DwIUSFRGiwPbk
zUoyEfmPM7HSOOp5F7YwvZVByfXxEnsMufrAOPjmTnULJKRil2y6YZIxwjwHx8eo
ETEjNcnJimHc8kpO1u5LVLykQDRDOk9M/3a3MS/mbr4iEXc4FxR0ULR8OAxvFj5e
cGqUKN3QrTI9u/8xU6EmL4fXZBjkEA==
=k3W3
-----END PGP SIGNATURE-----

--4llPrfxUQhdEFbq0--