Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp851473rbd; Fri, 23 Feb 2024 05:43:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX9D4Ne2RxbsiKBOpDSyYQ64iHUPuWuYyzyRmsVJhJaxoDRe8QHy0YsnZqn71LbP7s8j8nd9GOhe9IJlHEw9eXbOImiMLlAXo/Ql1iOdg== X-Google-Smtp-Source: AGHT+IGZuY5PLEpoQ8wYQonMEzoy8o4+N2Fub6XO6ZuVxRzZFvx0UKdAM0/36X2RUYQhDntdDnYN X-Received: by 2002:a05:6870:310b:b0:21e:58ab:9069 with SMTP id v11-20020a056870310b00b0021e58ab9069mr1790791oaa.42.1708695811652; Fri, 23 Feb 2024 05:43:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708695811; cv=pass; d=google.com; s=arc-20160816; b=t2EZCrQWQHgCZd4vmZ/53IAdzBzo7vCJw6GAlYRCbQ7xIULikS6Em2hnAtgQD/AMOQ mN9HIx8tjEumM61KqQtBbqxpfpalrtXmp851y/080I3z+Is/PTcJioKYTC3SNVwRr1Km ezA7pkmA/1YgA1qYNWoqDkD4lsFf7SfTfAl3HySXRGki4GYLIibBhPeBaNcoFcbopAyE i3k+CYmTERCl2vNrid7mAAydap2s/5hXqbw/ba9GmLn1zUcs7Ri9vkXSBkK7Gcmp7fpw q79SvSP1fEcVPGoh+QAKe8eeD5tvyaMwYuYk8oVzfq9b/6/rqJUW1zWSzqmWWroDQLSD 2+Hg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=HAlGRXK6yLpeQqrspwRaNvh6d0azMopKBJJo+p7r43o=; fh=2n3yAJ+9314DFvMetAszFrCiR0p+wnHPhJICHFGv/DI=; b=AbsuMGZo/CQrCwAmvH2xqLu3/RhsU0ciENUHdINIjKFjK+nBoagegkZyLXHw48dwm/ 9hfYbEGtyx2IsDxLvz1B9C6yILaNkEG9K4Wq3q/Btd0quoA8nf+7sN59fGxb5m1KoF1u NVExIUxB2LrSc0MEiKWr1jFZ/LkMcAg/oPOWu21LNMhFAk6IvlL8EAZE37O8H6iKC7W+ 5qY7m1q98GesdcaP6Qr84J5dzAQwzeBGtij6rSLUxSL0PdETOOxy9zN1UZFe6FiexDA8 H1gTSKn7vFjkYR9ip/56uoJZe9zYXpni0e/yj3623rv14lS023tMsaLbkb/K1UCudgkf IZLQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sntech.de dmarc=pass fromdomain=sntech.de); spf=pass (google.com: domain of linux-kernel+bounces-78404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78404-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o21-20020a637e55000000b005dcbb848d2dsi11907952pgn.551.2024.02.23.05.43.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 05:43:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sntech.de dmarc=pass fromdomain=sntech.de); spf=pass (google.com: domain of linux-kernel+bounces-78404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78404-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 527AD2867E5 for ; Fri, 23 Feb 2024 13:43:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 93F968174C; Fri, 23 Feb 2024 13:41:21 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67ADB7F493; Fri, 23 Feb 2024 13:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708695681; cv=none; b=Z/3VclEkFiFBloisjt1nwePNwcksYgPb87KkIFxs04b4I+ICzxqnxIKp7wzpwuoF4/G9zDiHWL0rC84yhCACQnukMFbr1zed4pNp5tUlipRN4m+yvCEtZAa/iqNPu/VZ1bqQZr3T7jWSZFJ1yK2soo0Ja6rn2G7I0w4ZGatltcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708695681; c=relaxed/simple; bh=yuJXpRYUJshMxuzMieG1EFSg+djx7nwtZ8wXWiT2ueU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XyqZQ3PmjRowuKuXFvjN3jMoBqaNPDWK9kVNxqLshCmXEPJIG1uI2o2JwMhSzol9jwtcEuNQh92LxMtqCn/3/b3nPdpXQNZBTU+m5LJ07oxoUCOEih5mpWp0FudJQi9oj7ZRtr6mb4pG/ok5NsLAgjZvXVzfZyoFYiYu6qoa6mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i53875b6c.versanet.de ([83.135.91.108] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rdVn4-0001FZ-Ou; Fri, 23 Feb 2024 14:40:38 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jonathan Cameron , Lars-Peter Clausen , AngeloGioacchino Del Regno , Andy Shevchenko , Shreeya Patel , Simon Xue , Philipp Zabel , Quentin Schulz Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz , Quentin Schulz Subject: Re: [PATCH 1/3] iio: adc: rockchip_saradc: fix bitmask for channels on SARADCv2 Date: Fri, 23 Feb 2024 14:40:37 +0100 Message-ID: <4499105.Wku2Vz74k6@diego> In-Reply-To: <20240223-saradcv2-chan-mask-v1-1-84b06a0f623a@theobroma-systems.com> References: <20240223-saradcv2-chan-mask-v1-0-84b06a0f623a@theobroma-systems.com> <20240223-saradcv2-chan-mask-v1-1-84b06a0f623a@theobroma-systems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Freitag, 23. Februar 2024, 13:45:21 CET schrieb Quentin Schulz: > From: Quentin Schulz > > The SARADCv2 on RK3588 (the only SoC currently supported that has an > SARADCv2) selects the channel through the channel_sel bitfield which is > the 4 lowest bits, therefore the mask should be GENMASK(3, 0) and not > GENMASK(15, 0). > > Fixes: 757953f8ec69 ("iio: adc: rockchip_saradc: Add support for RK3588") > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz after checking against the TRM Reviewed-by: Heiko Stuebner