Received-SPF: pass (google.com: domain of linux-kernel+bounces-78406-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 23 Feb 2024 06:43:26 -0700
From: Rob Herring <robh@kernel.org>
To: Danila Tikhonov <danila@jiaxyga.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, mturquette@baylibre.com,
	sboyd@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, david@mainlining.org, adrian@travitia.xyz,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] dt-bindings: clock: qcom,sm7150-gcc: Add missing CX
 power domain
Message-ID: <20240223134326.GA1754133-robh@kernel.org>
References: <20240220165240.154716-1-danila@jiaxyga.com>
 <20240220165240.154716-2-danila@jiaxyga.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240220165240.154716-2-danila@jiaxyga.com>

On Tue, Feb 20, 2024 at 07:52:33PM +0300, Danila Tikhonov wrote:
> SM7150 GCC expected two power domains - CX and CX_AO. Currently only
> one is supported, so add the missing CX.

This makes no sense. You had 0 and now you have 1 power domain, not 2. 
Where is CX_AO.

> 
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
>  .../devicetree/bindings/clock/qcom,sm7150-gcc.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml
> index 0eb76d9d51c4..1360e9d1d6ee 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml
> @@ -27,9 +27,15 @@ properties:
>        - description: Board XO Active-Only source
>        - description: Sleep clock source
>  
> +  power-domains:
> +    maxItems: 1
> +    description:
> +      CX power domain.
> +
>  required:
>    - compatible
>    - clocks
> +  - power-domains

Adding new required properties is an ABI break. If that is fine, you 
must say why in the commit message.

>  
>  allOf:
>    - $ref: qcom,gcc.yaml#
> @@ -39,12 +45,14 @@ unevaluatedProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/power/qcom,rpmhpd.h>
>      clock-controller@100000 {
>        compatible = "qcom,sm7150-gcc";
>        reg = <0x00100000 0x001f0000>;
>        clocks = <&rpmhcc RPMH_CXO_CLK>,
>                 <&rpmhcc RPMH_CXO_CLK_A>,
>                 <&sleep_clk>;
> +      power-domains = <&rpmhpd RPMHPD_CX>;
>        #clock-cells = <1>;
>        #reset-cells = <1>;
>        #power-domain-cells = <1>;
> -- 
> 2.43.2
>