Received-SPF: pass (google.com: domain of linux-kernel+bounces-78434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 23 Feb 2024 14:59:00 +0100
From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] fs/writeback: correct comment of
 __wakeup_flusher_threads_bdi
Message-ID: <20240223135900.cogmgf5zvub3cpm2@quack3>
References: <20240208172024.23625-1-shikemeng@huaweicloud.com>
 <20240208172024.23625-7-shikemeng@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208172024.23625-7-shikemeng@huaweicloud.com>

On Fri 09-02-24 01:20:23, Kemeng Shi wrote:
> Commit e8e8a0c6c9bfc ("writeback: move nr_pages == 0 logic to one
> location") removed parameter nr_pages of __wakeup_flusher_threads_bdi
> and we try to writeback all dirty pages in __wakeup_flusher_threads_bdi
> now. Just correct stale comment.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/fs-writeback.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index e8868e814e0a..816505d74b2f 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2345,8 +2345,7 @@ void wb_workfn(struct work_struct *work)
>  }
>  
>  /*
> - * Start writeback of `nr_pages' pages on this bdi. If `nr_pages' is zero,
> - * write back the whole world.
> + * Start writeback of all dirty pages on this bdi.
>   */
>  static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,
>  					 enum wb_reason reason)
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR