Received-SPF: pass (google.com: domain of linux-kernel+bounces-78451-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <b08539f4afdceeb5a0d675113734f6f2f402a311.camel@gmail.com>
Subject: Re: [PATCH v15 2/3] iio: adc: ad_sigma_delta: Add optional irq
 selection
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org, 
 linux-gpio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, Jonathan
 Cameron <jic23@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>,  Michael Walle <michael@walle.cc>, Andy Shevchenko
 <andy.shevchenko@gmail.com>, Arnd Bergmann <arnd@arndb.de>,  ChiaEn Wu
 <chiaen_wu@richtek.com>, Niklas Schnelle <schnelle@linux.ibm.com>, Leonard
 =?ISO-8859-1?Q?G=F6hrs?= <l.goehrs@pengutronix.de>, Mike Looijmans
 <mike.looijmans@topic.nl>, Haibo Chen <haibo.chen@nxp.com>, Hugo Villeneuve
 <hvilleneuve@dimonoff.com>, David Lechner <dlechner@baylibre.com>, Ceclan
 Dumitru <dumitru.ceclan@analog.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org
Date: Fri, 23 Feb 2024 15:16:04 +0100
In-Reply-To: <20240223133758.9787-2-mitrutzceclan@gmail.com>
References: <20240223133758.9787-1-mitrutzceclan@gmail.com>
	 <20240223133758.9787-2-mitrutzceclan@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-02-23 at 15:37 +0200, Dumitru Ceclan wrote:
> Add optional irq_num attribute to ad_sigma_delta_info structure for
> selecting the used interrupt line for ADC's conversion completion.
>=20
> Signed-off-by: Dumitru Ceclan <mitrutzceclan@gmail.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> V15->V14
> =C2=A0- Uppercase ADC acronym in commit message
> =C2=A0- Rename irq_num to irq_line, change type to int
> V13->V14
> =C2=A0- Invert logic checking the presence of the optional irq_num attrib=
ute
> V1->V12
> <Not present>
> =C2=A0drivers/iio/adc/ad_sigma_delta.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 | 23 ++++++++++++++---------
> =C2=A0include/linux/iio/adc/ad_sigma_delta.h |=C2=A0 3 +++
> =C2=A02 files changed, 17 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad_sigma_delta.c
> b/drivers/iio/adc/ad_sigma_delta.c
> index 7e2192870743..03c170b638a8 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -222,11 +222,11 @@ int ad_sd_calibrate(struct ad_sigma_delta *sigma_de=
lta,
> =C2=A0		goto out;
> =C2=A0
> =C2=A0	sigma_delta->irq_dis =3D false;
> -	enable_irq(sigma_delta->spi->irq);
> +	enable_irq(sigma_delta->irq_line);
> =C2=A0	timeout =3D wait_for_completion_timeout(&sigma_delta->completion, =
2 *
> HZ);
> =C2=A0	if (timeout =3D=3D 0) {
> =C2=A0		sigma_delta->irq_dis =3D true;
> -		disable_irq_nosync(sigma_delta->spi->irq);
> +		disable_irq_nosync(sigma_delta->irq_line);
> =C2=A0		ret =3D -EIO;
> =C2=A0	} else {
> =C2=A0		ret =3D 0;
> @@ -295,7 +295,7 @@ int ad_sigma_delta_single_conversion(struct iio_dev
> *indio_dev,
> =C2=A0	ad_sigma_delta_set_mode(sigma_delta, AD_SD_MODE_SINGLE);
> =C2=A0
> =C2=A0	sigma_delta->irq_dis =3D false;
> -	enable_irq(sigma_delta->spi->irq);
> +	enable_irq(sigma_delta->irq_line);
> =C2=A0	ret =3D wait_for_completion_interruptible_timeout(
> =C2=A0			&sigma_delta->completion, HZ);
> =C2=A0
> @@ -315,7 +315,7 @@ int ad_sigma_delta_single_conversion(struct iio_dev
> *indio_dev,
> =C2=A0
> =C2=A0out:
> =C2=A0	if (!sigma_delta->irq_dis) {
> -		disable_irq_nosync(sigma_delta->spi->irq);
> +		disable_irq_nosync(sigma_delta->irq_line);
> =C2=A0		sigma_delta->irq_dis =3D true;
> =C2=A0	}
> =C2=A0
> @@ -396,7 +396,7 @@ static int ad_sd_buffer_postenable(struct iio_dev
> *indio_dev)
> =C2=A0		goto err_unlock;
> =C2=A0
> =C2=A0	sigma_delta->irq_dis =3D false;
> -	enable_irq(sigma_delta->spi->irq);
> +	enable_irq(sigma_delta->irq_line);
> =C2=A0
> =C2=A0	return 0;
> =C2=A0
> @@ -414,7 +414,7 @@ static int ad_sd_buffer_postdisable(struct iio_dev
> *indio_dev)
> =C2=A0	wait_for_completion_timeout(&sigma_delta->completion, HZ);
> =C2=A0
> =C2=A0	if (!sigma_delta->irq_dis) {
> -		disable_irq_nosync(sigma_delta->spi->irq);
> +		disable_irq_nosync(sigma_delta->irq_line);
> =C2=A0		sigma_delta->irq_dis =3D true;
> =C2=A0	}
> =C2=A0
> @@ -516,7 +516,7 @@ static irqreturn_t ad_sd_trigger_handler(int irq, voi=
d *p)
> =C2=A0irq_handled:
> =C2=A0	iio_trigger_notify_done(indio_dev->trig);
> =C2=A0	sigma_delta->irq_dis =3D false;
> -	enable_irq(sigma_delta->spi->irq);
> +	enable_irq(sigma_delta->irq_line);
> =C2=A0
> =C2=A0	return IRQ_HANDLED;
> =C2=A0}
> @@ -586,9 +586,9 @@ static int devm_ad_sd_probe_trigger(struct device *de=
v,
> struct iio_dev *indio_de
> =C2=A0	sigma_delta->irq_dis =3D true;
> =C2=A0
> =C2=A0	/* the IRQ core clears IRQ_DISABLE_UNLAZY flag when freeing an IRQ=
 */
> -	irq_set_status_flags(sigma_delta->spi->irq, IRQ_DISABLE_UNLAZY);
> +	irq_set_status_flags(sigma_delta->irq_line, IRQ_DISABLE_UNLAZY);
> =C2=A0
> -	ret =3D devm_request_irq(dev, sigma_delta->spi->irq,
> +	ret =3D devm_request_irq(dev, sigma_delta->irq_line,
> =C2=A0			=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ad_sd_data_rdy_trig_poll,
> =C2=A0			=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sigma_delta->info->irq_flag=
s | IRQF_NO_AUTOEN,
> =C2=A0			=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 indio_dev->name,
> @@ -668,6 +668,11 @@ int ad_sd_init(struct ad_sigma_delta *sigma_delta, s=
truct
> iio_dev *indio_dev,
> =C2=A0		}
> =C2=A0	}
> =C2=A0
> +	if (info->irq_line)
> +		sigma_delta->irq_line =3D info->irq_line;
> +	else
> +		sigma_delta->irq_line =3D spi->irq;
> +
> =C2=A0	iio_device_set_drvdata(indio_dev, sigma_delta);
> =C2=A0
> =C2=A0	return 0;
> diff --git a/include/linux/iio/adc/ad_sigma_delta.h
> b/include/linux/iio/adc/ad_sigma_delta.h
> index 7852f6c9a714..576eb617939d 100644
> --- a/include/linux/iio/adc/ad_sigma_delta.h
> +++ b/include/linux/iio/adc/ad_sigma_delta.h
> @@ -45,6 +45,7 @@ struct iio_dev;
> =C2=A0 * @data_reg: Address of the data register, if 0 the default addres=
s of 0x3
> will
> =C2=A0 *=C2=A0=C2=A0 be used.
> =C2=A0 * @irq_flags: flags for the interrupt used by the triggered buffer
> + * @irq_line: IRQ for reading conversions. If 0, spi->irq will be used
> =C2=A0 * @num_slots: Number of sequencer slots
> =C2=A0 */
> =C2=A0struct ad_sigma_delta_info {
> @@ -60,6 +61,7 @@ struct ad_sigma_delta_info {
> =C2=A0	unsigned int data_reg;
> =C2=A0	unsigned long irq_flags;
> =C2=A0	unsigned int num_slots;
> +	int irq_line;
> =C2=A0};
> =C2=A0
> =C2=A0/**
> @@ -87,6 +89,7 @@ struct ad_sigma_delta {
> =C2=A0	unsigned int		active_slots;
> =C2=A0	unsigned int		current_slot;
> =C2=A0	unsigned int		num_slots;
> +	int		irq_line;
> =C2=A0	bool			status_appended;
> =C2=A0	/* map slots to channels in order to know what to expect from devi=
ces
> */
> =C2=A0	unsigned int		*slots;