Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp874343rbd; Fri, 23 Feb 2024 06:20:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUnrlkNz9z4ixCfYrdIpr7hY7kDnciBHVj4NG9ViMiAUmQzltcMSx5Pa9N47X3nntpk4f2UjfFPcQYCneorbfdNRSmUWwGR6RkinYFtXw== X-Google-Smtp-Source: AGHT+IFoC5Odt4GMoeY3P5IdNcC90ujJ0bHxeMRU14trVeBf1Qo/8k+eeeFLW6FTwO90w6NoSUae X-Received: by 2002:a0c:db8f:0:b0:68d:129e:f5c1 with SMTP id m15-20020a0cdb8f000000b0068d129ef5c1mr1961202qvk.45.1708698010826; Fri, 23 Feb 2024 06:20:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708698010; cv=pass; d=google.com; s=arc-20160816; b=ECntuKnefTaPGyD+MgM1FO6ee9d1plinUO8K6R/xnqccmrMVuR35P3zOJlpxVW4KeL gdYLUoN3tKSvPIA6xMHCA519NsNhHvVu3APongonOnna+yz0UVZDcVaYwnrEPJ62t+wy GpDwuCy4D9jjn1O/pz4QPWQ4+MPJ0lHTLakfRhAEe7ZLm++reyCqWxjZ1Ng41qJKCiUJ BAcEQvD7nCgr//VlxsIPB+o6GQhoc32bXi3C6iGwlRUSMqdTkVDziK584LHPPwPM7R1l UM/Bt0hKtqzNe6N0uukmxUGkBkymqHWeQ/BhU1Kw8fI5VVlR2Q6Owcqv6vcafqo2PTTC Rw0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=R19d00zAe0ESb2W1wfQWoMVwkbh2mKJoTeu+62qXKLU=; fh=XXpF/acNfx2wMzBVT/P+XV4CQUBNYB+zx2JDVFL4Jwg=; b=uh0X1xKWAbuE6MQslAtdOWhx8YTpBBluJXp6aHN6g7eS/sxb8E5P5tJaQjxGvMa8Ak ZB/rqJcopPlXSyQSz1ia1ijVw/Sn9iFsZrU6NJWP3s4MxZ5eniOO+DgLEnosaQHinun5 RTQgufpB5XFs73wtIHjnRaqb0QFmaN/0FuyRVNyROIfEAm/MB9kLqDAVfn9JnCOd6PFA nQCsmT3siC/KyAEXprhQMAJHaQMN1fDCjCn65AwCI4VgkTdlD5L5fbTR5Ee9LAUXNQs6 /dDplQhBATip+ijvfNOtEd3XT5tAyuBeS8TO0phUW7SoX0+fiptIyEmo5I/6HLEb5I7J 5ZFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Uuix5bik; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-78468-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78468-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u4-20020ad45aa4000000b0068f44562bbasi14486719qvg.167.2024.02.23.06.20.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 06:20:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78468-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Uuix5bik; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-78468-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78468-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9051C1C2285C for ; Fri, 23 Feb 2024 14:20:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5219E80C0E; Fri, 23 Feb 2024 14:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Uuix5bik" Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F198061F for ; Fri, 23 Feb 2024 14:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708697903; cv=none; b=GIkVvFQcmLxHvPkGZrgi3hpJJT0qs6YpUD1lwoCZe1XXK8nF89Hfx4VzW6Ne82nB+v+83JnDfAG+FXdF8IX3iNQu4LdzD5RgbB4d9KcglRbam4fjSB1H5DFj5++XsSeT/AjGm3VmukOd0xx7uVayh0tvQbUDoSnEIOXRx0leqJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708697903; c=relaxed/simple; bh=HX4TUSWSsGsJPJcz5laMwy2GWSZ/MRJtO55N1YPwBtI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=YlLdjxfeL3jMz+kT1qdIXQCa0GvMDiZFXj00ioOLgHPs9FB6Rb9BJpVs/AQIeDcSjY4f6EiPwmTZF1pCJuKI+GimLt5TQgF/vs0l0m5Azao/7QrJZ/wf6yfoa2TQ11O8Y4HpTGFyJvlMPnyfQYsFZzfu1qFS0s0m1V5C0G8xvvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Uuix5bik; arc=none smtp.client-ip=209.85.219.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-dcd9e34430cso907675276.1 for ; Fri, 23 Feb 2024 06:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708697900; x=1709302700; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R19d00zAe0ESb2W1wfQWoMVwkbh2mKJoTeu+62qXKLU=; b=Uuix5bik05hshGSFS+elh24cUmuSawIIxz+Z0ZYmu0RAIJ6/qMBF92f+Kf25yC54jj VDJnu211xVQPfp3BLphWiWw0wPSjlN1E0hZeBnPd/iDETrxfTDBb05oRFWiBaRHdq8UQ Ai9JWsdO3zPhWL1jBk7z9yDiY2bSHw9Kz4ee3cYRBs0OViy8zsGxNduqb9A5EIHmYTvi F+43srEtFbOf5VYQSjrkj6fObI9uc/jdZVxN9BCV5eyS1EApJWnlWG5/aeMi1MJC5L83 wutcUuYT4opGw0F5483FkaQVGb2aT6yMpTCx9x0+WBK19tuUVQqdjsa/HA3oLWRUmWQT p72g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708697900; x=1709302700; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R19d00zAe0ESb2W1wfQWoMVwkbh2mKJoTeu+62qXKLU=; b=VSbGFF8ARASOHCcJSpd4r6nj5qCcXQG+T7RK4a/2+gz45ZtizOOjV8TAb2itM84Nmi g7iFBlwSyamPYeZZB+3ziaCTWyPT/wnPoJNhLGeFh6NmZ0suQHS/WgXBDY2qSz8Cs6vk KYP1zIF/BEOTuwfTjnkJJwrZNdgLstumRAlUR3nTeMzzNPZQ1slNPT3XsWeD4us3LXhJ mjlvB5jeFTQwtWmlvT4opewb7Ph1thTWQVqni30OotUz76iKdRxK1s3U6k0srOqTC4hf ZsYfWzlviuoqgcwcrAQqdG7d4Un6M48maO9vHM3c9OxED8KbrwwmLPkzXVVGHQsPu/Uc fBoQ== X-Forwarded-Encrypted: i=1; AJvYcCUlRTNuTpSLayfvnVpZ4Ggrxm60xAYc5QzTR35DhcnovulQ+c1a+fQsYQ1FctqEYpmODSYngV3lO+fwvpCO74f0FX6kUzv19WzlAe7z X-Gm-Message-State: AOJu0YwpDst8tccSrxz8XQuFj2WMtcnphYpaCHRn8n9Y0yl1lw1DMB6r yxPv5V8/p/+U+Yb8yGnWWYFH8NrcWXx6ZVgBsrP9kll1M0VkWCyVW6vzkmiAtdmZ5ieKGer5p5O xY4tAPZrB7PTKjMULAeidopMDeX9j+nABIRLO3A== X-Received: by 2002:a25:6b03:0:b0:dc7:32e5:a707 with SMTP id g3-20020a256b03000000b00dc732e5a707mr1990018ybc.61.1708697900641; Fri, 23 Feb 2024 06:18:20 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240217150228.5788-1-johan+linaro@kernel.org> <170868613914.4029284.5549880672870201262.b4-ty@linaro.org> <3c4246b6-431a-442e-8ace-3b0d0e67743f@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Fri, 23 Feb 2024 16:18:08 +0200 Message-ID: Subject: Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free To: neil.armstrong@linaro.org Cc: Johan Hovold , Bjorn Andersson , Andrzej Hajda , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Vinod Koul , Johan Hovold , Jonas Karlman , Laurent Pinchart , Jernej Skrabec , Konrad Dybcio , Kishon Vijay Abraham I , Rob Clark , Abhinav Kumar , Kuogee Hsieh , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Content-Type: text/plain; charset="UTF-8" On Fri, 23 Feb 2024 at 15:52, Neil Armstrong wrote: > > On 23/02/2024 13:51, Johan Hovold wrote: > > On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: > >> On 23/02/2024 12:02, Neil Armstrong wrote: > >>> Hi, > >>> > >>> On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: > >>>> Starting with 6.8-rc1 the internal display sometimes fails to come up on > >>>> machines like the Lenovo ThinkPad X13s and the logs indicate that this > >>>> is due to a regression in the DRM subsystem [1]. > >>>> > >>>> This series fixes a race in the pmic_glink_altmode driver which was > >>>> exposed / triggered by the transparent DRM bridges rework that went into > >>>> 6.8-rc1 and that manifested itself as a bridge failing to attach and > >>>> sometimes triggering a NULL-pointer dereference. > >>>> > >>>> [...] > >>> > >>> Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) > >>> > >>> [1/6] drm/bridge: aux-hpd: fix OF node leaks > >>> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9ee485bdda68d6d3f5728cbe3150eb9013d7d22b > >>> [2/6] drm/bridge: aux-hpd: separate allocation and registration > >>> (no commit info) > >>> [3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free > >>> (no commit info) > >>> [4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m > >>> (no commit info) > >>> [5/6] phy: qcom-qmp-combo: fix drm bridge registration > >>> (no commit info) > >>> [6/6] phy: qcom-qmp-combo: fix type-c switch registration > >>> (no commit info) > >>> > >> > >> To clarify, I only applied patch 1 to drm-misc-fixes > > > > Ok, but can you please not do that? :) > > > > These patches should go in through the same tree to avoid conflicts. > > > > I discussed this with Bjorn and Dmitry the other day and the conclusion > > was that it was easiest to take all of these through DRM. > > I only applied patch 1, which is a standalone fix and goes into a separate tree, > for the next patches it would be indeed simpler for them to go via drm-misc when > they are properly acked. I think PHY patches can go through a usual route (phy/next or phy/fixes). For patches 3 and 4 I'd need an ack from Bjorn to merge them through drm-misc-next or drm-misc-fixes. -- With best wishes Dmitry