Received-SPF: pass (google.com: domain of linux-kernel+bounces-78486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 23 Feb 2024 15:31:31 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Wen Yang <wenyang.linux@foxmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Christian Brauner <brauner@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get_signal: simplify/cleanup the the usage of ksig->info
Message-ID: <20240223143131.GC8267@redhat.com>
References: <20240223105025.GA4542@redhat.com>
 <tencent_7C50F304C14CB2A5133317F8A13D1F544D0A@qq.com>
 <20240223141928.GB8267@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240223141928.GB8267@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

On 02/23, Oleg Nesterov wrote:
>
> On 02/23, Wen Yang wrote:
> >
> >
> > On 2024/2/23 18:50, Oleg Nesterov wrote:
> > >+			/*
> > >+			 * implies do_group_exit(), no need to initialize
> > >+			 * ksig->info
> > >+			 */
> > >  			goto fatal;
> >
> > There is little question:
> > If the this conditions is met:
> >    current->flags & PF_USER_WORKER
> > It may execute “goto out“ instead of do_group_exit().
>
> Yes, but vhost/io workers do not use ksig at all.

Ah, wait...

I forgot about the ->sa_flags check before hide_si_addr_tag_bits().

OK, thanks... I'll send V2.

Oleg.