Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp900353rbd; Fri, 23 Feb 2024 07:05:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXOdQF4jga20ETiJrxxnLZ5Y13XMU9tnLUf9cCU+MOghGcJcsfqE3RYc7HUfXN4XkF9pQgw/iK17huXA5MU7rrj2BXwuCUc1Pq0rJ/QaA== X-Google-Smtp-Source: AGHT+IFd91rRc6QP4Omd2zO7suWaD9fClYB2ENRFwbMx1JSmxEDvDG1SY9HYCMITWu3DT+faF6eK X-Received: by 2002:a05:6602:1215:b0:7c7:87a8:98f9 with SMTP id y21-20020a056602121500b007c787a898f9mr144218iot.5.1708700715170; Fri, 23 Feb 2024 07:05:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708700715; cv=pass; d=google.com; s=arc-20160816; b=hLw4bFl297d7tkdSsChXPrrwKCt5Z1Ruuqh0EVDL2QnMwW5Ps6ASH8QXG0OuOGsy1C zY3NMoXjJYQ0vbDfek3m7MNlygjsS9smcOLytRxXFdr5zNRmKvreO3DYTbV+PFOuXb+h SdeiGdZRqJhSkBJ+68mjPSvKC6ysbXvj7aFHnQ4Fw6QQtulMOoZO+Y15cBlUwzKhIy0l +EGZqvpEDtfErkYInW1gmLKC/cP1Lg8snl8yfbzv/Eo0eJXlRDecRVwksJAJFTfa3pp7 FykOVEyT8EfEF5kHrI9lLdsNuWCnDPpc+p8r384e3cXzjbf18XkgwTFOCIY4pNvybGuh DA1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=iMO3MnEoqkGGMfR5qCARB8BwTEcfu+rCmzwC1hIJkBM=; fh=v+nI0kSB/KLHXr2SU7WcKtMchwZ7HwThaDOnECANDy4=; b=fggzEMnJjCbv72H3usMxAldL2xCGtMT0IrZdwVLyt2uZkRyFEPNoc4+U7xYSpmjciK UHXMv2ZucmS1rfk/ghmkqYwrCWa71IBYVc1e/7JdWyb20qmIj4wY4U5gqz1PTtYkEEJ2 g3n8z+UsmpLWsVoBH0vtxu81lY/Okk0GNGI6laUkEFWmXgBwgqr0NTnxHwhuMbOsVRHI ZZcsoB3e51SPbHnZs2IytgUKHpX6eywyPg9jdK81Zey4JtjAsOE1eKwRh6oO7WrBl7At NG48yJcoVgk/wXk/ZldTqxIMkE4uihXu29Am/aUKsTfvSGrLw+gBUedtoXwha66S3Xe3 xbzw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F+026vrI; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-78567-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78567-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v10-20020a02b90a000000b004744dceeb24si1634873jan.99.2024.02.23.07.05.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:05:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78567-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F+026vrI; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-78567-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78567-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4408228263F for ; Fri, 23 Feb 2024 15:05:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D32D7823CD; Fri, 23 Feb 2024 15:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F+026vrI" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EA166E60D for ; Fri, 23 Feb 2024 15:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708700693; cv=none; b=BvN7hR6TyWibTq17bmK7ee4k9XTG7uPZJWDNOSz+zEVnRiOmnI82KLpAtLBZ1IPntGRJhDl1Kr09Es2A4DcZVQ0/LJx8oh3gCd7tBGicPplXtadE24fxrswxfOCLsonQVYw+BsVvsiDMa/7Yuq/daXmnXHk4y7lOPrfWrpXb4HI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708700693; c=relaxed/simple; bh=zE5VEPzfxvPlC3BpeQHuFfeO4qV/thHrz7yf4Fc4zQ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BWSwNkS6HdNqfbZLXL4Ax3c7OLkrK2Xe0FXnOgw6Cu6xJBW2IsFpBozkNbIyZHThuTSK/cXiBe749vr5+7Fb4SB3vvVBgyJFbKBhqsPfDH2XIqjjoF8mDFJNKnS7A6LfpcSLrcAg38CUC2ATKRvUlIaDVkB6M73N+aXFU85NJ9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F+026vrI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708700690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iMO3MnEoqkGGMfR5qCARB8BwTEcfu+rCmzwC1hIJkBM=; b=F+026vrIHfatQYBdtoHk98/5yCIq6JetauJGMabmS0LsnVRhXP0VUXp5kn5eEUo78Z1O9O StNXPeMzfVuFSGUbUgOSSgkeeZz7/pOMvDB5967tO0UMyeGHxzjfGjg7+XOhF+W0K+9sUh fhNIh74IXX2eSQchafxGEX4IxqwD//o= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-gliD07t_PCyrtWRxqvaEDw-1; Fri, 23 Feb 2024 10:04:48 -0500 X-MC-Unique: gliD07t_PCyrtWRxqvaEDw-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-563f8cf9f56so389439a12.1 for ; Fri, 23 Feb 2024 07:04:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708700687; x=1709305487; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iMO3MnEoqkGGMfR5qCARB8BwTEcfu+rCmzwC1hIJkBM=; b=B5/PcKOfSVdN+bZ0+TQp3u2dxZ1PTCcJay+KjGLzpbzW3PBK/TS2kwA52+aigrqlTW 95m7DsOZ41HDr6Ak5+0Ne6SWwa2P29mmwvcnGQvI6vFkuuTcTTxv7EIyvgD5JqSiPVRk /MDtmp3/ZDIwNnZJPPRrIiRfeFDesT3N/7lYExQcVcxp2WPUdElkkdgQuSfQWc8v4+r6 Gy/Ib2xC7oyGyELcDhGkXWZZlXIj0DTSI7vUnxPcFzv94qgaWroagRiPRyS6cJGwq5cs YY9Ndd1rSLhaFiki88r3MybmGjt//28urCEw54IGdN9sTUDkc1PPjrU1FEr+hMS/kr9Z 4wMw== X-Gm-Message-State: AOJu0YwY9Q60w/gxFOdGX8FZQZD1uKVy196GM3U3t5jw2L1LyJ6y2+KF 8ZP6WCdDCIPRSKlQLZmsr/zz5Cnkc8uai3f9BsOr5ByupQVbyQO4yPHdx+buNTJhFQ49nw3dO8Q eNMqFbR9/CM8ZwKOVjSAPOqtz8SGHYU4+ZZO/Vwwb43/HAFpz0V+APreg7jB4eA== X-Received: by 2002:aa7:c0da:0:b0:563:c54e:f7 with SMTP id j26-20020aa7c0da000000b00563c54e00f7mr87976edp.17.1708700687401; Fri, 23 Feb 2024 07:04:47 -0800 (PST) X-Received: by 2002:aa7:c0da:0:b0:563:c54e:f7 with SMTP id j26-20020aa7c0da000000b00563c54e00f7mr87960edp.17.1708700687195; Fri, 23 Feb 2024 07:04:47 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id e26-20020a50d4da000000b00564024b7845sm6944716edj.38.2024.02.23.07.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 07:04:46 -0800 (PST) Message-ID: <14430905-c4ed-4e88-ae88-c2d76228935d@redhat.com> Date: Fri, 23 Feb 2024 16:04:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] KVM: SEV: fix compat ABI for KVM_MEMORY_ENCRYPT_OP Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, michael.roth@amd.com, aik@amd.com References: <20240223104009.632194-1-pbonzini@redhat.com> <20240223104009.632194-2-pbonzini@redhat.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/24 15:20, Sean Christopherson wrote: > On Fri, Feb 23, 2024, Paolo Bonzini wrote: >> The data structs for KVM_MEMORY_ENCRYPT_OP have different sizes for 32- and 64-bit >> kernels, but they do not make any attempt to convert from one ABI to the other. >> Fix this by adding the appropriate padding. > Maybe call out that SEV+ is 64-bit only, so this doesn't matter in practice? Or > does this affect .compat_ioctl()? Yes, .compat_ioctl() is what I had in mind - but that means I have to change "32- and 64-bit kernels" to "... userspace". Paolo