Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp918841rbd; Fri, 23 Feb 2024 07:32:48 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUbUH4Ngy2JpZ5qj5DJ5YvHdZBb/+dHuMfqC2/+lH62yo7H9K1QwGwKxJHsIdQkNrWnEa2xJ85UpQHr0VznoNMOYPqxl/io77PxGRThjw== X-Google-Smtp-Source: AGHT+IG/lLPJuC1N6VbRwIEkZDODu4rUBRl3DWZ6HdVa4v8cPglIUrH8GHPsDii6kQc6nM+41tKE X-Received: by 2002:a17:906:750:b0:a3f:7fac:6cd2 with SMTP id z16-20020a170906075000b00a3f7fac6cd2mr90492ejb.43.1708702368439; Fri, 23 Feb 2024 07:32:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702368; cv=pass; d=google.com; s=arc-20160816; b=GeFyXZu6zrHRug0N67WWCC3WW4Q1jbsS+Du4Mr6gBTzBQqa0F9J+gJ+NPC/aIv/1Ts 6d6fpSxJ+sjLWwbKsm5f1yr5svwvh9LhdlKlndArcXj2fiqK452DTuybJBbJMOsWWI6n cNjrVmtXbrFEX2EUQEI4KNw35oRTzadsLj/epCn6UJUoZcgi9ietq6m+jyMhMemTq8Xw HeKVoFkMzYgXTbcJaXJgly0alBxDe872net0hSTiA/hgWMZ5tZSTNUEhp1qz23vwgIP0 dwkjF/dMnjg4kSBx308s8tZnKhvE20HUJNZjRaeSfsc8l56w5/Wn4E3e1SojApZ7iOP6 u8FA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:in-reply-to:content-transfer-encoding :content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:message-id:subject:cc:to:from:date; bh=bw29ITqhOc5CeCA/jH5jxWpEfOX2iQUtCJTOD5NXUhg=; fh=yiyFcsuIxPvkzMPAOZEquswe3oB9YmcV5jpOgLtC3HM=; b=BOJjFkMtKOHNLAamW0goazotP7mIWWlXaz/e291yexmcwBWThBbs6ozkAUlumUQ2a7 6R+AtTBRbaOe+GbG/qwiGT0aYMQ2n8+qmHCCkeDW6CICHOQ2Hy/py51qGw2YyoWRAG2m iZX9frZO3za5BmblEhg9fHfh7ZXxAzYYiBPm1a/6wXDKRCcX970+6tdj8+F+Z40nMaBH I7CLNq+MUiQ750/1sBAQZ5qD+SGAclsc1/tlCvfOZymG/+oOhmKwCNI1TQzyPL41UeHd XD8NwDKrvg+kGoygoFdOJ8OynBigdDKzPFzr+/t+JtLF3Vq8MlYRbazvldCrLZ60OzWz uRhg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=CoCNqIXM; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-78613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78613-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i1-20020a1709061cc100b00a3d75c1e819si317215ejh.307.2024.02.23.07.32.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:32:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=CoCNqIXM; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-78613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78613-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 20F1E1F2582C for ; Fri, 23 Feb 2024 15:32:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 41F9282880; Fri, 23 Feb 2024 15:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="CoCNqIXM" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE8846FD1; Fri, 23 Feb 2024 15:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708702360; cv=none; b=P/tszB+YSAVYV0Q786wMm6QgQkk91Iue2wQh4CfyR9/RhcNXCbZ37dkeaE14SgQvxGOGbvh0JMvPvLQY+MIMxTYO7+KmeLyc7fHKzgDxVSEBhjTFx0pwf1cySyeo4++cDcU0CrYf7r1KfTX+/GP/HXyP4iHl2TpDyIfdCfgW37s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708702360; c=relaxed/simple; bh=QwhJ/EhbFImaRF3xYH27wlph7G0Hv+gUoIttDJYn92g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rB67kS9OS6SChFk3PIG8ZLKHK0uVXvna7aGJ7TLvsVND8LPci2xiCkrSGHObZzulu3TmyMnJqsSQbEhsWDR7W6CpOlVd1uAj+6EspQhIOqn9CAS8KK/J0K0YIxUbMKOanMy+M4ZkybLtX5QPg+PY/AXEg11g61GOowbVtdHgz0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=CoCNqIXM; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 03147473D0; Fri, 23 Feb 2024 15:32:36 +0000 (UTC) Date: Fri, 23 Feb 2024 10:32:34 -0500 From: Aren To: Lee Jones Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland Subject: Re: (subset) [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Message-ID: References: <20240206185400.596979-1-aren@peacevolution.org> <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> <20240223103537.GA1585387@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240223103537.GA1585387@google.com> X-Spamd-Bar: / Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1708702357; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=bw29ITqhOc5CeCA/jH5jxWpEfOX2iQUtCJTOD5NXUhg=; b=CoCNqIXMagBCAcmjTHXGXkYAtAh0zjlljpz2ecGOWTzDEXfRdy9XzNeENx/jrVfOFS/3Uh Bh9wbkJxKqXrTaacPJkPRP6DnmA9E3X0/t9Dizc79YsRX84jJVg8KlnStpJ2ArEIZL8uq7 siR4+baxF5E9ExTBYG/xrQJ6/pD4y9s= On Fri, Feb 23, 2024 at 10:35:37AM +0000, Lee Jones wrote: > On Fri, 23 Feb 2024, Lee Jones wrote: > > > On Tue, 06 Feb 2024 13:13:17 -0500, Aren Moynihan wrote: > > > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we > > > shouldn't need to set it here. This makes it possible to use multicolor > > > groups with gpio leds that enable retain-state-suspended in the device > > > tree. > > > > > > > > > > Applied, thanks! > > > > [1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend > > commit: 68552911e71d59e62dd5e50e9ac56ebfc32f0c71 > > Note that I changed a bunch of grammatical issues. > > led => LED > gpio => GPIO > > Capitalised the first word of the comment, etc. Awesome, thank you - Aren > -- > Lee Jones [李琼斯]