Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp930016rbd; Fri, 23 Feb 2024 07:54:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUJVuKgrWw4RiG498PLs13e1VnhU9zMuEzrTLnIi2tlzDzA7Ln1/Ols1rX0fM7H/egZug2Jel3if0z3f8f+/e0/3X++I1knAIcr+uiCIw== X-Google-Smtp-Source: AGHT+IFGh86UjI7ZcHQfN/NRa3wHzHjHl1Tq0bCetfeP1L2tLrdGFHchCmswATgPMlbAWHZUAs4Q X-Received: by 2002:a05:6a21:2d8e:b0:19e:bf18:61fe with SMTP id ty14-20020a056a212d8e00b0019ebf1861femr380678pzb.11.1708703645662; Fri, 23 Feb 2024 07:54:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708703645; cv=pass; d=google.com; s=arc-20160816; b=tEFkjhWaYf03kRwNgNLfZOQHglDCa0Auhx7PpakygVpnKpQys3iL+ptIBJxHjXlumQ 6w0PbY0L+4P06aLMP54xC85J1IRxshLahUDJtdTBlGNS5JmM52eBxyi1uY82VQUMbDzT Eu/V85aCpmRmCIA633nS2AJ2tzOTA+3ig9bQoykdqfqgrv+0ssoz2UjMktkO+RWXyp8o 4wpNT15+7M1wRzsE6r3QELh54D2sz9ivUAWWyt2/AkOV0jzWg+OUN2rz0cy+s9CpiJHg DB+ZkGRN20aokqj9f3yhNWjxWYlElMjD/ArVqD9I93nIEoeZ6DCMzFdexqW7CVvQ9k1T c9+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=hhaNQ+bD0Oc7wvlbvtAll3AW5eFq8pxExInsRYT/5hs=; fh=gV2gpYWdfLOBnaENVzN29SsueCr1TP/k6UxtovrTeFM=; b=M5NxG34L9hH0gpfQaCLXE7ud/KKYdU1Hry36tu87+SU3RwdKTOv2EzS8M9LI6fKKOc NFG8C3EPCOQqIBVXMxPhPkZAY1YW0UwSjioXnOg9yChNnp9vtmfHfWVrKoTy9VDBAcBM onArQYFLTyA4kbPh572Seoj5u6q9LOfAEsCaYMV6JGidwr4+2eooMwQbUN2kiAyyMxu1 P9FfuGfMdjoWHzaTQ2dD1/zDzj0OMvXp0Vpbyv7/fJ+prDBGRKxwhdfRQL58pDUYo0/v J8TeCQtnYUXjxuU5OWYgWF+tHtaiuMWHYOfonl23eRuIYlfBzpS86KWp/qbubA0px6zv VGPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d88bnypk; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-78644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a62-20020a639041000000b005dbd83521fasi12088912pge.883.2024.02.23.07.54.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:54:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d88bnypk; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-78644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 47D44287E4C for ; Fri, 23 Feb 2024 15:54:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED4EB84A3A; Fri, 23 Feb 2024 15:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d88bnypk" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B95D682C7E; Fri, 23 Feb 2024 15:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708703574; cv=none; b=HOk3afdDiquZcIYsxOXpHp+TXxqpkSUdlsTglDEWDT6WSnlpM+hNnVV2XC/HL8t8wvrj5dZP9iZqdLP4EUj/vrqY9L/17eIBZHX56n3f7jqPjRKRjy0hWHkGtGawC2sVrXZ76x6dWexCoGCzG8ohM5ycORIvFF/KQZ1FqZhwX14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708703574; c=relaxed/simple; bh=6vqPUhZkl0WfTqOLmqR/FWKhYBKPjdvFKKD29rNeGoA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GgErpaYXIXeb5ZMW2yrFy0no/oRCsNd6GMmu99EPSzsFj0FgSlwHchbOW9vWwQm5nXzrnQpcPRxAlgo9wmyYW8t6Ux8NkSfilLTHLYwok6ilRFFBQCqn+is3KYwQ2ufoiU2DSw3Bsd6/LdQxXwLU7i3YlGwbBxF+S6wchQdht8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=d88bnypk; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708703573; x=1740239573; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6vqPUhZkl0WfTqOLmqR/FWKhYBKPjdvFKKD29rNeGoA=; b=d88bnypkjV7rdDuF9EEllR5CLp9Ohf/eUBBpdHSPTtJxT3UCFVIn32GS Eic/2hDTMsew8LSoEnh1itfnW4hx2WAfEttS1Z1L8lp/oSlL8+dHFKtta XTA6u+FbmfDTxxtg18y75oGS58UyQbApy26oavxlKUUh95bSdfV7st651 gIkjGoDc3nZsR2W2V0xJOz8uIUASRylX0Lgd2T/bS1ggKa/EwNTt6S5bZ E95tSDDWWAivAuDMv7EBRnEDEvIElqGm1KGa9pSH/zlXVo5VfGX/dXNKE 08/lVyHxc32aO1s0fxNWztUub8L6qtLbkWP55oZ5CFOWTKuJxLFwYx7Pd Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="20564410" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="20564410" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 07:52:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="913749612" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="913749612" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 07:52:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rdXqw-00000006wMT-4AQU; Fri, 23 Feb 2024 17:52:46 +0200 Date: Fri, 23 Feb 2024 17:52:46 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Rob Herring , Frank Rowand , linux-kernel@vger.kernel.org, Julia Lawall , Peter Zijlstra , Greg Kroah-Hartman , marek.vasut@gmail.com Subject: Re: [PATCH v2 0/4] of: automate of_node_put() - new approach to loops. Message-ID: References: <20240223124432.26443-1-Jonathan.Cameron@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223124432.26443-1-Jonathan.Cameron@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Feb 23, 2024 at 12:44:28PM +0000, Jonathan Cameron wrote: > The equivalent device_for_each_child_node_scoped() series for > fwnode will be queued up in IIO for the merge window shortly as > it has gathered sufficient tags. Hopefully the precdent set there > for the approach will reassure people that instantiating the > child variable inside the macro definition is the best approach. > https://lore.kernel.org/linux-iio/20240217164249.921878-1-jic23@kernel.org/ > > v2: Andy suggested most of the original converted set should move to > generic fwnode / property.h handling. Within IIO that was > a reasonable observation given we've been trying to move away from > firmware specific handling for some time. Patches making that change > to appropriate drivers posted. > As we discussed there are cases which are not suitable for such > conversion and this infrastructure still provides clear benefits > for them. > iio: adc: rcar-gyroadc: use for_each_available_child_node_scoped() Is this the only one so far? Or do we have more outside of IIO? I'm fine with the code if OF maintainers think it's useful. My concern is to make as many as possible drivers to be converted to use fwnode instead of OF one. -- With Best Regards, Andy Shevchenko