Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp943627rbd; Fri, 23 Feb 2024 08:13:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVZnC3s7ARtbv/1RMqAqTzx6iO16RU53LPbAeh+CfvJ+opI9nVZQ5qrMMKoXIMA6Tm7x7MWVU1WrlY8/+Z+dipD6Wp/4iMCVuPe6LJ/ZA== X-Google-Smtp-Source: AGHT+IGGUIUD4APVL6gXP5ZqPBeHJBJhP00Jpy+n3u+tnzS0ZdOsXaFVuCF8r14f/yjiZoIIMpR5 X-Received: by 2002:a05:6a00:2d18:b0:6e4:e281:e243 with SMTP id fa24-20020a056a002d1800b006e4e281e243mr276508pfb.3.1708704834285; Fri, 23 Feb 2024 08:13:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708704834; cv=pass; d=google.com; s=arc-20160816; b=bg6hFPyRzoHFR21wcYHQaa+6El9xAbqbRFb6tJgITwu0GlEPP6RvrDD3iJobxDY/PH 7h/dDhvCrdT02fmY9v3TbYyoV75XbeGm+R6XqIlCdoFtyV5PNyExXjVIfj6KIGhocSxs Dw3o6nrp5k/+aedxND6nK6QtNJ3Rxp2yk/F0wUAcu1p7x+HXKZbE6+sMQ9uH40YzELDY h2rccr/hOYWzyi+yrLKkf9XNgBcc47jpf8+Xgggdh4FC/V9H9ptpsi0ogSmurRumqEff XtaLBIt7hb6W0Dn94pA0HJ3+GUFE7w3MJZ8EbzvYHZWh/5teJJhcHaRXcwwrW9VemJa2 5XbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=pmZavK3JjZYVH2Ejq7HV63jkntuNeJyObPKt57zG6+Y=; fh=AqebsWy3Z2JwgzjlMugDGN6nCAqpd4meHZ1eUzCjziw=; b=ShQFH9ez+/8XVltU3YyX8JcPpSe74h23SBzYlw3g0wc5ojsqiC/eBgRNhz/Pu0r8F3 zY04E7tJhpC9aPop0POFes1kEBR+8tQGTFfdfeldKUqpupzb0/O8ooRFh8PLzBZ53h2c vRkRbhR2RwH4xkoNeUfLMSNUFRnW/H5GIiHikceo7Wz8zayCt0XLGkHYmx3KnXX2vhL0 KXA5eXfvlJ/l8IScBggEOPmWMVSAh3fxrQq3M+dODhdQfXlRoYfUXeek41+ssCxxjbsB miG25kGjFQeBq5jemqrme046iwBzaQoLLrQOLiLMsZPM4QvuZRpy5mpl0JJn+0UtNGbu P8FQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h9Yi6KBM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78662-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78662-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id dr4-20020a056a020fc400b005dc6576d8adsi12260507pgb.386.2024.02.23.08.13.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 08:13:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78662-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h9Yi6KBM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78662-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78662-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8C5BCB24F05 for ; Fri, 23 Feb 2024 16:02:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4171783CA6; Fri, 23 Feb 2024 16:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h9Yi6KBM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3252232D for ; Fri, 23 Feb 2024 16:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708704157; cv=none; b=HNItIaJ2ctzoHsNpZLHle7XgacnB8MVUqRSFOsvq/F5w8syPzN3qxoLifvxsSpzWCtLfFtbRhDg//xIRRz3+bOshu6ioQX0uCDZeg+yV7kyQ4iczSOoCJdyMNcgo2hJ+OrAvWVFyfYsYvJZtj3y9hopNCYK5ePMMySm8TU+Dd1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708704157; c=relaxed/simple; bh=yFqxB5RB3u/RLZEPPk/vFtxcGh+SHxSeLpf9kehgx0M=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=IE+6jJyL9PASJvIFgI8AyTO2WgQKmF8GL4QuxiPRHk3YgybIRnjQ87gLa6ShY6VH6OmyoiSRdpTPqgo//y9LdS375m6ZXitvyMmOwMAkBq67tkGRBuS4gYEP+E9teD6/qMy3qAoaokVTZwqV4Iy/j4MM6sl8vMcGJNHiLXN29ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h9Yi6KBM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E8DC43399; Fri, 23 Feb 2024 16:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708704156; bh=yFqxB5RB3u/RLZEPPk/vFtxcGh+SHxSeLpf9kehgx0M=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=h9Yi6KBM+bfe1twyM83dVvJBJsIs1/WJF5ZDS0+AH/1r/O92tPkdd6R+KUbqwWciZ 9HCPsMnwXHhrlhHH7O8lEM7Gy+zMPepf8Sk0yMYwePgXoCHLEvc7Xdg3xYtXUrtji7 NN1MeT97AwvVNt8quniGl604q6aVHGi5huUFOYM8BR8eOh0+IVA2tcoxH8m8Imu78d gwGl3Zy+xneeeeajPhG4lbFSHFAtpfKy13l3Z4egvTqXgvcwkkHRoV9BruUM+xe3kk PRy6wZruwtFuRZD3lKLPXAWrPV0fS0VlkZimKfkuib1Ih7fZN5s5vnPAASKx1FM4Cn RmhwBVUu2RoJg== From: Lee Jones To: arnd@arndb.de, lee@kernel.org, thor.thayer@linux.intel.com, Peter Griffin Cc: kernel-team@android.com, krzysztof.kozlowski@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pankaj.dubey@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com In-Reply-To: <20240220115012.471689-1-peter.griffin@linaro.org> References: <20240220115012.471689-1-peter.griffin@linaro.org> Subject: Re: [PATCH 0/3] mfd syscon and altera-sysmgr cleanup Message-Id: <170870415412.1726445.3923431976204064450.b4-ty@kernel.org> Date: Fri, 23 Feb 2024 16:02:34 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.4 On Tue, 20 Feb 2024 11:50:09 +0000, Peter Griffin wrote: > Whilst implementing a driver similar to altera-sysmgr for exynos > it was noticed during the review feedback that we should only call > of_node_put() if the property is provided otherwise nothing has > taken a reference on the node. Both syscon and altera-sysmgr also > have the same issue which this series fixes. > > Another piece of review feedback was not to use extern keyword in > the header file, so I also cleaned that up whilst being here. > > [...] Applied, thanks! [1/3] mfd: syscon: call of_node_put() only when of_parse_phandle() takes a ref commit: d2b0680cf3b05490b579e71b0df6e07451977745 [2/3] mfd: syscon: remove extern from function prototypes commit: 0db017f8edd9b9af818bc1d68ba578df1b4c4628 [3/3] mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle() takes a ref commit: e28c28a34ee9fa2ea671a20e5e7064e6220d55e7 -- Lee Jones [李琼斯]