Received-SPF: pass (google.com: domain of linux-kernel+bounces-78709-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 23 Feb 2024 16:20:42 +0000
From: Lee Jones <lee@kernel.org>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	ChiYuan Huang <cy_huang@richtek.com>,
	=?iso-8859-1?Q?Andr=E9?= Apitzsch <git@apitzsch.eu>,
	Alice Chen <alice_chen@richtek.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	ChiaEn Wu <chiaen_wu@richtek.com>, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver
Message-ID: <20240223162042.GJ1666215@google.com>
References: <20240203175910.301099-1-alkuor@gmail.com>
 <20240203175910.301099-2-alkuor@gmail.com>
 <20240208130115.GM689448@google.com>
 <Zci9xE5uHRJGMg5q@primary>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Zci9xE5uHRJGMg5q@primary>

On Sun, 11 Feb 2024, Abdel Alkuor wrote:

> On Thu, Feb 08, 2024 at 01:01:15PM +0000, Lee Jones wrote:
> > On Sat, 03 Feb 2024, Abdel Alkuor wrote:
> >
> Hi Lee,
> 
> Please check the inline comment. All other comments will be addressed
> in v2.
> 
> > > +What:		/sys/class/leds/<led>/dim_step
> > 
> > The step principle seems a bit arbitrary.
> > 
> > Why not provide the time directly?
> > 
> > dim_step_delay?
> > 
> > I already see documentation for risetime and falltime.
> > 
> > Perhaps that will omit the need for both direction and step?
> >
> I'm going to drop off both and use risetime and falltime. That being
> said, the documented risetime and falltime for lm3533 use steps instead of
> entering the time directly. This is my first time doing this, should I document
> risetime/falltime in sysfs-class-led-multicolor-driver-ncp5623? or should
> I update risetime/falltime in sysfs-class-led-driver-lm3533 to reflect
> risetime/falltime for ncp5623?

Keep them separate please.

> > > +Date:		Feb 2024
> > > +KernelVersion:	6.8
> > > +Contact:	Abdel Alkuor <alkuor@gmail.com>
> > > +Description:
> > > +		Set gradual dimming time.
> > > +
> > > +		==== ======== ==== ======== ==== ========
> > > +		Step Time(ms) Step Time(ms) Step Time(ms)
> > > +		0     0       11   88       22   176
> > > +		1     8       12   96       23   184
> > > +		2     16      13   104      24   192
> > > +		3     24      14   112      25   200
> > > +		4     32      15   120      26   208
> > > +		5     40      16   128      27   216
> > > +		6     48      17   136      28   224
> > > +		7     56      18   144      29   232
> > > +		8     64      19   152      30   240
> > > +		9     72      20   160      31   248
> > > +		10    80      21   168
> > > +		==== ======== ==== ======== ==== ========
> 
> Thanks,
> Abdel

-- 
Lee Jones [李琼斯]