Received-SPF: pass (google.com: domain of linux-kernel+bounces-78679-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clkdev: Update clkdev id usage to allow for longer names
Thread-Topic: [PATCH] clkdev: Update clkdev id usage to allow for longer names
Thread-Index: AQHaZmNNwGKZ+qsDt0uuHOIigoDEFrEYEqkAgAAEZaA=
Date: Fri, 23 Feb 2024 16:09:03 +0000
Message-ID: <DS0PR11MB64245B3F3AB02C32B53F3F64C1552@DS0PR11MB6424.namprd11.prod.outlook.com>
References: <20240223141857.3794855-1-michael.j.ruhl@intel.com>
 <Zdi-QnkPYUFWLJIe@smile.fi.intel.com>
In-Reply-To: <Zdi-QnkPYUFWLJIe@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ppmjLnD1pR1OppVC9G/C4nq3jBkBsU5G/+uyurifBLseCmVwBeAwaK/2zd8K?=
 =?us-ascii?Q?fy/7lXkxmzJ1bHDmQfOxmfWfe0LGGSIDoz4x0NQ6AOmu4VmvqKU3e2kQ+lue?=
 =?us-ascii?Q?f5GyIWy96r8P4/lS096rEumtqDMJWmyJR2bnou6ADRXbFl4k6OI+UjaqsjQf?=
 =?us-ascii?Q?c1ruRa+1r6XpVUjCvlR8hMeP5y87brSCUDHIuSnqTdSBSd2d7+yxUEg6Kh7e?=
 =?us-ascii?Q?6cU1Qpv3IjfU3nVL539t881GK1JnkqWNZVUbzacCft21XrG15G1pnQar6Cew?=
 =?us-ascii?Q?0jfNCu8lYnPifpAJr/xRJSflilYDvoEVsiFa4eDHz/3BtEeo5OJARy6sMgKk?=
 =?us-ascii?Q?WBnmsKuphOoWTlt6OTyWzent0ZylOEUrNZFNzZHKJIvbreN0vZmaIiTqg0Nq?=
 =?us-ascii?Q?qbboTrfclOoX+HprI1JRO4jVC361NjtJxEUNjsTg3ysDW0Nb0ExyupWoUTry?=
 =?us-ascii?Q?W6RwjIVnJ99Va7Sr/6SRhqoHrv/Q87PgDCsYObFYoPmV64mDxxxO/8Eg8E7d?=
 =?us-ascii?Q?sDeOZm3m9nMPigpXUj5YbX3Xx43S/GQHFA/5eIDX16ClKrP/mbe+Oh/B1bTq?=
 =?us-ascii?Q?hJ5zW+zEjy92/PUFJNFg8IKcRWzEh2YnLRBMmUdZVNEN4yia6Q1JWuIq9XZD?=
 =?us-ascii?Q?CvWXJ7l6aP4KmtPUs5uagowxEBv7dB02PaM8MYisyVkrgE93SwpFLO0AD750?=
 =?us-ascii?Q?PDqMfQ+EUPAyYRHnzOa8f33qRdy6uRTjo1cIU8+uvhlzcqbWRuUVLa5qTtHB?=
 =?us-ascii?Q?BLny4Jftbh6cYlbDgn19m/29lL2kC8tILTMx7JDA3ymwJMyvEmH1tZdjFuHo?=
 =?us-ascii?Q?G4neN/vIISUKm2ZcRemqoahxq30GPx1YlhpU2Prv/m/cghfxh8R+aAmwXVy1?=
 =?us-ascii?Q?PFx0fpPoUoKBAQoe+3eGuceZNtF2bgA+yIZKTsnnOEihTsr3iNoqEXVQTJQY?=
 =?us-ascii?Q?mrj0OYksbWtyEF/mHFQufqJ+jvaf5xaO2K6of2hJ4ofZpW+QKVXpoPa+zA+t?=
 =?us-ascii?Q?IXVI0hUe41Jg8kaZItXiur1h0n01LYFrmm/PLY5/07WyANb+kNYrMLnIkl4j?=
 =?us-ascii?Q?DvEnP6JcGJRROTPPwSp+7uSjiKQJ3N4Dh+50JZy9jXushaShB11Hmfy+kHXB?=
 =?us-ascii?Q?cQ0+SXEqNSt4pKQAR+wcxz0rfygDiAsPT8MJY/7zNdGcgqxC5fuorF+kWx2b?=
 =?us-ascii?Q?Wd7gN5h/XuY1pRYERsOg2hvOFl4cI4knWbrD9UoOxMjxguKHn6CWaXEcrj3z?=
 =?us-ascii?Q?FQ8LS/oPMEPLMSF3O3eaMqOZC6PKHsLfUf1//eXBKIaEkBtmIgopfYq4IO01?=
 =?us-ascii?Q?Al6wRkY5yp6xVRwx4BwEGBRnMfSxiP9E2DS8hjQBOzYP7Ay41VsHJFFSJufr?=
 =?us-ascii?Q?uSf2ffel43UlWbKAzwQPcTI29LooW0wPHm9W68fqifZjtanwEPZaUehLHbSC?=
 =?us-ascii?Q?tfZfs7qXRMi/6L7DL7JXODB+nZ7PK/cZNSwK0G7Ys+OjHkAC0IovnYNF2vrF?=
 =?us-ascii?Q?fvw1qH0Tq+suwM7h/JvtDTbpoa4IJdDU+TKEUMqo7RE5gj/EpZ/MxSg5LOfB?=
 =?us-ascii?Q?seL9wo1D9l1IkZRgZ1G29tpW8P4fdBtMJfPlSa7W?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6424.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7f59876-06da-47d4-8e26-08dc3489c118
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 16:09:03.4353
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w28Eh4Tw76c4zopo+k/TBCdJkp4yEGQKBBDMHoTQXsbhpZid+TagiwdHXDHvJjjS9X+W6+QqqTdHEO5UmaiKJwF3gEMVtw2rnSxOVs2Oy/g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8163
X-OriginatorOrg: intel.com

>-----Original Message-----
>From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>Sent: Friday, February 23, 2024 10:48 AM
>To: Ruhl, Michael J <michael.j.ruhl@intel.com>
>Cc: linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-
>kernel@vger.kernel.org
>Subject: Re: [PATCH] clkdev: Update clkdev id usage to allow for longer na=
mes
>
>On Fri, Feb 23, 2024 at 09:18:14AM -0500, Michael J. Ruhl wrote:
>> clkdev ID information is limited to arrays of 20 and 16 bytes
>> (MAX_DEV_ID/MAX_CON_ID).  It is possible that the IDs could be
>> longer that.  If so, the lookup will fail because the "real ID"
>> will not match the copied value.
>
>Perhaps you need to add a real example.

How about:

Generating a device name for the I2C Designware module using the PCI
ID can result in a name of:

i2c_designware.39424

clkdev_create will store:

i2c_designware.3942

The stored name is one off and will not match correctly during probe.

>> Increase the size of the IDs to allow for longer names.
>
>...
>
>> -#define MAX_DEV_ID	20
>> -#define MAX_CON_ID	16
>> +#define MAX_DEV_ID	32
>> +#define MAX_CON_ID	32
>
>Do we need to alter both?

It wasn't clear to why there was a difference in sizes.  At the moment the =
CON_ID isn't
causing me an issue.  Shall I drop that part of the change?

Thanks!

Mike

>--
>With Best Regards,
>Andy Shevchenko
>