Received-SPF: pass (google.com: domain of linux-kernel+bounces-78738-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: Aren <aren@peacevolution.org>
Cc: linux-kernel@vger.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
 Jean-Jacques Hiblot <jjhiblot@traphandler.com>, Chen-Yu Tsai <wens@csie.org>,
 Ondrej Jirman <megi@xff.cz>, linux-sunxi@lists.linux.dev,
 Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org,
 Conor Dooley <conor+dt@kernel.org>, Miles Alan <m@milesalan.com>,
 Samuel Holland <samuel@sholland.org>
Subject:
 Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to
 status
Date: Fri, 23 Feb 2024 17:36:42 +0100
Message-ID: <4545459.LvFx2qVVIh@jernej-laptop>
In-Reply-To: <n5rmhx7ez7xoqainjqxpdk47e3bw2pvtsgswofnhjdxtrk72j2@debhbdxsxz4m>
References:
 <20240206185400.596979-1-aren@peacevolution.org>
 <2792937.BEx9A2HvPv@jernej-laptop>
 <n5rmhx7ez7xoqainjqxpdk47e3bw2pvtsgswofnhjdxtrk72j2@debhbdxsxz4m>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Dne petek, 23. februar 2024 ob 17:30:00 CET je Aren napisal(a):
> On Thu, Feb 22, 2024 at 09:57:00PM +0100, Jernej =C5=A0krabec wrote:
> > Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a):
> > > The status function is described in the documentation as being a rgb =
led
> > > used for system notifications on phones[1][2]. This is exactly what t=
his
> > > led is used for on the PinePhone, so using status is probably more
> > > accurate than indicator.
> > >=20
> > > 1: Documentation/leds/well-known-leds.txt
> > > 2: include/dt-bindings/leds/common.h
> > >=20
> > > Signed-off-by: Aren Moynihan <aren@peacevolution.org>
> >=20
> > Sorry for late review.
> >=20
> > Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:"
> > use "allwinner: pinephone:" (check commit history of sun50i-a64-pinepho=
ne.dtsi).
> > Also rgb -> RGB, led -> LED. Last, please reword commit message to excl=
ude
> > links and just say DT bindings documentation.
> >=20
> > Note that I'll merge patches 2-3 once patch 1 is merged.
>=20
> Would you like me to reword and resend the patches, or is it quicker
> for you to just do it when you apply them?

Since Ond=C5=99ej raised concerns, let's finish that discussion first. It's=
 possible
that this patch will be rejected. That would also mean new revision of patc=
hes.

Sadly, this means DT patches will miss v6.9 window.

Best regards,
Jernej

>=20
> Thanks for taking a look at this,
>  - Aren
>=20
> > Best regards,
> > Jernej
> >=20
> > > ---
> > > I can't find any documentation describing the indicator function, so
> > > it's definitely less specific than status, but besides that I'm not s=
ure
> > > how it compares. Please ignore this patch if it's not useful.
> > >=20
> > > (no changes since v1)
> > >=20
> > >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi =
b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > > index e53e0d4579a7..6d327266e6cc 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > > @@ -61,7 +61,7 @@ led2: led-2 {
> > >  	multi-led {
> > >  		compatible =3D "leds-group-multicolor";
> > >  		color =3D <LED_COLOR_ID_RGB>;
> > > -		function =3D LED_FUNCTION_INDICATOR;
> > > +		function =3D LED_FUNCTION_STATUS;
> > >  		leds =3D <&led0>, <&led1>, <&led2>;
> > >  	};
> > > =20
> > >=20
> >=20
> >=20
> >=20
> >=20
>=20