Received-SPF: pass (google.com: domain of linux-kernel+bounces-78757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 23 Feb 2024 16:47:29 +0000
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v2 6/6] ASoC: cs-amp-lib: Add KUnit test for calibration
 helpers
Message-ID: <ZdjMIVYp7Qb/Tt9d@finisterre.sirena.org.uk>
References: <20240223153910.2063698-1-rf@opensource.cirrus.com>
 <20240223153910.2063698-7-rf@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+NiID9uOcNnKcD/H"
Content-Disposition: inline
In-Reply-To: <20240223153910.2063698-7-rf@opensource.cirrus.com>


--+NiID9uOcNnKcD/H
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 23, 2024 at 03:39:10PM +0000, Richard Fitzgerald wrote:

> +config SND_SOC_CS_AMP_LIB_TEST
> +	tristate "KUnit test for Cirrus Logic cs-amp-lib"
> +	depends on ACPI || COMPILE_TEST || KUNIT

Should this not depend unconditionally on KUNIT rather than KUNIT or
some other stuff?  ie

	depends on ACPI || COMPILE_TEST
	depends on KUNIT

or equivalent.

> +#define TYPESAFE_ACTIVATE_STATIC_STUB_PTR(test, fn_ptr, replacement_fn)		\
> +	do {									\
> +		typecheck_fn(typeof(fn_ptr), replacement_fn);			\
> +		__kunit_activate_static_stub(test, fn_ptr, replacement_fn);	\
> +	} while (0)

Should this be somewhere more generic in the kunit headers?

--+NiID9uOcNnKcD/H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXYzCAACgkQJNaLcl1U
h9AdaAf/Vs9JrSrEhXziKNX6iqehN1Sj3RcplxRM30tl9i3P1mw5PLxE07esKYUj
hHzcS+MzZt3Jo30134eXcbH4IwAQW5KwQoGlaAaqSmZq57heZrFmAkxYzyHjmO3Q
PYD4gmPiKY6suY1M8Hc2x+MbJzKGXLutlIUnUlyfZFJNRK9vuEUr1jdsfIOVd8AP
fjE6pUBRi79IKlNBDur55KdFgzt9q9J+x6uDWOz1GizJbNWrd8z9BjRcXJtVnLMY
xobl/4INIePPiblwq3X8d46UUez1xmo/XgoXEYKelQlt6E+dmGO90/cp3bokDUw5
Wl3swEjTyJThlczRmjZitXH7JqCUUw==
=uxPg
-----END PGP SIGNATURE-----

--+NiID9uOcNnKcD/H--