Received: by 2002:a05:7208:3188:b0:7e:5202:c8b4 with SMTP id r8csp965450rbd; Fri, 23 Feb 2024 08:53:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWNC+1dZSKYEQvJHXApxK8kWAGxSC76hyTBjmWu8zmvxn640fzWnqc1Q1yZTUyTBnBxoDFOUBVcM0lwSIvjUKy5W13zolrPKfeOhfk1WA== X-Google-Smtp-Source: AGHT+IHajCF7Q413eMA1XmevEWH8CBKRyadQSCSWx5EsyjErTNeXStHl0F5NDL4b35quUTDbL40r X-Received: by 2002:a05:6a21:3943:b0:19e:b89f:99ff with SMTP id ac3-20020a056a21394300b0019eb89f99ffmr530678pzc.3.1708707238587; Fri, 23 Feb 2024 08:53:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708707238; cv=pass; d=google.com; s=arc-20160816; b=wzIWNg4eOoXgB3GynRb1NHA8XhAxo+SsTwZYgTAl+th1ODK6v+ebNnezQ8X/I+tj46 0KJji1dv+MvUN1ArzJBH/ioWJDwrOjLJYyQH2xzI8by4dH1aneo4IXA8ONR7osyw76S0 ztR0xduVdWd32DkBcYz/g+7Kfys7GYn9H0bsdw+kwrY8D4gblcaNbpCQhkAVlLwY5hZZ ehKj0BVsdUjkvoz6CG5KuXfaQvMfkdsK+QTr4I4rnJc7uEONgOtAQxB4lUp4BWGkTsnl KKwKOxhsgwVaZQKkotk4Ic/U83ju7/iyYM4XpaXHiwmtFEbzyyiQXP7jTsOtqENK9+jR 2fOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=FdqnZts+4byFd771mgKEZg9Fw78xaTijWyacnd8VGSc=; fh=KvzLtcxzoujysk+zuAhilcvoux1y8u0bf1s0rlX7fd4=; b=rM0/helXxXOTt7GTgmHCIOF0oAs+Ma5M7G9JEy3TxWPScSYBzC7J6a9DaR9jLOKgmk aCZYgfP1khjg6YhFDvdtQZLdNqsQBwXloF7Oz+FzzvfCuowpcHBFNtc8WBefGzxDBta2 nVuISym1O6ESJQcVAzB5wuG+r6uxV8xmcLdIrh4N7Q5s4G1k1xvSjUromun3S9E9ynRF Yezgj2bPDLe/8G6/0jmpkGd6vhqXs78B91EqL1KeDhItbBBXFt+hVpXoGoqjwS3s88wd aC26GtK18KU+VIbe4ZnQLUEJ3Fo2heSk82LUOTyS6cLjdHz12ERT0NKBC+o1Ae7UFWPk vPhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fbwqVul3; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-78719-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78719-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id n29-20020a63721d000000b005dc529b2a4fsi12638899pgc.741.2024.02.23.08.53.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 08:53:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78719-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fbwqVul3; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-78719-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78719-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1DF85B224F1 for ; Fri, 23 Feb 2024 16:24:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BB0C8287B; Fri, 23 Feb 2024 16:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fbwqVul3" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AB1383A14 for ; Fri, 23 Feb 2024 16:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708705339; cv=none; b=q+M2tT+kIGfHh0277hI6aSWfJe6bjHGDSZ5jtmDP2HycsiFkXtGWmFZUzeAFLsetvHBKFuYdplHoOnKBvDfAyGCeXCrHrMAFNLC7/GaI3j+1jIt6ruoiX+8EVRvkpVSrQx7Bu05/AahksPpWR9XKGZfU9rgLxaK6gHA9PUZTEpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708705339; c=relaxed/simple; bh=N02SXe7v0jKPXuw1R4bdMRiaxqn894dw8wLXgFatKRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S3MN4piNiZYMJI4asqaHi35U2a+FgfpESdaeC2jGbfVaq0IKD15CbNQ9lrXc6ZtLCIXoAWzeOdW2HhS9zbhghkd28HYYuhdBwwTxvqqSb57el5DpPmHj2yQv8c8Pd1eaQDGedHflpdYfOrI1cCImvOrWBOyui9a6C4l5EHF4knM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fbwqVul3; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708705338; x=1740241338; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=N02SXe7v0jKPXuw1R4bdMRiaxqn894dw8wLXgFatKRY=; b=fbwqVul3DXj2NPiOpvDwLNT5RDmLfX+P2Zaw0UQfSGKZucU9l7assHF/ 5dWD0Y/V3fz6XY9CH5FcodERQvqwtfjiv1WwGS1dw/DnR1ZLocbq3ZJY7 aA4KpQ45VnLtjO1wABL1otszzLr8Yv6t7XYrS3lWlltIvJHgOILgkjSBQ 5hhXAStFIGamXpEs4KsGeNC7XAMzLQl4aqm+8nZOparPsX3PnA0R3QiL9 wTPABaxJ6TYYHXjSVgcPC16q3Gd40zEZ9dG6qssJkcZpbDFiGSTh34eER AqP0BgJmVa909/qhfkJJd6DbttOg4mcLWV55CyAy8WzuZaHvGPjKrbzdp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="14438640" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="14438640" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 08:22:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="43398198" Received: from gtkramer-mobl1.amr.corp.intel.com (HELO [10.209.82.163]) ([10.209.82.163]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 08:22:17 -0800 Message-ID: Date: Fri, 23 Feb 2024 08:22:16 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH 11/34] x86/cpu/intel: Prepare MKTME for "address configuration" infrastructure Content-Language: en-US To: "Kirill A. Shutemov" , Dave Hansen Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com, tglx@linutronix.de, x86@kernel.org, bp@alien8.de References: <20240222183926.517AFCD2@davehans-spike.ostc.intel.com> <20240222183941.7CB634A5@davehans-spike.ostc.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/23/24 03:33, Kirill A. Shutemov wrote: > On Thu, Feb 22, 2024 at 10:39:41AM -0800, Dave Hansen wrote: >> From: Dave Hansen >> >> Intel also does memory encryption and also fiddles with the physical >> address bits. This is currently called for *each* CPU, but practically >> only done on the boot CPU because of 'mktme_status'. >> >> Move it from the "each CPU" ->c_init() function to ->c_bsp_init() where >> the whole thing only gets called once ever. This also necessitates moving >> detect_tme() and its entourage around in the file. > The state machine around mktme_state doesn't make sense if we only call it > on boot CPU, so detect_tme() can be drastically simplified. I can do it on > top of the patchset. That would be great. Looking at it again, the (tme_activate != tme_activate_cpu0) block is total cruft now. It probably just needs to get moved to secondary CPU startup.