Received-SPF: pass (google.com: domain of linux-kernel+bounces-78741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Armin Wolf <W_Armin@gmx.de>
To: Shyam-sundar.S-k@amd.com,
	mika.westerberg@linux.intel.com
Cc: sathyanarayanan.kuppuswamy@linux.intel.com,
	hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base
Date: Fri, 23 Feb 2024 17:38:59 +0100
Message-Id: <20240223163901.13504-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:2aICjQ/9zTo=;MM8khOtZJ//pj63x0PsCKT0JlmC
 QWPXzZ/4ipsD84Q/qJLJ/3v0vvMNQgHjpx4UOWi3IZctxVHTJmhpkUNMvB5gYBYtehgBstN0c
 rDKa7dOhR1Fh/+c68RoiriFHleKmwx26cp9DAG7xlnyNRlbHz/bkqJ1k1Rvpxs4lq5Z2zpayg
 tfnfVNw6uOVmfPzb/xn4uVQxoJVJMmRHJrmRO6oIqMhWSKVDm/Zp5JMDqOB+WcccFvrUdtEzj
 TfMjAUSqO7kCrtL5Ngnv8fINP4UHo2/Viu4bg8XyzGM73wtV5Jv2cJgMJWs6e0uPnH+PcRRqs
 B0pIndmbs6dUGif2ECLVZ8bgEmpb5HeDoaC+eRdj8lF/+oJwdbrbzRlsbj/LVMZC0/ldeBjex
 2fSU4Ywri9rD+cINz68PcRW+6wWqC9kLCD4pDPtGfzu0r6mCQF+KkTbO4t87ZzfHKmvzcRK8R
 QoGkkZR+2W3wH0UTfKbfNlNOZ2QN71SgZpKzcfL5yC0LLD8yKAS8zPEVwrpfFDAgfIDKyz2Ru
 P6g/X9QhWSHTUbsHqHpS3rqEMHMLdqTpL6hfiWnUkHFKf4veGRjoBFH3klNwZwGOSo+TQERk5
 epCx+5TJIalBA+wBTaW0NgMNFgxp1JdXfwfjz/eWY4htc8INkc214WOUbhEnpL1rVea+GpCOf
 2FHL0zKjP/ogVAW2FcKzkaqe+CPmWf65FYIojkwXEAWflprkETDUPIfIUb7a2KObnyGPHPwmn
 Ga2fd0zYfnolaV7N38gGg5pvxvunFbMKTSs/JMyuF9cTVE0/eEX5P4ZH4OH81RWyuZWwXyaDf
 z3l4Fmb+PtNS+BiDCPWKE1a+Kos7m1byliKnesrJjn+ww=

The value of policy_base is the return value of a devm_ioremap call,
which returns a __iomem pointer instead of an regular pointer.
Add the missing __iomem attribute.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/amd/pmf/pmf.h    | 2 +-
 drivers/platform/x86/amd/pmf/tee-if.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd=
/pmf/pmf.h
index 16999c5b334f..bcf777a5659a 100644
=2D-- a/drivers/platform/x86/amd/pmf/pmf.h
+++ b/drivers/platform/x86/amd/pmf/pmf.h
@@ -229,7 +229,7 @@ struct amd_pmf_dev {
 	struct delayed_work pb_work;
 	struct pmf_action_table *prev_data;
 	u64 policy_addr;
-	void *policy_base;
+	void __iomem *policy_base;
 	bool smart_pc_enabled;
 };

diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/=
amd/pmf/tee-if.c
index f8c0177afb0d..16973bebf55f 100644
=2D-- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform/x86/amd/pmf/tee-if.c
@@ -346,7 +346,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev =
*dev)
 	if (!dev->policy_base)
 		return -ENOMEM;

-	memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz);
+	memcpy_fromio(dev->policy_buf, dev->policy_base, dev->policy_sz);

 	amd_pmf_hex_dump_pb(dev);
 	if (pb_side_load)
=2D-
2.39.2