Received-SPF: pass (google.com: domain of linux-kernel+bounces-78816-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b6bb6a59-67c2-47bc-b8d3-04cf8fd21219@intel.com>
Date: Fri, 23 Feb 2024 09:17:53 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/17] x86/resctrl : Support AMD Assignable Bandwidth
 Monitoring Counters (ABMC)
To: <babu.moger@amd.com>, James Morse <james.morse@arm.com>, <corbet@lwn.net>,
	<fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<bp@alien8.de>, <dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>
References: <20231201005720.235639-1-babu.moger@amd.com>
 <cover.1705688538.git.babu.moger@amd.com>
 <2f373abf-f0c0-4f5d-9e22-1039a40a57f0@arm.com>
 <474ebe02-2d24-4ce3-b26a-46c520efd453@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <474ebe02-2d24-4ce3-b26a-46c520efd453@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3NldjBuQlNRdUVGNlJ5SnBTUG1qMVpNcGpFQ2lZR2w1K092d1dCNEk5aUll?=
 =?utf-8?B?RFl6SFB0d0FkeVVncTBZZ1VXczJ2QmZsMENhbDcyOUhKVUxnQktmaUg5UExP?=
 =?utf-8?B?ek10SlF0dTk4dWpZZnZtTmpxbmRzYUFsRVRQbzU2OTFOaE42eHhtVGxoTDNa?=
 =?utf-8?B?Sk1YQWFZSkRZbFpnTDhOK1NCOThoK0FNcWtyZGloOWxxU05vUkhvU3RqbkY1?=
 =?utf-8?B?TXFMN1hBTzJqK0FHL3A3OU1zVjV0cEFhWk41ZUNqQ2pRTHg0MDJsQUJyWEc4?=
 =?utf-8?B?MnE3ejJyT3lLWUVqTGwyZmFsK2ZXRGhMa2xkY21BdTVaanNVc2YyejV0VzRP?=
 =?utf-8?B?K245M1BDOFVFSzY0bENkK2lQU09lOWYweFlMWWhDV09oaEZaUmtVZTFFcGJw?=
 =?utf-8?B?YmNHUXBvR3BCSVlVV3V4MDNRTmo3eEU3eGhLN21PcnhodFFIMHpIZWhxQzNt?=
 =?utf-8?B?dll0ck8xZ0lMSWRtc3BTV2k3ZWJGeEdrTVhFelZTWlVMUTNtL3AxL2NmS29M?=
 =?utf-8?B?VGh3OWZmRUJSNklhSWhqR2tueHMvOHZaQitRWmFTcDFTNS95eXdwbXhOSEUx?=
 =?utf-8?B?Uzd0Rlo1Q2JDNHFSMWFWTzZLdUFUWDNqajJTK2Z4Vm5NS1NDc1ZwOGNLOXp4?=
 =?utf-8?B?NXZKTFFheHljMTFjUytzUzNpdlcrekVFeDRoY2hFRENMQ3hZdjB0M0J6NldF?=
 =?utf-8?B?S1l2dXRiTGI0a0N3RVpuL0gxcXZXaDVod1R1U29sV2tpSVJ4RU84OVJVMnR0?=
 =?utf-8?B?ZXphMXRjUXg1clYxR2lXckxMVFZWSFdiWCtNa3lxK21kSWYxWTVhV1VRdGZX?=
 =?utf-8?B?RFhwRW9TVHpBSnErRHdTcVhFL2xxOGxqVUV4aXQ3ZzU5UEdpK3pNd2tmR2dq?=
 =?utf-8?B?ZmVJR1gycDZGZVhpdnBWSXBYOURieVZ6RXhYMmdMMHEwanU2RWc2SGhEVWpF?=
 =?utf-8?B?c1pHd0Fid0NjY25vYm9EWk5Odk1DMGx6Q0J6K2J5MkZHWTRITnZqaTMvK0tP?=
 =?utf-8?B?TkYzVTBFM2l5UmRON1FaZ2ZmK1Y4VVNkdnl5V2Vzc0NkVXZhVlJjQThQMC8x?=
 =?utf-8?B?dHNRZGc3dGpINjRxM3c5Q3VQMjBId2RXSFN3WGhGbTBzd2JLbVg5dzg2bHBF?=
 =?utf-8?B?TzZaLzdNakdLb2REK2hxa08xeXlORkx2N3E2WWd3VkI5aHhteGRwVEpxRmxn?=
 =?utf-8?B?bUFCNVl2SklwdGlUbTRoZCt5bDBZcURqMHFPdTFmclVxMms5ZXdIOS9weTBn?=
 =?utf-8?B?V1JidkpTWUVMOTlacisweEd2a2tLWlhkZDcyb0FTTmIzZWJYZE1sZDhVbUl1?=
 =?utf-8?B?MWdIMHFVUmpnSGRzRWJrSGxKTjk3bFBMMmsrQ2pRcFMzbFpETzR1ci96cXFh?=
 =?utf-8?B?WFRJVllJWlJNYTNkZGY4UVVOcWp1YXY5YmEvYlYyNEJPKzREUjFQRjJpRjRY?=
 =?utf-8?B?RjhpbW1Kb0dzZUs2Yk4wUVFpZnZlbmxZUWZnckhCU09XbVEyMzR2VVZ4aEti?=
 =?utf-8?B?bGxsMGxkYmlYWlR5QTU5ODRpY3VYYzFucjBBZUllTFp0UldQUVM0RDhFaHVS?=
 =?utf-8?B?MkN4RUZDRmY3NzgxQWtyZXhWVVlwWlA1bnVuY29pRHV2TTNRZDBOdTg5V0t2?=
 =?utf-8?B?SSs2Mk1rN1RCaVFycERSTUNjOUFvRTlMeTVuNms5TkE5QUYwZ1NSSGIvbG1Z?=
 =?utf-8?B?cG9ML3AzUDZnUEdXREZLTjZpUjZObjN6bWNBcmt1K2I4YzBmU0Z0R2pyd0l0?=
 =?utf-8?B?Mkd2eDVPY25MTzZXSzhodS9IYjI2QTFydG1ldmlLcE9uQW1XZDY3a0tSdVdt?=
 =?utf-8?B?SGxONFpWOUFwcmZvR0Z0N0puNzZOUzNkZlRFVWNVcUpvSTRHdnVrQUtXNkFo?=
 =?utf-8?B?TVR0czNiZGJ1b05UU2JINStZLzdsalB5VzRJNDlKSEZxWm9Qb2JUZ0dJOHB6?=
 =?utf-8?B?andRdXdEYlVIZHV3algrUHkzQzFmVVB3Y0ZkbUs2V28vUUxKaCs1Y3lQa1Zw?=
 =?utf-8?B?THZhTzNuUVJjclNlUGduMkovSmNiTWM4Z3VWcEJqYVlhQzAyZXh1RW5MaVdD?=
 =?utf-8?B?NnZ0TTlJaGJOS0ZqMFhuajNMcGM4V01xcnI5UExGMXJoZ01XY05saVYwVE9q?=
 =?utf-8?B?VkY3cGx5RUFOMnFyaE1QREVxbzJZcWdPSzdJOUIrYndNaThsNlA2MjhTdHI5?=
 =?utf-8?B?OGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b853a67-d3e7-453f-bd13-08dc349360d8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 17:17:57.1407
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ZJ6x53RWCCkKUZDRHS+GmkIc62g5tRO6QU3KADQ9BeGfVy3oBG6h0CVQCBKsW6XIkOxF/i3QpkIVRkoK1i9KZ1wV1v5fQtjaWZdXtKK9pQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6251
X-OriginatorOrg: intel.com


On 2/20/2024 12:48 PM, Moger, Babu wrote:
> On 2/20/24 09:21, James Morse wrote:
>> On 19/01/2024 18:22, Babu Moger wrote:

>>> e. Enable ABMC mode.
>>>
>>> 	#echo 1 > /sys/fs/resctrl/info/L3_MON/mbm_assign_enable
>>>         #cat /sys/fs/resctrl/info/L3_MON/mbm_assign_enable
>>>         1
>>
>> Why does this mode need enabling? Can't it be enabled automatically on hardware that
>> supports it, or enabled implicitly when the first assignment attempt arrives?
>>
>> I guess this is really needed for a reset - could we implement that instead? This way
>> there isn't an extra step user-space has to do to make the assignments work.
> 
> Mostly the new features are added as an opt-in method. So, kept it that
> way. If we enable this feature automatically, then we have provide an
> option to disable it.
> 

At the same time it sounds to me like ABMC can improve current users'
experience without requiring them to do anything. This sounds appealing.
For example, if I understand correctly, it may be possible to start resctrl
with ABMC enabled by default and the number of monitoring groups (currently
exposed to user space via "num_rmids") limited to the number of counters
supported by ABMC. Existing users would then by default obtain better behavior
of counters not resetting.

The "new feature" could then be viewed as adding support for more monitoring
groups than what hardware can support concurrently.

Reinette