Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp3853rbb; Fri, 23 Feb 2024 09:52:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVrmtAne5iuHfPYJ+CjF8lKgDJwNXyBmrMuvfUKfauaH8ltrpnwCp3yVbiB3J5vn0+KHgStR5a2DIepJAGwsg+A8tUCx7L6N7ZY6PfQnA== X-Google-Smtp-Source: AGHT+IGz+ECiULX75+W+/5WoHJHxMb5h00IGU303PEei0ruH8SDe0S0W0x7LcHVRTi7HMllZmZ1h X-Received: by 2002:a05:622a:20c:b0:42e:520c:1d2d with SMTP id b12-20020a05622a020c00b0042e520c1d2dmr560838qtx.58.1708710749426; Fri, 23 Feb 2024 09:52:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708710749; cv=pass; d=google.com; s=arc-20160816; b=xpNv0KwET90PduklaHVUGbUOV7KJtiu6L0usQGUDytdB74g9TNnwt/GJWE+G2oIbYz OSSe7HmR64ZWOrC5zhYaKPvHpaTMI1iALL0RR0aUZ8HHhKayQ3Y9bOIagHA5Y1g70Vju R6t5KAfIymhufX6caTgMSv9R0jIiq20OrBue+v/ZW3RDHi0c4V3SYLDqUOu40Ri/TNG5 NtJ/+qB9JFnEmqUVu/Oed6CE1k/FeYKmHzO3UJlAPWraQRPClZ5//KJzX71Op3r2pKNe V86egaD2Ti9g04zlyP/z1j8DcEaL7hht5O7oqxphIvQuCbfHro/gryl5NgKXab9OahwY cs8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=x5asXBXhtOZ8krhmeWknGrfpLZd9XvhtRWxv+IOZLPY=; fh=p4I1rU897UOFjBPi4SF6V7PwVDGjUwSV/eY2OaPTa8Q=; b=utzZwsAsoc6S2f/Vmc3zE5BsV0wIRzm2LAk1gQnRAaj+yNb753CjXBSuC18MmiimCJ YGynsAx8B747OZqQU58REmRl91LoUbaBPd2v9LNvR3Z0P3kPzgvVqKXne1ds2ttnS+TR +v+fsFlUCODSbv26g7RfUGwuOBmmydIO2qoTrGDoE27zENj9RNVdBydcR0F1kSb4gpBq WR1YZj3COomU69lAfu/4JUWBe/RaXFyVqtQ4BV1mO6kuYlhARaPX9ddI61FjDSxfLsgZ MeexhYxIEunTOP3wS3oimzmH+TfNUanPaUn1iJfN7p53eSfl1zRskA4g3ZWDbK8+5Ogt psLg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=LVSRzWIC; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-78920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78920-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o24-20020a05620a0d5800b007871de8ec5asi15775121qkl.52.2024.02.23.09.52.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 09:52:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=LVSRzWIC; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-78920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78920-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 31CE31C2594B for ; Fri, 23 Feb 2024 17:52:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1FAF142639; Fri, 23 Feb 2024 17:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LVSRzWIC" Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 194761420A0 for ; Fri, 23 Feb 2024 17:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708710687; cv=none; b=IS43EKCuYhHYvKyZG+Aacy69YeLgEBDZyJGXe+iJwffZBWkMwJ3p67IxDTxZ5erUGpFIzp1zFzuHdfxqWSAn9GnlszM9kZkrd6WATKPeSusPdexNYsA5DJgo6r1Z5qgaVKlv/wUPI7nzgwn+U8jQACPL8F7AZK1cObuRMAmPfVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708710687; c=relaxed/simple; bh=cyobtDdfcGLm9EgpUOeJh0auXLdMupXD09HbMz5DS7E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pw0uQlUs5bp4RvuP9sgt8O7XQtj0cLhrRoMSsgiJKKkDicbTT1oH7TCTfNSEy6pUJRFieg+tbJRpq+nQH5emViPGZUtrqHEQxrqSqm6zMujlR/0YpfzbzedNUXCmPuSnZsYoKx6mHZFwJqTEEdZR3v7zubS3bZK+HkurE9fUCDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LVSRzWIC; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-33aeb088324so410383f8f.2 for ; Fri, 23 Feb 2024 09:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1708710682; x=1709315482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x5asXBXhtOZ8krhmeWknGrfpLZd9XvhtRWxv+IOZLPY=; b=LVSRzWICDBkKIvM2DtWlfyx53A8iTDRGRWB5b4rPN4f84qyAnuGjsyZ0Jh07WBV3ER fcIUSMRPXku/n1o2sE9deHB6JruyNd6zsq5elUSgl9NIiJpVTYhPoLK5vuRt+zpf0Z4I 24oTCEltAZwiRXtPT6hgEsWiW2OAMtJX5cUilABqwlUX8f258Y1nC5qqMYo/A74RdgEq 9VkVRdKg5BPk4LRlRRPN09Y0POrT22S+AjYdJ04qCbqm8vGplMgIG9KzZT0d/Cyra0VE okw9IOXVHBQqcsPYtCxJ3oVu4uUXNFekNJgRa/gYd+0dJ/1u4K1ByHOq/e+eshS5v2vS Zv4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708710682; x=1709315482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x5asXBXhtOZ8krhmeWknGrfpLZd9XvhtRWxv+IOZLPY=; b=qqK46uWgKID0hatuufFX8T0NYVp4cwrrNpGKzPFILJJHxWHXjo4JlSU7IJBi608K6R cGu54VAfDAgG1Iwpph/KmF+FODrq4vjU0eAy/n+8XQRu6UR/lANTrUzlCiCrciPJ+ni2 7XYH/5FyDLMT/TIHC9lkpagoeBEacRFEODClR+eFFS31+ijrITTUACSy7oboh4b0Z5C8 EMqEwQtljo9DpRAHRaKysaSoOw/6fon8H3A6LlO9jKw3mhLLVLbpYsdSpfKK5tp7enZH xL9nDOyQTvkybzxx0I3Oq6hDKnixyiN/MgOmreSPNKU3c7rPdOBhCniTWUvTS/GZyLXl OrZg== X-Forwarded-Encrypted: i=1; AJvYcCVRqGfkkZseii0ivhG6Tc9Gse/syv0T1mJNh6bBUMfPwxTLWwmnIZjqTaZxkidfDyFtNbr3T7hfKVhZO/CdFqyMo+mEPLE1Y3vCRNtE X-Gm-Message-State: AOJu0YwZdIk/Wc/RGajMz9ATSLTl7IwsWvsw+3T4XzDfl95k9s+aIlLO GZ7l++Szu6xxXZSNvwKhISFfgFLfuAwpLX5IMuZsurvIMT7JgSLvLMtjl7OL5rU= X-Received: by 2002:a5d:6445:0:b0:33d:a440:636c with SMTP id d5-20020a5d6445000000b0033da440636cmr343739wrw.49.1708710682467; Fri, 23 Feb 2024 09:51:22 -0800 (PST) Received: from toaster.lan ([2a01:e0a:3c5:5fb1:e8a0:25a6:d4ec:a7ff]) by smtp.googlemail.com with ESMTPSA id bo10-20020a056000068a00b0033cddadde6esm3711524wrb.80.2024.02.23.09.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 09:51:22 -0800 (PST) From: Jerome Brunet To: Mark Brown , Liam Girdwood Cc: Jerome Brunet , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: [PATCH 1/6] ASoC: meson: axg-tdm-interface: fix mclk setup without mclk-fs Date: Fri, 23 Feb 2024 18:51:07 +0100 Message-ID: <20240223175116.2005407-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223175116.2005407-1-jbrunet@baylibre.com> References: <20240223175116.2005407-1-jbrunet@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Transfer-Encoding: 8bit By default, when mclk-fs is not provided, the tdm-interface driver requests an MCLK that is 4x the bit clock, SCLK. However there is no justification for this: * If the codec needs MCLK for its operation, mclk-fs is expected to be set according to the codec requirements. * If the codec does not need MCLK the minimum is 2 * SCLK, because this is minimum the divider between SCLK and MCLK can do. Multiplying by 4 may cause problems because the PLL limit may be reached sooner than it should, so use 2x instead. Fixes: d60e4f1e4be5 ("ASoC: meson: add tdm interface driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/meson/axg-tdm-interface.c b/sound/soc/meson/axg-tdm-interface.c index 1c3d433cefd2..cd5168e826df 100644 --- a/sound/soc/meson/axg-tdm-interface.c +++ b/sound/soc/meson/axg-tdm-interface.c @@ -264,8 +264,8 @@ static int axg_tdm_iface_set_sclk(struct snd_soc_dai *dai, srate = iface->slots * iface->slot_width * params_rate(params); if (!iface->mclk_rate) { - /* If no specific mclk is requested, default to bit clock * 4 */ - clk_set_rate(iface->mclk, 4 * srate); + /* If no specific mclk is requested, default to bit clock * 2 */ + clk_set_rate(iface->mclk, 2 * srate); } else { /* Check if we can actually get the bit clock from mclk */ if (iface->mclk_rate % srate) { -- 2.43.0